Jira (PUP-8215) Tag filtering for skip_tag incorrectly expanded

[Kevin Henner (JIRA)]

Kevin Henner created an issue

Puppet / PUP-8215 Tag filtering for skip_tag incorrectly expanded Issue Type: Bug Affects Versions: PUP 5.3.3 Assignee: Unassigned Components: Catalog Application Created: 2017/11/29 10:24 AM Priority: Normal Reporter: Kevin Henner `- skip_tags foo::bar` is split on the namespace separator `::` and expanded to `['foo::bar', 'foo', 'bar']`. Because resources are tagged with all parent tags, this means that every resource in the `foo` namespace is skipped when ` skip_tags foo::bar` is used. The same expansion issue was addressed for the ` tags` flag in PUP-4495 , but it appears that the expansion logic for ` tags` and ` -skip_tags` is separate. Add Comment

This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)

[Kevin Henner (JIRA)]

Kevin Henner updated an issue

Puppet / PUP-8215 Tag filtering for skip_tag incorrectly expanded

Change By: Kevin Henner ` {{ --skip_tags foo::bar ` }}  is split on the namespace separator  `  {{ :: ` }}  and expanded to  `  {{ ['foo::bar', 'foo', 'bar'] ` }} . Because resources are tagged with all parent tags, this means that every resource in the `foo` namespace is skipped when  `  {{ --skip_tags foo::bar ` }}  is used. The same expansion issue was addressed for the  `  {{ --tags ` }}  flag in PUP-4495, but it appears that the expansion logic for  `  {{ --tags ` }}  and  `  {{ --skip_tags ` }}  is separate.

Add Comment

[Kevin Henner (JIRA)]

[Kevin Henner (JIRA)]

Kevin Henner updated an issue

Puppet / PUP-8215 Tag filtering for skip_tag incorrectly expanded Change By: Kevin Henner

{{\--skip_tags foo::bar}}  is split  splits the tag  on the namespace separator {{::}} and  expanded  expands  to  skip the set  {{['foo::bar', 'foo', 'bar']}}. Because resources are tagged with all parent tags, this means that every resource in the `foo` namespace is skipped when {{\--skip_tags foo::bar}} is used. The same expansion issue was addressed for the {{\--tags}} flag in PUP-4495, but it appears that the expansion logic for {{\--tags}} and {{\--skip_tags}} is separate.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8215 Tag filtering for skip_tag incorrectly expanded

Change By: Josh Cooper Team: Platform Core

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8215 Tag filtering for skip_tag incorrectly expanded

Change By: Josh Cooper Sub-team: Coremunity

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Jakub Pieńkowski (JIRA)]

Jakub Pieńkowski commented on PUP-8215

Re: Tag filtering for skip_tag incorrectly expanded I opened pull request fixing this problem: https://github.com/puppetlabs/puppet/pull/7508

Add Comment

[Jacob Helwig (JIRA)]

Jacob Helwig assigned an issue to Jacob Helwig

Puppet / PUP-8215

Tag filtering for skip_tag incorrectly expanded

Change By: Jacob Helwig Assignee: Jacob Helwig

Add Comment

[Jacob Helwig (JIRA)]

Jacob Helwig updated an issue

Puppet / PUP-8215 Tag filtering for skip_tag incorrectly expanded

Change By: Jacob Helwig Sprint: Platform Core KANBAN

Add Comment

[Jacob Helwig (JIRA)]

Jacob Helwig updated an issue

Puppet / PUP-8215 Tag filtering for skip_tag incorrectly expanded

Change By: Jacob Helwig Release Notes Summary: Tags specified via --skip_tags are no longer expanded by splitting on "::". This brings the behavior in line with how tags specified via --tags are handled. The behavior of --tags was fixed in PUP-4495. Release Notes: Bug Fix

Add Comment

[Jacob Helwig (JIRA)]

Jacob Helwig updated an issue

Puppet / PUP-8215 Tag filtering for skip_tag incorrectly expanded

Change By: Jacob Helwig Fix Version/s: PUP 6.5.0

Add Comment

[Jacob Helwig (JIRA)]

Jacob Helwig commented on PUP-8215

Re: Tag filtering for skip_tag incorrectly expanded This was merged into the master branch in c86ad5546d.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-8215

Re: Tag filtering for skip_tag incorrectly expanded

Passed CI in 5c982fea6fd94e1abe8895a1ba28b4ae4134249a

Add Comment

[Heston Hoffman (JIRA)]

Heston Hoffman updated an issue

Puppet / PUP-8215

Tag filtering for skip_tag incorrectly expanded

Change By: Heston Hoffman Labels: resolved-issue-added

Add Comment