Jira (PUP-8188) --render-as broken in puppet config print

3 views
Skip to first unread message

Mike Baynton (JIRA)

unread,
Nov 21, 2017, 11:43:02 AM11/21/17
to puppe...@googlegroups.com
Mike Baynton created an issue
 
Puppet / Bug PUP-8188
--render-as broken in puppet config print
Issue Type: Bug Bug
Affects Versions: PUP 5.y
Assignee: Unassigned
Created: 2017/11/21 8:42 AM
Priority: Normal Normal
Reporter: Mike Baynton

The --render-as option is in puppet config print's documentation and is validated, but has no effect.

For example, 

puppet config print --render-as json

runs successfully, but does not output json.

puppet config print --render-as foo

outputs "Error: Could not parse application options: I don't know how to render 'foo'"
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
Atlassian logo

Josh Cooper (JIRA)

unread,
Nov 27, 2017, 4:55:06 PM11/27/17
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Platform Core

Josh Cooper (JIRA)

unread,
Dec 1, 2017, 5:25:03 PM12/1/17
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-8188
 
Re: --render-as broken in puppet config print

It would be good to use a consistent "format" option as discussed in PUP-6040.

Craig Gomes (JIRA)

unread,
Dec 8, 2017, 5:45:04 PM12/8/17
to puppe...@googlegroups.com
Craig Gomes updated an issue
 
Change By: Craig Gomes
Sub-team: Coremunity

Josh Cooper (JIRA)

unread,
Dec 18, 2017, 5:27:04 PM12/18/17
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core Hopper

Josh Cooper (JIRA)

unread,
Dec 18, 2017, 7:00:26 PM12/18/17
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Acceptance Criteria: Using the {{render-as}} option with valid values, e.g. {{json}} or {{yaml}}, should generate a valid hash of settings, e.g.

{
  "key": "value"
}

or

---
key: value

Puppet settings only contain values that can be represented as strings, numerics or booleans, so I would expect all of those values to convert to the appropriate JSON or YAML type.

Jacob Helwig (JIRA)

unread,
Jan 25, 2018, 5:19:03 PM1/25/18
to puppe...@googlegroups.com
Jacob Helwig updated an issue
Change By: Jacob Helwig
The  \  --render-as option is in puppet config print's documentation and is validated, but has no effect.  {{puppet config print}} should be able to opt out of having {{\--render-as}} shown in its help in favor of showing a new option {{\--format}} to align with {{puppet facts}}. The new {{\--format}} option will need to be created.

For example, 
{code:bash}

puppet config print --render-as json
{code}

runs successfully, but does not output json.

{code:bash}

puppet config print --render-as foo
{code}

outputs "Error: Could not parse application options: I don't know how to render 'foo'"


The {{\--format}} types to support are {{json}}, {{yaml}}, and {{flat}} (the default, also the current output).

Jacob Helwig (JIRA)

unread,
Jan 25, 2018, 5:20:02 PM1/25/18
to puppe...@googlegroups.com
Jacob Helwig commented on Bug PUP-8188
 
Re: --render-as broken in puppet config print

For now, we should leave the config action as a Face.

Josh Cooper (JIRA)

unread,
Jan 25, 2018, 5:24:02 PM1/25/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Acceptance Criteria:
Using the {{render-as}} option with valid values, e.g. {{json}} or {{yaml}}, should generate a valid hash of settings, e.g.

{ code:json}
{
   "key": "value"
}
 {code}

or

 {code:yaml}
 ---
key: value
 {code}

Puppet settings only contain values that can be represented as strings, numerics or booleans, so I would expect all of those values to convert to the appropriate JSON or YAML type.

Jacob Helwig (JIRA)

unread,
Jan 25, 2018, 5:41:02 PM1/25/18
to puppe...@googlegroups.com
Jacob Helwig updated an issue
Change By: Jacob Helwig
Acceptance Criteria:
Using the {{render-as}} option with valid values, e.g. {{json}} or {{yaml}}, should generate a valid hash of settings, e.g.

{code:json}
{
  "key": "value"
}
{code}

or

{code:yaml}
---
key: value
{code}
The key/value should not be nested by section names, and should show the final evaluation of the value for that section using the normal section precedence rules in Puppet .

Puppet  settings only contain values that can be represented as strings, numerics or booleans, so I would expect all of those values to convert to the appropriate JSON or YAML type.

Jacob Helwig (JIRA)

unread,
Jan 25, 2018, 6:03:04 PM1/25/18
to puppe...@googlegroups.com
Jacob Helwig updated an issue
Change By: Jacob Helwig
Acceptance Criteria: Using the {{ render \ - as -format }} option with valid values, e.g. {{json}} or {{yaml}}, should generate a valid hash of settings, e.g.


{code:json}
{
  "key": "value"
}
{code}

or

{code:yaml}
---
key: value
{code}

The key/value should not be nested by section names, and should show the final evaluation of the value for that section using the normal section precedence rules in Puppet.

Puppet settings only contain values that can be represented as strings, numerics or booleans, so I would expect all of those values to convert to the appropriate JSON or YAML type.

Jennifer Solman (JIRA)

unread,
Jan 25, 2018, 6:12:02 PM1/25/18
to puppe...@googlegroups.com
Jennifer Solman assigned an issue to Jennifer Solman
Change By: Jennifer Solman
Assignee: Jennifer Solman

Jennifer Solman (JIRA)

unread,
Jan 25, 2018, 6:14:02 PM1/25/18
to puppe...@googlegroups.com
Jennifer Solman updated an issue
Change By: Jennifer Solman
Sprint: Platform Core  Hopper  KANBAN

Jacob Helwig (JIRA)

unread,
Jan 25, 2018, 7:17:02 PM1/25/18
to puppe...@googlegroups.com
Jacob Helwig commented on Bug PUP-8188
 
Re: --render-as broken in puppet config print

In discussing this ticket the question of whether to include section information in the formatted output came up, when asking for one or more settings from a specific section to show where those settings originated from. Eg:

{
 
  "main": {
 
    "setting1": "value1"
 
  },
 
  "agent": {
 
    "environment": "development"
 
  }
 
}

However, this was decided against to more closely mimic the existing output from puppet config print, and because including this extra information would require an extra level of merging when consuming the emitted JSON/YAML (potentially knowing about and duplicating the exiting section precedence rules in Puppet).

Kenn Hussey (JIRA)

unread,
Feb 7, 2018, 3:33:03 PM2/7/18
to puppe...@googlegroups.com
Kenn Hussey updated an issue
 
Change By: Kenn Hussey
Flagged: Impediment
This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)
Atlassian logo

Jennifer Solman (JIRA)

unread,
Feb 7, 2018, 6:53:04 PM2/7/18
to puppe...@googlegroups.com
Jennifer Solman updated an issue
Change By: Jennifer Solman
Fix Version/s: PUP 5.4.0

Jacob Helwig (JIRA)

unread,
Feb 7, 2018, 6:53:04 PM2/7/18
to puppe...@googlegroups.com
Jacob Helwig updated an issue
Change By: Jacob Helwig
Fix Version/s: PUP 5.4.0

Jennifer Solman (JIRA)

unread,
Feb 7, 2018, 6:55:04 PM2/7/18
to puppe...@googlegroups.com
Jennifer Solman updated an issue
Change By: Jennifer Solman
Fix Version/s: PUP 5.4.0

Jacob Helwig (JIRA)

unread,
Feb 7, 2018, 6:55:04 PM2/7/18
to puppe...@googlegroups.com
Jacob Helwig updated an issue
Change By: Jacob Helwig
Flagged: Impediment

Jacob Helwig (JIRA)

unread,
Feb 22, 2018, 11:22:02 AM2/22/18
to puppe...@googlegroups.com
Jacob Helwig commented on Bug PUP-8188

Jacob Helwig (JIRA)

unread,
Feb 22, 2018, 3:52:02 PM2/22/18
to puppe...@googlegroups.com
Jacob Helwig commented on Bug PUP-8188

Merged to master in 029af35b7.

Jorie Tappa (JIRA)

unread,
Feb 23, 2018, 11:43:03 AM2/23/18
to puppe...@googlegroups.com
Jorie Tappa commented on Bug PUP-8188

Jennifer Solman please add release notes for this ticket.

Jennifer Solman (JIRA)

unread,
Feb 23, 2018, 12:18:04 PM2/23/18
to puppe...@googlegroups.com
Jennifer Solman updated an issue
 
Change By: Jennifer Solman
Release Notes Summary: --render-as option is now working for puppet config print. Supported options are json and yaml. The default format is unchanged.

Jennifer Solman (JIRA)

unread,
Feb 23, 2018, 12:19:02 PM2/23/18
to puppe...@googlegroups.com

Craig Gomes (JIRA)

unread,
Mar 5, 2018, 5:06:03 PM3/5/18
to puppe...@googlegroups.com
Craig Gomes updated an issue
 
Change By: Craig Gomes
Release Notes: Bug Fix
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Eric Delaney (JIRA)

unread,
Mar 12, 2018, 5:10:03 PM3/12/18
to puppe...@googlegroups.com
Eric Delaney assigned an issue to Unassigned
Change By: Eric Delaney
Assignee: Jennifer Solman

Kris Bosland (JIRA)

unread,
Mar 12, 2018, 6:36:04 PM3/12/18
to puppe...@googlegroups.com
Kris Bosland assigned an issue to Kris Bosland
Change By: Kris Bosland
Assignee: Kris Bosland

Kris Bosland (JIRA)

unread,
Mar 13, 2018, 1:07:03 AM3/13/18
to puppe...@googlegroups.com
Kris Bosland assigned an issue to Unassigned

Jorie Tappa (JIRA)

unread,
Mar 13, 2018, 12:53:02 PM3/13/18
to puppe...@googlegroups.com
Jorie Tappa assigned an issue to Jorie Tappa
Change By: Jorie Tappa
Assignee: Jorie Tappa

John Duarte (JIRA)

unread,
Oct 21, 2019, 10:58:04 AM10/21/19
to puppe...@googlegroups.com
John Duarte updated an issue
Change By: John Duarte
QA Risk Assessment: Needs Assessment No Action
Reply all
Reply to author
Forward
0 new messages