Jira (PDB-3652) Throw cli-errors trapperkeeper will actually recognize

[Rob Browning (JIRA)]

Rob Browning updated an issue

PuppetDB / PDB-3652 Throw cli-errors trapperkeeper will actually recognize Change By: Rob Browning Summary: Throw  :type, not :kind from validate  cli - db-settings errors trapperkeeper will actually recognize Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Rob Browning (JIRA)]

Rob Browning updated an issue

PuppetDB / PDB-3652 Throw cli-errors trapperkeeper will actually recognize Change By: Rob Browning

Currently the function pdb currently  throws  the error with a :kind key, but tk  cli - app is looking for :type, and in released versions, will actually throw errors that trapperkeeper won't recognize.  This was originally noticed when  a  completely unrelated  missing config subname caused pdb to exit with a mysterious  keyword?  :pre check error  exception that was actually being thrown by a tk function precondition  ( looks like newer versions have since  adjusted  that code  in tk master ). In any case,  pdb should throw  tk expects  : cli-error to be the exception data : type not :kind  here , and is looking for :message, not :msg: https://github . com/puppetlabs/trapperkeeper/blob/master/src/puppetlabs/trapperkeeper/core.clj#L179 (Will need to be fixed Fix this  on all the relevant branches. )

Add Comment

[Rob Browning (JIRA)]

Rob Browning updated an issue

PuppetDB / PDB-3652 Throw cli-errors trapperkeeper will actually recognize Change By: Rob Browning

pdb currently throws cli-errors that trapperkeeper won't recognize.  This was originally noticed when a missing config subname caused pdb to exit with a mysterious keyword? exception that was actually being thrown by a tk function precondition (since adjusted in tk master).   I saw this myself, and also believe it's the underlying problem here: PDB-3500 In any case, tk expects :cli-error to be the exception data :type not :kind, and is looking for :message, not :msg: https://github.com/puppetlabs/trapperkeeper/blob/master/src/puppetlabs/trapperkeeper/core.clj#L179

Fix this on all the relevant branches.

Add Comment

[Rob Browning (JIRA)]

Rob Browning updated an issue

PuppetDB / PDB-3652 Throw cli-errors trapperkeeper will actually recognize Change By: Rob Browning

pdb currently throws cli-errors that trapperkeeper won't recognize.  This was originally noticed when a missing config subname caused pdb to exit with a mysterious keyword? exception that was actually being thrown by a tk function precondition (since adjusted in tk master).  I saw this myself, and also believe it's the underlying problem here: PDB-3500 In any case, tk expects :cli-error to be the exception data :type not :kind, and is looking for :message, not :msg: https://github.com/puppetlabs/trapperkeeper/blob/master/src/puppetlabs/trapperkeeper/core.clj#L179

This probably affects at least util.clj and config.clj.

Fix this on all the relevant branches.

Add Comment

[Rob Browning (JIRA)]

Rob Browning updated an issue

PuppetDB / PDB-3652 Throw cli-errors trapperkeeper will actually recognize

Change By: Rob Browning Sprint: Data Platform Next Sprint Hopper

Add Comment

[Jeff Yarnell (JIRA)]

Jeff Yarnell updated an issue

PuppetDB / PDB-3652 Throw cli-errors trapperkeeper will actually recognize

Change By: Jeff Yarnell Team: Discovery Pipeline Data Platform

Add Comment

[Jeff Yarnell (JIRA)]

Jeff Yarnell commented on PDB-3652

Re: Throw cli-errors trapperkeeper will actually recognize I reassigned to 'Data Platform' team assuming 'Discovery Pipeline' was incorrect.

Add Comment

[Zachary Kent (JIRA)]

Zachary Kent assigned an issue to Zachary Kent

PuppetDB / PDB-3652

Throw cli-errors trapperkeeper will actually recognize

Change By: Zachary Kent Assignee: Zachary Kent

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Zachary Kent (JIRA)]

[Zachary Kent (JIRA)]

Zachary Kent updated an issue

PuppetDB / PDB-3652 Throw cli-errors trapperkeeper will actually recognize

Change By: Zachary Kent Release Notes: Not Needed Fix Version/s: PDB 6.0.0 Fix Version/s: PDB 5.2.z Fix Version/s: PDB 5.1.z

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

PuppetDB / PDB-3652 Throw cli-errors trapperkeeper will actually recognize

Change By: Kenn Hussey

Fix Version/s: PDB 5.2.z Fix Version/s: PDB 5.1.z

Fix Version/s: PDB 5.2.5 Fix Version/s: PDB 5.1.6

Add Comment

[Zachary Kent (JIRA)]

Zachary Kent updated an issue

PuppetDB / PDB-3652 Throw cli-errors trapperkeeper will actually recognize

Change By: Zachary Kent Fix Version/s: PDB 5.2.5 Fix Version/s: PDB 5.2.6

Add Comment

[Zachary Kent (Jira)]

Zachary Kent updated an issue

PuppetDB / PDB-3652 Throw cli-errors trapperkeeper will actually recognize

Change By: Zachary Kent Sprint:

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Zachary Kent (Jira)]

Zachary Kent updated an issue

PuppetDB / PDB-3652 Throw cli-errors trapperkeeper will actually recognize

Change By: Zachary Kent Sprint: Release Engineering Hopper

Add Comment

[Morgan Rhodes (Jira)]

Morgan Rhodes updated an issue

PuppetDB / PDB-3652 Throw cli-errors trapperkeeper will actually recognize

Change By: Morgan Rhodes Sprint: Release Engineering Hopper

Add Comment