Jira (PDB-3624) Generational fact value GC

6 views
Skip to first unread message

Russell Mull (JIRA)

unread,
Jul 24, 2017, 6:10:03 PM7/24/17
to puppe...@googlegroups.com
Russell Mull updated an issue
 
PuppetDB / New Feature PDB-3624
Generational fact value GC
Change By: Russell Mull
Issue Type: Task New Feature
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Russell Mull (JIRA)

unread,
Jul 24, 2017, 6:10:03 PM7/24/17
to puppe...@googlegroups.com
Russell Mull created an issue
 
PuppetDB / Task PDB-3624
Generational fact value GC
Issue Type: Task Task
Assignee: Unassigned
Created: 2017/07/24 3:09 PM
Priority: Normal Normal
Reporter: Russell Mull

Improve fact value write performance by implementing a simple generational GC.

Potential approach:

  • Add an integer 'generation' column to fact_values
  • All facts come in at generation zero
  • Limit pinpoint fact gc only to values in generation zero, with a partial index of fact_values where generation=0.
  • When doing the first full GC, capture the current set of all fact values with a bloom filter
  • At subsequent full GCs, compare the set of all fact values with the previous set. If the value was maybe present in the last generation, set it to generation 1. If it definitely wasn't in the last generation, set it to generation 0.

Russell Mull (JIRA)

unread,
Jul 26, 2017, 1:47:02 PM7/26/17
to puppe...@googlegroups.com
Russell Mull updated an issue
 
PuppetDB / New Feature PDB-3624
Generational fact value GC
Change By: Russell Mull
Sprint: Hopper Data Platform Next Sprint

Jeff Yarnell (JIRA)

unread,
Aug 2, 2017, 5:52:03 PM8/2/17
to puppe...@googlegroups.com
Jeff Yarnell updated an issue
Change By: Jeff Yarnell
Story Points: 5

Jeff Yarnell (JIRA)

unread,
Aug 2, 2017, 5:57:02 PM8/2/17
to puppe...@googlegroups.com
Jeff Yarnell updated an issue
Improve fact value write performance by implementing a simple generational GC. 


Potential approach:

* Add an integer 'generation' column to fact_values
* All facts come in at generation zero
* Limit pinpoint fact gc only to values in generation zero, with a partial index of fact_values where generation=0. 
* When doing the first full GC, capture the current set of all fact values with a bloom filter
* At subsequent full GCs, compare the set of all fact values with the previous set. If the value was maybe present in the last generation, set it to generation 1. If it definitely wasn't in the last generation, set it to generation 0.
   

Assumption:
- This needs to be in Hoyt release

Jeff Yarnell (JIRA)

unread,
Sep 20, 2017, 7:15:09 PM9/20/17
to puppe...@googlegroups.com
Jeff Yarnell updated an issue
Change By: Jeff Yarnell
Sprint: Bad Sprint

Jeff Yarnell (JIRA)

unread,
Sep 20, 2017, 7:15:13 PM9/20/17
to puppe...@googlegroups.com
Jeff Yarnell updated an issue
Change By: Jeff Yarnell
Sprint: Hopper

Zachary Kent (Jira)

unread,
Mar 10, 2021, 3:33:03 PM3/10/21
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Sprint:
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Zachary Kent (Jira)

unread,
Mar 10, 2021, 3:34:04 PM3/10/21
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Sprint: Release Engineering Hopper

Morgan Rhodes (Jira)

unread,
Mar 11, 2021, 2:28:06 PM3/11/21
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
Change By: Morgan Rhodes
Sprint: Release Engineering Hopper

Claudia Petty (Jira)

unread,
Jun 21, 2023, 10:57:08 AM6/21/23
to puppe...@googlegroups.com
Claudia Petty updated an issue
Change By: Claudia Petty
Labels: new-feature
This message was sent by Atlassian Jira (v8.20.21#820021-sha1:38274c8)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages