Jira (PUP-7799) Puppet::Resources.search fails if conditions provided

[Joshua Partlow (JIRA)]

Joshua Partlow created an issue

Puppet / PUP-7799 Puppet::Resources.search fails if conditions provided Issue Type: Bug Affects Versions: PUP 5.0.1 Assignee: Unassigned Created: 2017/07/21 4:37 PM Priority: Normal Reporter: Joshua Partlow The Puppet::Resource::Ral indirectory appears to attempt to convert ral to_resource() twice when you provide search criteria (shown here with package). I'm guessing the specs are mocked such as to be validating the broken behavior. require 'puppet' require 'pp'   packages = Puppet::Resource.indirection.search("package") pp packages.find { |r| r.name == 'Package/bash' }   begin Puppet::Resource.indirection.search("package/bash") rescue Exception => e pp e.backtrace puts e end   begin Puppet::Resource.indirection.search("package", {:ensure => "installed"}) rescue Exception => e pp e.backtrace puts e end jpartlow@percival:~/work/src/pl/puppet$ be ruby test.rb Package[bash]{:name=>"bash", :ensure=>"4.3-7ubuntu1.7", :provider=>:apt, :configfiles=>:keep, :reinstall_on_refresh=>:false, :loglevel=>:notice} ["/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `block (2 levels) in search'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `each'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `all?'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `block in search'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:26:in `each'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:26:in `find_all'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:26:in `search'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/indirection.rb:270:in `search'", "test.rb:8:in `<main>'"] undefined method `to_resource' for #<Puppet::Resource:0x007f1c8e0d57f8> ["/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `block (2 levels) in search'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `each'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `all?'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `block in search'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:26:in `each'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:26:in `find_all'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:26:in `search'", "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/indirection.rb:270:in `search'", "test.rb:15:in `<main>'"] undefined method `to_resource' for #<Puppet::Resource:0x007f1c8dacac00> Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-7799 Puppet::Resources.search fails if conditions provided

Change By: Josh Cooper Team: Platform Core

Add Comment

[Joshua Partlow (JIRA)]

Joshua Partlow updated an issue

Puppet / PUP-7799 Puppet::Resources.search fails if conditions provided

Change By: Joshua Partlow The [Puppet::Resource::Ral  indirectory  indirection |https://github.com/puppetlabs/puppet/blob/5.0.1/lib/puppet/indirector/resource/ral.rb#L24-L27] appears to attempt to convert ral to_resource() twice when you provide search criteria (shown here with package).  I'm guessing the specs are mocked such as to be validating the broken behavior. {code}

require 'puppet' require 'pp' packages = Puppet::Resource.indirection.search("package") pp packages.find { |r| r.name == 'Package/bash' } begin   Puppet::Resource.indirection.search("package/bash") rescue Exception => e   pp e.backtrace   puts e end begin   Puppet::Resource.indirection.search("package", {:ensure => "installed"}) rescue Exception => e   pp e.backtrace   puts e end

{code} {code}

jpartlow@percival:~/work/src/pl/puppet$ be ruby test.rb  Package[bash]{:name=>"bash", :ensure=>"4.3-7ubuntu1.7", :provider=>:apt, :configfiles=>:keep, :reinstall_on_refresh=>:false, :loglevel=>:notice} ["/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `block (2 levels) in search'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `each'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `all?'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `block in search'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:26:in `each'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:26:in `find_all'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:26:in `search'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/indirection.rb:270:in `search'",  "test.rb:8:in `<main>'"] undefined method `to_resource' for #<Puppet::Resource:0x007f1c8e0d57f8> ["/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `block (2 levels) in search'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `each'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `all?'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:27:in `block in search'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:26:in `each'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:26:in `find_all'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/resource/ral.rb:26:in `search'",  "/home/jpartlow/work/src/pl/puppet/lib/puppet/indirector/indirection.rb:270:in `search'",  "test.rb:15:in `<main>'"] undefined method `to_resource' for #<Puppet::Resource:0x007f1c8dacac00>

{code}

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-7799 Puppet::Resources.search fails if conditions provided

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7799 Puppet::Resources.search fails if conditions provided

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7799 Puppet::Resources.search fails if conditions provided

Change By: Josh Cooper Fix Version/s: PUP 7.9.0 Fix Version/s: PUP 6.24.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7799 Puppet::Resources.search fails if conditions provided

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Fixed bug that prevented the "Puppet::Resource.indirection.search" method from accepting conditions to filter results.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7799

Re: Puppet::Resources.search fails if conditions provided Merged to 6.x in https://github.com/puppetlabs/puppet/commit/41119aa09b25cbdb302888fe550d452c0af85c8c

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-7799

Puppet::Resources.search fails if conditions provided

Change By: Claire Cadman Labels: doc-reviewed

Add Comment