Jira (PDB-3558) Update puppetdb-termini 5 package to dep on puppet-agent >= 5

[Moses Mendoza (JIRA)]

Moses Mendoza created an issue

PuppetDB / PDB-3558 Update puppetdb-termini 5 package to dep on puppet-agent >= 5 Issue Type: Task Assignee: Unassigned Created: 2017/06/14 10:20 AM Priority: Normal Reporter: Moses Mendoza Improvements have gone into Puppet 5 that obsolete processing done in the puppetdb terminus, meaning we're doing a bunch of extra work there. With a hard dep on puppet agent 5 we can rely on the new behavior, remove some of the processing in the terminus, with likely performance and maintainability benefits. For example, the `stringify_` methods in the puppetdb catalog terminus are likely no longer necessary. In Scope Update the dependency that puppetdb-termini expresses on puppet-agent to be versioned, ie puppet-agent >= 5 Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Moses Mendoza (JIRA)]

Moses Mendoza commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5 cc Russell Mull

Add Comment

[Russell Mull (JIRA)]

Russell Mull commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5

This package also needs to install with puppetserver; does it have the agent package as well?

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Ah good point. puppetserver expresses a dependency on puppet-agent as well, and that dependency is also unversioned. I think there had been some talk about updating puppetserver 5 to depend on agent >= 5, but I don't recall if that was decided or done. Jeremy Barlow do you know?

Add Comment

[Jeremy Barlow (JIRA)]

Jeremy Barlow commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Moses Mendoza, our puppetserver packages do already have a minimum puppet-agent version pin, although it is still set to 1.6.0 or newer today, not 5.0.0. See here for RedHat and here for Debian. I assumed it was a given that we were going to update puppetserver to require puppet-agent 5.0. I'll create a ticket now to remind us to do that before we do our release - thanks!

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Perfect thanks Jeremy Barlow - I must have been looking at an older puppet server version or something when I checked.

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Note that the current dev build packages for puppet-agent 5 are actually versioned '4.99' (see http://apt.puppetlabs.com/pool/xenial/puppet5-nightly/p/puppet-agent/). While our rpm packages "provide" puppet >= 4.0.0 which would satisfy an updated dependency on puppet 5.0.0 or later expressed by puppetdb and puppet-server, debian packages can't do this - they can only claim they provide the exact version of the package, currently 4.99. I think this means until we tag those 5.0.0 packages, we can't actually update the debian dependencies of puppetdb and puppet-server to require 5.0.0 or all of our dpkg-based builds will fail on unmet dependencies. Not sure what to do about that. cc Geoff Nichols

Add Comment

[Jeremy Barlow (JIRA)]

Jeremy Barlow commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5

I think for interim CI we'd be okay there, though, right? Currently, we pin puppet-agent to >= 1.6.0 but install a SHA version of puppet-agent during CI runs. The package managers all seem to (dumbly?) tolerate that okay. If we bump the pin to 5.0.0, I was thinking we'd see the same behavior. It'd just mean that we couldn't test those with an older released version of puppet-agent but not sure if we care about that for Puppet 5-based builds in CI at present.

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Moses Mendoza is it sufficient to address this in PDB 5.1.0 (along with PDB-3496)?

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Jeremy Barlow i'm not sure.. the sha versions installed in CI meet the >= 1.6.0 dep I think. I'm not sure we'll have that pinning to >= 5.0.0.

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Kenn Hussey in terms of semver, in my interpretation, updating the dependency in 5.1 would not violate semver (http://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api) as the ultimate result in PDB would not be a change to public api. However, I'm still trying to tease apart the implications of doing or not doing this change for the ecosystem. Currently, FOSS PDB specifies a dependency on puppet < 5.0.0 which I think means that users can't upgrade to Puppet 5 on their FOSS PDB/MOM unless we make this change - PDB 5.0 can be installed only with Puppet Agent 4.10.x or earlier. PE PDB does not specify a versioned dependency on puppet-agent - it's free-floating. So I think we'd be OK there - ie if we do the update in PE PDB 5.1 (presumably meaning the new dependency would go live in Irving). I believe the first thing to be upgraded in PE is the agent, so when PDB is installed/upgraded later, the dependency on Puppet 5.0.0 would already be satisfied. Alternatively for PE we could leave it as-is, ie not specify any versioned requirement at all, and just rely on users taking supported upgrade paths to ensure the right packages are co-installed - thought that feels risky if we're depending on API changes across the projects. Thoughts Joshua Partlow?

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5

I tentatively added the fix version of 5.0.0 to make sure this gets added to the right filters for discussion

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

PuppetDB / PDB-3558

Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Change By: Moses Mendoza Fix Version/s: PDB 5.0.0

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

PuppetDB / PDB-3558 Update puppetdb-termini 5 package to dep on puppet-agent >= 5 Change By: Moses Mendoza

Improvements have gone into Puppet 5 that obsolete processing done in the puppetdb terminus, meaning we're doing a bunch of extra work there.  With a hard dep on puppet agent 5 we can rely on the new behavior, remove some of the processing in the terminus, with likely performance and maintainability benefits. For example, the `stringify_` methods in the puppetdb catalog terminus are likely no longer necessary.

*In Scope* * Update the dependency that puppetdb-termini expresses on puppet-agent to be versioned, ie puppet-agent >= 5 *Update* Currently, FOSS PDB specifies a dependency on puppet < 5.0.0 which may mean that users can't upgrade to Puppet 5 on their FOSS PDB/MOM unless we make this change - PDB 5.0 can be installed only with Puppet Agent 4.10.x or earlier.

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

PuppetDB / PDB-3558 Update puppetdb-termini 5 package to dep on puppet-agent >= 5 Change By: Moses Mendoza

Improvements have gone into Puppet 5 that obsolete processing done in the puppetdb terminus, meaning we're doing a bunch of extra work there.  With a hard dep on puppet agent 5 we can rely on the new behavior, remove some of the processing in the terminus, with likely performance and maintainability benefits. For example, the `stringify_` methods in the puppetdb catalog terminus are likely no longer necessary. *In Scope* * Update the dependency that puppetdb-termini expresses on puppet-agent to be versioned, ie puppet-agent >= 5 *Update*

Currently, FOSS PDB specifies a dependency on  {{  puppet  (  < <  5.0.0 -1puppetlabs1)}}  which may mean that users can't upgrade to Puppet 5 on their FOSS PDB/MOM unless we make this change - PDB 5.0 can be installed only with Puppet Agent 4.10.x or earlier.

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

PuppetDB / PDB-3558 Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Change By: Kenn Hussey Flagged: Impediment

Add Comment

[Russell Mull (JIRA)]

Russell Mull updated an issue

PuppetDB / PDB-3558 Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Change By: Russell Mull Sprint: Hopper

Add Comment

[Jeremy Barlow (JIRA)]

Jeremy Barlow commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5 Geoff Nichols, I'm doing some testing with that right now with puppetserver packages. I can confirm that our CI would blow up if we tried to pin puppetserver's dependency on puppet-agent to >= 5.0.0, as Moses Mendoza had suspected. >= 4.9.9 might work fine with current packages, though. I'll do a little more testing with that as a sanity check. If it works, I'll get a PR up for that today.

Add Comment

[Jeremy Barlow (JIRA)]

Jeremy Barlow commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5

>= 4.99.0 or greater appears to work fine for each of the OSes we package for puppetserver. I put up a puppetserver PR here: https://github.com/puppetlabs/puppetserver/pull/1431.

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey commented on PDB-3558

Re: Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Russell Mull please provide release notes for this issue, if applicable.

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

PuppetDB / PDB-3558

Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Change By: Kenn Hussey Flagged: Impediment

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

PuppetDB / PDB-3558 Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Change By: Kenn Hussey Fix Version/s: PDB 5.0.0 Fix Version/s: PDB 5.0.1

Add Comment

[Rob Browning (JIRA)]

Rob Browning updated an issue

PuppetDB / PDB-3558 Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Change By: Rob Browning Release Notes Summary: PuppetDB is no longer compatible with agent and server versions older than 5.0.0.

Add Comment

[Rob Browning (JIRA)]

Rob Browning updated an issue

PuppetDB / PDB-3558 Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Change By: Rob Browning Release Notes: Deprecation

Add Comment

[Zachary Kent (Jira)]

Zachary Kent updated an issue

PuppetDB / PDB-3558 Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Change By: Zachary Kent Sprint:

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Zachary Kent (Jira)]

Zachary Kent updated an issue

PuppetDB / PDB-3558 Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Change By: Zachary Kent Sprint: Release Engineering Hopper

Add Comment

[Morgan Rhodes (Jira)]

Morgan Rhodes updated an issue

PuppetDB / PDB-3558 Update puppetdb-termini 5 package to dep on puppet-agent >= 5

Change By: Morgan Rhodes Sprint: Release Engineering Hopper

Add Comment