Jira (PUP-7646) Environment_timeout should be configurable per environment but not from a file inside of the environment

1 view
Skip to first unread message

Nick Walker (JIRA)

unread,
Jun 9, 2017, 7:12:02 PM6/9/17
to puppe...@googlegroups.com
Nick Walker created an issue
 
Puppet / Bug PUP-7646
Environment_timeout should be configurable per environment but not from a file inside of the environment
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2017/06/09 4:11 PM
Priority: Normal Normal
Reporter: Nick Walker

The Problem

I'd like to set `environment_timeout = unlimited` for my production environment and any other long lived environments I may have.

I'd like all of my feature branch environments to have a much lower environment_timeout so they do no consume memory long after I've stopped using them.

Since environment.conf is in my control-repo I cannot change environment_timeout to a different value without eventually causing that value to become a merge conflict.

Suggested Solution

I should be able to set environment_timeout ( and possibly other puppet.conf settings ) for an environment in a file outside of the environment.

The environment sections in puppet.conf would have probably been fine if they hadn't been removed when directory environments were introduced.

https://docs.puppet.com/puppet/3.5/config_file_main.html#environment-config-sections

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Jun 12, 2017, 5:20:02 AM6/12/17
to puppe...@googlegroups.com
Henrik Lindberg commented on Bug PUP-7646
 
Re: Environment_timeout should be configurable per environment but not from a file inside of the environment

While I understand that pain here. Also understand the pain when a user with thousands of environments made a decision to set timeout in all of them, and then did not want that. It is simply a pain to manage.

The thing is - it should not be a user concern at all ! Puppet should be able to do the right thing and perform optimally (=to the best of its ability) without users having to do the tradeoff. I would rather spend time fixing that and getting rid of environment_timeout completely.

Nick Walker (JIRA)

unread,
Jun 12, 2017, 10:16:02 AM6/12/17
to puppe...@googlegroups.com
Nick Walker commented on Bug PUP-7646

Henrik Lindberg Sure, the fix, in theory, is straight forward. Puppet Server should only load code and hiera data once for all Jruby instances that need it. Environment_timeout wouldn't matter that much if we weren't dealing with loading code and data into each jruby instance that runs inside of Puppet Server. CC Jeremy Barlow

If we have no intention of completing this and the other settings configurable in environment.conf don't require changing per-environment then I'm fine closing this out. I've been running into this problem intermittently for a while and I thought I'd document it.

Henrik Lindberg (JIRA)

unread,
Jun 13, 2017, 3:24:02 AM6/13/17
to puppe...@googlegroups.com

Let's keep this ticket as an example of the kinds of issues that occur with the current solution.

Josh Cooper (Jira)

unread,
Aug 21, 2020, 3:13:03 AM8/21/20
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-7646

Closing this in favor of PUP-8014

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages