Jira (PDB-3541) Fix shutdown hang on on flush-and-exit (at least for db ver check)

6 views
Skip to first unread message

Rob Browning (JIRA)

unread,
May 31, 2017, 1:11:05 PM5/31/17
to puppe...@googlegroups.com
Rob Browning created an issue
 
PuppetDB / Bug PDB-3541
Fix shutdown hang on on flush-and-exit (at least for db ver check)
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2017/05/31 10:10 AM
Priority: Normal Normal
Reporter: Rob Browning

I haven't tracked down the hang yet, but I at the moment, I suspect it's because we're not calling close on the pdb service. I need to go double-check just how System/exit interacts with daemon and non-daemon threads.

As a "cleaner" alternative, I've also tried using tk's request-shutdown, and that seems promising, but it causes new exceptions when close fails on unexpected nils. We might want to use tk's shutdown-on-error. It'll produce an unwanted backtrace, but might be the only way to shutdown "normally" for now with a non-zero exit status.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Rob Browning (JIRA)

unread,
May 31, 2017, 5:48:03 PM5/31/17
to puppe...@googlegroups.com

Rob Browning (JIRA)

unread,
May 31, 2017, 5:51:03 PM5/31/17
to puppe...@googlegroups.com
Rob Browning assigned an issue to Unassigned

Rob Browning (JIRA)

unread,
Jun 5, 2017, 3:20:03 PM6/5/17
to puppe...@googlegroups.com
Rob Browning assigned an issue to Rob Browning

Rob Browning (JIRA)

unread,
Jun 7, 2017, 4:27:03 PM6/7/17
to puppe...@googlegroups.com
Rob Browning updated an issue
Change By: Rob Browning
Release Notes Summary: (Might belong alongside the documentation of the postgresql 9.6 requirement.)

PuppetDB should now shut down with a non-zero exit status when it detects an unsupported PostgreSQL version.  Previously it might hang while trying to exit.
Release Notes: Bug Fix

Rob Browning (JIRA)

unread,
Jun 7, 2017, 4:29:03 PM6/7/17
to puppe...@googlegroups.com
Rob Browning updated an issue
Change By: Rob Browning
Fix Version/s: PDB 5.0.0
Fix Version/s: PDB 4.4.1

Zachary Kent (Jira)

unread,
Mar 10, 2021, 3:33:02 PM3/10/21
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Sprint:
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Zachary Kent (Jira)

unread,
Mar 10, 2021, 3:34:04 PM3/10/21
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Sprint: Release Engineering Hopper

Morgan Rhodes (Jira)

unread,
Mar 11, 2021, 2:25:03 PM3/11/21
to puppe...@googlegroups.com
Morgan Rhodes updated an issue
Change By: Morgan Rhodes
Sprint: Release Engineering Hopper
Reply all
Reply to author
Forward
0 new messages