Jira (PUP-7493) The 'desired_value' as File mode is reported without leading zeros

[Filip Hrbek (JIRA)]

Filip Hrbek created an issue

Puppet / PUP-7493 The 'desired_value' as File mode is reported without leading zeros Issue Type: Bug Affects Versions: PUP 4.10.1 Assignee: Unassigned Created: 2017/05/03 6:57 AM Priority: Normal Reporter: Filip Hrbek A file mode change is reported inaccurately, for example, if the desired file mode value is '0640' and the actual value is '0660', the 'desired_value' is reported as '640', i.e. losing the leading zero. We can observe this behaviour in PE 2016.4 (with puppet 4.10.1) and later but we didn't dive deeper in history, so this bug might have been there even since much older versions. Here's a snippet of a real report containing a trimmed file mode value in the event: File[pe-internal-mcollective-servers.cert.pem]: !ruby/object:Puppet::Resource::Status title: pe-internal-mcollective-servers.cert.pem file: "/opt/puppetlabs/puppet/modules/puppet_enterprise/manifests/master/keypair.pp" line: 30 resource: File[pe-internal-mcollective-servers.cert.pem] resource_type: File containment_path: - Stage[main] - Puppet_enterprise::Profile::Master::Mcollective - Puppet_enterprise::Master::Keypair[pe-internal-mcollective-servers] - File[pe-internal-mcollective-servers.cert.pem] evaluation_time: 0.002628581 tags: - file - pe-internal-mcollective-servers.cert.pem - puppet_enterprise::master::keypair - puppet_enterprise - master - keypair - pe-internal-mcollective-servers - class - puppet_enterprise::profile::master::mcollective - profile - mcollective - node - default time: '2017-04-28T11:07:47.359181163+00:00' failed: false changed: true out_of_sync: true skipped: false change_count: 1 out_of_sync_count: 1 events: - !ruby/object:Puppet::Transaction::Event audited: false property: mode previous_value: '0660' desired_value: '640' historical_value: message: mode changed '0660' to '0640' name: :mode_changed status: success time: 2017-04-28 11:07:47.360815071 +00:00 redacted: corrective_change: true corrective_change: true This is the related puppet manifest that does contain the leading zero: define puppet_enterprise::master::keypair( $keypair_name = $title, ){ File { owner => $puppet_enterprise::params::puppet_user, group => $puppet_enterprise::params::puppet_group, mode => '0640', require => Package['pe-puppetserver'], }   $cert_dir = "${puppet_enterprise::params::ssl_dir}/certs" $private_key_dir = "${puppet_enterprise::params::ssl_dir}/private_keys" $public_key_dir = "${puppet_enterprise::params::ssl_dir}/public_keys"   file { "${keypair_name}.cert.pem": path => "${cert_dir}/${keypair_name}.pem", content => file("${cert_dir}/${keypair_name}.pem", '/dev/null'), }   file { "${keypair_name}.private_key.pem": path => "${private_key_dir}/${keypair_name}.pem", content => Sensitive(file("${private_key_dir}/${keypair_name}.pem", '/dev/null')), }   file { "${keypair_name}.public_key.pem": path => "${public_key_dir}/${keypair_name}.pem", content => file("${public_key_dir}/${keypair_name}.pem", '/dev/null'), } } Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Mindy Moreland (JIRA)]

Mindy Moreland commented on PUP-7493

Re: The 'desired_value' as File mode is reported without leading zeros Known issue added to PE 2016.4, 2016.5, 2017,1, and 2017.2.

Add Comment

[Mindy Moreland (JIRA)]

Mindy Moreland updated an issue

Puppet / PUP-7493

The 'desired_value' as File mode is reported without leading zeros

Change By: Mindy Moreland Labels: doc_reviewed

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-7493 The 'desired_value' as File mode is reported without leading zeros

Change By: Geoff Nichols Labels: doc_reviewed  needs_epic

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-7493

Re: The 'desired_value' as File mode is reported without leading zeros I think it's related to: elsif value =~ /^0?[0-7]{1,4}$/ then return value.to_i(8).to_s(8) in symbolic_file_modes.rb, which is triggered during munge. Apparently the insync? relies on comparing octal values without a leading 0.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-7493

The 'desired_value' as File mode is reported without leading zeros

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7493 The 'desired_value' as File mode is reported without leading zeros

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Gabriel Nagy (Jira)]

Gabriel Nagy updated an issue

Puppet / PUP-7493 The 'desired_value' as File mode is reported without leading zeros

Change By: Gabriel Nagy Fix Version/s: PUP 7.9.0 Fix Version/s: PUP 6.24.0

Add Comment

[Gabriel Nagy (Jira)]

Gabriel Nagy commented on PUP-7493

Re: The 'desired_value' as File mode is reported without leading zeros Merged to 6.x in https://github.com/puppetlabs/puppet/commit/123dfd2f28adcd11155075f8f774b7f5ae7be039

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7493

Re: The 'desired_value' as File mode is reported without leading zeros

Passed CI in 22699d4a48

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7493

The 'desired_value' as File mode is reported without leading zeros

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Puppet reports for octal file modes now include a leading zero in the `desired_value` field, eg "0755", to be consistent with the `previous_value`.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7493 The 'desired_value' as File mode is reported without leading zeros

Change By: Josh Cooper Comment: Passed CI in 22699d4a48

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7493

Re: The 'desired_value' as File mode is reported without leading zeros Passed CI in e6ba8f9345

Add Comment