Jira (PUP-686) --detailed-exit-codes not honored when --noop is used

[Rob Nelson (JIRA)]

Rob Nelson commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used The redmine ticket suggests this be put in the 3.x branch. Is that still correct, or will this be deferred to 4.x? Add Comment

This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e)

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used

It will have to be 4.x, since this is a new feature. However, we still need to make a decision as to whether this is the right thing to do.

Add Comment

[Gareth Rushgrove (JIRA)]

Gareth Rushgrove commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used

With regards whether this is the right thing to do, I wanted to do this just a few days ago. My usecase was using noop for auditing, watching for changes and throwing an error if any where found. I found the existing experience surprising. I ended up doing something horrible with --lastrunfile, --postrun_command and this shell script: https://github.com/puppetlabs/puppetlabs-aws/blob/master/examples/audit-security-groups/count_out_of_sync_resources.sh

Add Comment

[Andrew Kerr (JIRA)]

Andrew Kerr commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used

I would also very much appreciate this feature, and I absolutely think it is the right approach. My use case is that I'd like to run puppet on a sensitive production machine, but not actually change anything since it requires approval. If the exit code indicates that changes would have been made, which is what you'd expect --detailed-exitcodes do to even now, then I'd like to trigger a monitoring alert and have the owner of the machine fix the issue. Is there reason / use case where you'd add --detailed-exitcodes and --noop and NOT expect the exit code to reflect the run results?

Add Comment

This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen assigned an issue to Unassigned

Puppet / PUP-686

--detailed-exit-codes not honored when --noop is used

Change By: Charlie Sharpsteen Assignee: Charlie Sharpsteen Scrum Team: Client Platform

Add Comment

This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)

[Tim Abbott (JIRA)]

Tim Abbott commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used I would also find this feature super useful; it's exactly what you'd want to (for example) have an auditing/monitoring/Nagios check for whether a machine is up to date with a set of puppet manifests. And I agree with the other posters that if you pass `--noop --detailed-exitcodes`, this is the only reasonable interpretation of what exit status you want.

Add Comment

This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)

[Tim Abbott (JIRA)]

Tim Abbott updated an issue

Puppet / PUP-686

--detailed-exit-codes not honored when --noop is used

Change By: Tim Abbott According to the man page, >--detailed-exitcodes >   Provide transaction information via exit codes. If this is enabled, an exit code of '2' means there were changes, an exit code of '4' means there were failures during the transaction, and an exit code of '6' means there were >   both changes and failures. If --noop is used, puppet always returns with an exit code of 0. While technically correct, as nothing changed, it is not the expected result nor is it terribly useful. Puppet should return 0 if nothing would have changed, 2 if something would have changed, 4 if errors and 6 if potential changes and errors when ran with --noop.

Add Comment

[David Kramer (JIRA)]

David Kramer updated an issue

Puppet / PUP-686 --detailed-exit-codes not honored when --noop is used

Change By: David Kramer Sprint: Client Triage

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

Puppet / PUP-686 --detailed-exit-codes not honored when --noop is used

Change By: Kenn Hussey Sprint: Client Triage

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Eric Thompson (JIRA)]

Eric Thompson updated an issue

Puppet / PUP-686 --detailed-exit-codes not honored when --noop is used

Change By: Eric Thompson Team: Agent & Platform

Add Comment

[Sean McDonald (JIRA)]

Sean McDonald updated an issue

Puppet / PUP-686 --detailed-exit-codes not honored when --noop is used

Change By: Sean McDonald Labels: customer redmine  triaged

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

Puppet / PUP-686 --detailed-exit-codes not honored when --noop is used

Change By: Moses Mendoza Labels: customer redmine  triaged

Add Comment

[Naeem (JIRA)]

Naeem commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used Agreed, that this would be a really useful feature for auditing, monitoring purposes. This request has been created more than 4 years ago. Is is possible to get an ETA on this?

Add Comment

This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)

[Deniss Dolbenovs (JIRA)]

Deniss Dolbenovs commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used

Any ETA available on this?

Add Comment

[Michele Baldessari (JIRA)]

Michele Baldessari commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used

Here is an initial pass at fixing this: https://github.com/puppetlabs/puppet/pull/6660 . First puppet patch, so appreciate feedback.

Add Comment

This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)

[Jacob Helwig (JIRA)]

Jacob Helwig assigned an issue to Jacob Helwig

Puppet / PUP-686

--detailed-exit-codes not honored when --noop is used

Change By: Jacob Helwig Assignee: Jacob Helwig

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Branan Riley (JIRA)]

Branan Riley commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used Making 2 indicate that noop resources are out-of-sync would make mixed-noop situations ambiguous in the exit code. Perhaps we should introduce 8 to indicate that there are noop resources that want to be changed? (which of course can be combined with the existing 1, 2, and 4)

Add Comment

[Jacob Helwig (JIRA)]

Jacob Helwig commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used

I'm in favor of Branan Riley's suggestion of using 8 in the exit bitmask to indicate that a noop resource is out of sync, as we can use that even when --noop isn't used, and there are "noop => true" resources in the catalog.

Add Comment

[Rob Nelson (JIRA)]

Rob Nelson commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used

I think 8 sounds fine for a noop run. When in a yesop run but with noop resources that changed, what would the return code be, 2 or 8?

Add Comment

[Jacob Helwig (JIRA)]

Jacob Helwig commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used

Depends on what else is in the catalog. The exit code from --detailed-exit-codes is actually a bitmask, so if the resource that was out of sync was noop => true it would set bit 4 (integer 8), if the resource is not noop then it'll set bit 2 (integer 2), so if there were both noop, and non-noop resources that were out of sync, it would have both bits set, and be an exit code of 10.

Add Comment

[Rob Nelson (JIRA)]

Rob Nelson commented on PUP-686

Re: --detailed-exit-codes not honored when --noop is used

Works for me!

Add Comment

[Alvin Rodis (Jira)]

Alvin Rodis updated an issue

Puppet / PUP-686

--detailed-exit-codes not honored when --noop is used

Change By: Alvin Rodis Zendesk Ticket Count: 1 Zendesk Ticket IDs: 48124

Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

[Alvin Rodis (Jira)]

Alvin Rodis updated an issue

Puppet / PUP-686 --detailed-exit-codes not honored when --noop is used

Change By: Alvin Rodis Labels: customer jira_escalated redmine

Add Comment