Jira (PUP-7397) FileBucket should use `Puppet::Util::replace_file` to write contents

[Moses Mendoza (JIRA)]

Moses Mendoza created an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents Issue Type: Bug Assignee: Unassigned Created: 2017/03/23 2:44 PM Priority: Normal Reporter: Moses Mendoza Per feedback on PR for PUP-1334, https://github.com/puppetlabs/puppet/pull/5704, it would be ideal to use Puppet::Util::replace_file to write the contents file instead of Puppet::FileSystem::open. Due to PUP-7394 and PUP-7395 doing so at the time of filing this ticket was not optimal, but once those are addressed this change should be made. See https://github.com/MosesMendoza/puppet/commit/9f1bf4b3a186942439f41a282c57823bae4af5a2 for an implementation Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Moses Mendoza Sprint: Agent Triage

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Geoff Nichols Team: Agent

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Geoff Nichols Fix Version/s: PUP 5.y

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Geoff Nichols Sprint: Agent Triage

Add Comment

[Ethan Brown (JIRA)]

Ethan Brown updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Ethan Brown Labels: triaged

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-7397

Re: FileBucket should use `Puppet::Util::replace_file` to write contents We could implement this in a way that isn't blocked by 7394 and 7395. Just open the contents file in mode 0640 instead of 0440 (since we have to write to it anyways), then after we're done change the mode to 0440 (or leave it writable by owner).

Add Comment

This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-7397

FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Josh Cooper Fix Version/s: PUP 5.y Fix Version/s: PUP 5.4.0

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Josh Cooper Acceptance Criteria: We should use Puppet::Util.replace_file when the server writes the contents and paths files in the file bucket. This is best tested by running multiple agents and have them backup the same sets of files concurrently. If we are not atomically updating files, then you should warnings to the effect of "FileBucket got a duplicate file" and "Unable to verify FileBucket backup", and "Existing backup does not match its expected sum"

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Josh Cooper Sprint: Platform Core Hopper

Add Comment

[Jorie Tappa (JIRA)]

Jorie Tappa commented on PUP-7397

Re: FileBucket should use `Puppet::Util::replace_file` to write contents Josh Cooper so is this ticket just a one line fix in file.rb for mode when opening, or is there more to this that I'm missing?

Add Comment

[Jorie Tappa (JIRA)]

Jorie Tappa assigned an issue to Jorie Tappa

Puppet / PUP-7397

FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Jorie Tappa Assignee: Jorie Tappa

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Josh Cooper Sub-team: Coremunity

Add Comment

[Jorie Tappa (JIRA)]

Jorie Tappa updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Jorie Tappa Sprint: Platform Core  Hopper  KANBAN

Add Comment

[Jorie Tappa (JIRA)]

Jorie Tappa updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Jorie Tappa Acceptance Criteria: We should use Puppet::Util.replace_file when the server writes the contents and paths files in the file bucket. This is best tested by running multiple agents and have them backup the same sets of files concurrently.  If we are not atomically updating files, then you  You  should  see  warnings to the effect of "FileBucket got a duplicate file" and  you will never see  "Unable to verify FileBucket backup", and "Existing backup does not match its expected sum"

Add Comment

[Jorie Tappa (JIRA)]

Jorie Tappa updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Jorie Tappa Acceptance Criteria: We should use Puppet::Util.replace_file when the server writes the contents and paths files in the file bucket. This is best tested by running multiple agents and have them backup the same sets of files concurrently. You should see warnings to the effect of "FileBucket got a duplicate file" and you  will  should  never see "Unable to verify FileBucket backup", and "Existing backup does not match its expected sum"

Add Comment

[Jorie Tappa (JIRA)]

Jorie Tappa updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Jorie Tappa Acceptance Criteria: We should use Puppet::Util.replace_file when While uploading a large file to  the  server writes  filebucket, attempting to retrieve a file with  the  contents and paths files in  same hash from  the  filebucket should not result in partial  file  bucket  content .  This is best tested by running multiple agents and have them backup the same sets of files concurrently.  You should  see warnings to  either get no content, in  the  effect of "FileBucket got  case where it's  a  duplicate  new  file " and , or  you should  never see "Unable to verify FileBucket backup", and "Existing backup does not match its expected sum"  get the complete file in the case where the file was already existing in the filebucket.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-7397

Re: FileBucket should use `Puppet::Util::replace_file` to write contents Merged to master in https://github.com/puppetlabs/puppet/commit/70e54bbd921a81d0e392e0d0aa646c181c826473

Add Comment

[Melissa Stone (JIRA)]

Melissa Stone assigned an issue to Melissa Stone

Puppet / PUP-7397

FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Melissa Stone Assignee: Jorie Tappa Melissa Stone

Add Comment

[Melissa Stone (JIRA)]

Melissa Stone commented on PUP-7397

Re: FileBucket should use `Puppet::Util::replace_file` to write contents I manually verified this code change in both windows and non-windows, and it is behaving as expected

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey commented on PUP-7397

Re: FileBucket should use `Puppet::Util::replace_file` to write contents

Jorie Tappa please add release notes for this issue, if needed. Thanks!

Add Comment

This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)

[Jorie Tappa (JIRA)]

Jorie Tappa updated an issue

Puppet / PUP-7397

FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: Jorie Tappa Release Notes Summary: File bucket contents are now atomically updated, this resolves a race condition where retrieving a file from the file bucket could result in retrieving a partial file. Release Notes: Bug Fix

Add Comment

[John Duarte (JIRA)]

John Duarte updated an issue

Puppet / PUP-7397 FileBucket should use `Puppet::Util::replace_file` to write contents

Change By: John Duarte QA Risk Assessment: Needs Assessment No Action

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)