Jira (PUP-7311) runit service restart override doesn't work

[Oskar Levin (JIRA)]

Oskar Levin created an issue

Puppet / PUP-7311 runit service restart override doesn't work Issue Type: Bug Assignee: Unassigned Created: 2017/03/07 4:39 AM Environment: CentOS 6.8, puppet-3.8.7-1.el6.noarch downloaded from http://yum.puppetlabs.com/el/6/products/ Priority: Normal Reporter: Oskar Levin When supplying the restart command, it still runs sv restart oskar-test-service rather than the restart command I specified. service { 'oskar-test-service': provider => 'runit', ensure => 'running', restart => '/bin/kill -HUP \$(cat /etc/service/oskar-test-service/supervise/pid)', } Using this on CentOS 7 and with systemd and it seems to work there, but not with the runit provider. Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[John Duarte (JIRA)]

John Duarte updated an issue

Puppet / PUP-7311 runit service restart override doesn't work

Change By: John Duarte Sprint: Agent Triage

Add Comment

[John Duarte (JIRA)]

John Duarte updated an issue

Puppet / PUP-7311 runit service restart override doesn't work

Change By: John Duarte Team: Agent

Add Comment

[Oskar Levin (JIRA)]

Oskar Levin updated an issue

Puppet / PUP-7311 runit service restart override doesn't work

Change By: Oskar Levin

When supplying the restart command, it still runs sv restart oskar-test-service rather than the restart command I specified. service { 'oskar-test-service':   provider => 'runit',   ensure => 'running',   restart => '/bin/kill -HUP \$(cat /etc/service/oskar-test-service/supervise/pid)', } Using this on CentOS 7 and with systemd and it seems to work there, but not with the runit provider.

Related/useful links: https://projects.puppetlabs.com/issues/2642 https://projects.puppetlabs.com/issues/18021

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-7311 runit service restart override doesn't work

Change By: Geoff Nichols Sprint: Agent Triage

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-7311 runit service restart override doesn't work

Change By: Geoff Nichols Team: Agent

Add Comment

[Eric Delaney (JIRA)]

Eric Delaney updated an issue

Puppet / PUP-7311 runit service restart override doesn't work

Change By: Eric Delaney Sprint: Agent Triage

Add Comment

[Eric Delaney (JIRA)]

Eric Delaney updated an issue

Puppet / PUP-7311 runit service restart override doesn't work

Change By: Eric Delaney Team: Agent

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-7311 runit service restart override doesn't work

Change By: Geoff Nichols Sprint: Agent  Triage  Accepted

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-7311 runit service restart override doesn't work

Change By: Geoff Nichols Sprint: Agent Accepted

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-7311 runit service restart override doesn't work

Change By: Josh Cooper

When supplying the restart command, it still runs sv restart oskar-test-service rather than the restart command I specified.

{code:puppet}

service { 'oskar-test-service':   provider => 'runit',   ensure => 'running',   restart => '/bin/kill -HUP \$(cat /etc/service/oskar-test-service/supervise/pid)', }

{code}

Using this on CentOS 7 and with systemd and it seems to work there, but not with the runit provider. Related/useful links: https://projects.puppetlabs.com/issues/2642 https://projects.puppetlabs.com/issues/18021

Add Comment

[Ethan Brown (JIRA)]

Ethan Brown updated an issue

Puppet / PUP-7311 runit service restart override doesn't work

Change By: Ethan Brown Labels: triaged

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-7311

Re: runit service restart override doesn't work runit and daemontools don't implement the logic to override the restart logic.

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza commented on PUP-7311

Re: runit service restart override doesn't work

relevant code section is https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/service/runit.rb#L98-L100

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-7311

runit service restart override doesn't work

Change By: Branan Riley Labels: linux runit service triaged type_and_provider

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7311

Re: runit service restart override doesn't work Oskar Levin the runit service provider hasn't been updated in a very long time, and we are unlikely to spend any time on this, so I'm going to close this. If you wanted to submit a pull request to override the restart logic that'd be great. Just reopen this and reach out in slack if you have any questions about how to get started.

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)