Jira (PDB-3284) PQL operators sometimes whitespace sensitive

[Daniel Parks (JIRA)]

Daniel Parks created an issue

PuppetDB / PDB-3284 PQL operators sometimes whitespace sensitive Issue Type: Bug Assignee: Unassigned Created: 2017/01/27 4:28 PM Environment: CentOS Linux release 7.3.1611 (Core) pe-puppetdb-4.2.5-1.el7.noarch Priority: Normal Reporter: Daniel Parks When querying resources whitespace is required before the comparison operator on parameters. This is not true when using the comparison operator on, say, type. ❯ curl -sSXGET 'http://localhost:8080/pdb/query/v4' \ -d 'query=resources { parameters.content = "a"}' [] ❯ curl -sSXGET 'http://localhost:8080/pdb/query/v4' \ -d 'query=resources { parameters.content ="a"}' [] ❯ curl -sSXGET 'http://localhost:8080/pdb/query/v4' \ -d 'query=resources { parameters.content= "a"}' PQL parse error at line 1, column 33:   resources { parameters.content= "a"} ^   Expected one of:   is not null is null in = > < <= >= ~> ~ Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Ryan Senior (JIRA)]

Ryan Senior updated an issue

PuppetDB / PDB-3284 PQL operators sometimes whitespace sensitive

Change By: Ryan Senior Sprint: Hopper

Add Comment

[Ryan Senior (JIRA)]

[Ryan Senior (JIRA)]

Ryan Senior updated an issue

PuppetDB / PDB-3284 PQL operators sometimes whitespace sensitive

Change By: Ryan Senior Story Points: 1

Add Comment

[Ryan Senior (JIRA)]

Ryan Senior updated an issue

PuppetDB / PDB-3284 PQL operators sometimes whitespace sensitive

Change By: Ryan Senior Team: Foundational Features

Add Comment

[Wyatt Alt (JIRA)]

Wyatt Alt commented on PDB-3284

Re: PQL operators sometimes whitespace sensitive This issue is specific to dotted notation style queries. The issue is that a parameter can have any name, including one that ends with an equals sign. The only thing I can think to do here is create a list of reserved symbols that require quoting or escaping when used in a field. We'll have to give some thought to the best approach for that.

Add Comment

[David Kramer (JIRA)]

David Kramer updated an issue

PuppetDB / PDB-3284

PQL operators sometimes whitespace sensitive

Change By: David Kramer Sprint: FF 2017-05-17

Add Comment

[David Kramer (JIRA)]

David Kramer updated an issue

PuppetDB / PDB-3284 PQL operators sometimes whitespace sensitive

Change By: David Kramer Story Points: 1 2

Add Comment

[David Kramer (JIRA)]

David Kramer updated an issue

PuppetDB / PDB-3284 PQL operators sometimes whitespace sensitive

Change By: David Kramer Sprint: FF 2017-05-17

Add Comment

[David Kramer (JIRA)]

David Kramer updated an issue

PuppetDB / PDB-3284 PQL operators sometimes whitespace sensitive

Change By: David Kramer Team: Foundational Features

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt assigned an issue to Austin Blatt

PuppetDB / PDB-3284 PQL operators sometimes whitespace sensitive

Change By: Austin Blatt Assignee: Austin Blatt

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Daniel Parks (JIRA)]

Daniel Parks commented on PDB-3284

Re: PQL operators sometimes whitespace sensitive I don't think that = suffixes will be an issue… with a LR(1) parser you should be able to distinguish since facts.endswithequals= "foo" is invalid, facts.endswithequals= = "foo" works. If you have another fact named “endswithequals” it's exactly the opposite. So, you should be able to distinguish them. You're going to have problems with facts with spaces in the name anyway (I think those are allowed). Even if you couldn't distinguish them, it would be a lot clearer to allow syntax like facts["endswithequals="] or facts.endswithequals\=.

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt updated an issue

PuppetDB / PDB-3284

PQL operators sometimes whitespace sensitive

Change By: Austin Blatt Fix Version/s: PDB 7.0.0

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt commented on PDB-3284

Re: PQL operators sometimes whitespace sensitive Since this will be a breaking change, I have added a fix version of 7.0.0 and will put this in the backlog for now.

Add Comment

[Robert Roland (JIRA)]

Robert Roland updated an issue

PuppetDB / PDB-3284

PQL operators sometimes whitespace sensitive

Change By: Robert Roland Labels: maintenance query-engine-improvements

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt updated an issue

PuppetDB / PDB-3284 PQL operators sometimes whitespace sensitive

Change By: Austin Blatt Fix Version/s: PDB 7.0.0 Fix Version/s: PDB 6.7.0 Fix Version/s: PDB 6.3.5 Fix Version/s: PDB 5.2.10

Add Comment

[Nirupama Mantha (JIRA)]

Nirupama Mantha commented on PDB-3284

Re: PQL operators sometimes whitespace sensitive Austin Blatt Can you update the release notes field for this ticket?

Add Comment

[Austin Blatt (JIRA)]

Austin Blatt updated an issue

PuppetDB / PDB-3284

PQL operators sometimes whitespace sensitive

Change By: Austin Blatt Release Notes Summary: PQL previously required a space to terminate a dotted field like `facts.os.family`. As a result, the query `inventory[]{ facts.os.family="Debian" }` would fail because the `=` operator was parsed as part of the dotted field. This space is no longer required and the inventory query example is a valid PQL query. Release Notes: Bug Fix

Add Comment

[Heston Hoffman (JIRA)]

Heston Hoffman updated an issue

PuppetDB / PDB-3284 PQL operators sometimes whitespace sensitive

Change By: Heston Hoffman Labels: maintenance query-engine-improvements resolved-issue-added

Add Comment