Jira (PUP-7141) Refactor required string dup in 3x runtime converter

[Henrik Lindberg (JIRA)]

Henrik Lindberg created an issue

Puppet / PUP-7141 Refactor required string dup in 3x runtime converter Issue Type: Improvement Assignee: Unassigned Created: 2017/01/27 8:36 AM Priority: Normal Reporter: Henrik Lindberg The 3x runtime converter must dup all frozen strings as there is user code that mutates (!!!) string parameters. That wastes performance. It is not known how much problems it would cause if frozen values were handed to the 3.x resource parameters. Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-7141 Refactor required string dup in 3x runtime converter

Change By: Henrik Lindberg Component/s: Language Component/s: Compiler

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-7141 Refactor required string dup in 3x runtime converter

Change By: Henrik Lindberg Fix Version/s: PUP 5.y

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-7141

Re: Refactor required string dup in 3x runtime converter The case to look at is for parameter values being used when performing an apply. This problem does not occur when the compilation is remote (due to serialization of catalog in between compile and apply).

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-7141

Refactor required string dup in 3x runtime converter

Change By: Branan Riley Team: Puppet Developer Experience Agent

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-7141 Refactor required string dup in 3x runtime converter

Change By: Branan Riley Labels: triaged

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-7141

Re: Refactor required string dup in 3x runtime converter Josh Cooper Can we stop doing this in Puppet 6.0.0? It means that functions and type & providers that mutate frozen string arguments will hit a hard error when using puppet apply. It will also make 3.x functions that do this error when compiling (If attempting to mutate arguments in a 4.x function it will already error if argument is frozen).

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-7141

Refactor required string dup in 3x runtime converter

Change By: Henrik Lindberg Fix Version/s: PUP 5.y

Fix Version/s: PUP 6.0.0

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-7141

Re: Refactor required string dup in 3x runtime converter I have put up a PR with the changes needed in puppet core.

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg assigned an issue to Josh Cooper

Puppet / PUP-7141

Refactor required string dup in 3x runtime converter

Change By: Henrik Lindberg Assignee: Josh Cooper

Add Comment

[Maggie Dreyer (JIRA)]

Maggie Dreyer updated an issue

Puppet / PUP-7141 Refactor required string dup in 3x runtime converter

Change By: Maggie Dreyer Labels: Language

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-7141

Re: Refactor required string dup in 3x runtime converter As per the discussion in the PR a decision was made to stop duplicating frozen strings both on master side and agent. This affects some modules - and ticket PUP-9098 was logged for the modules in puppet that has affected logic. I also reached out to one forge module that has the same problem: https://github.com/thecodeteam/puppet-vnx/issues/10. This now again ready to be merged for Puppet 6.0.0.

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-7141

Refactor required string dup in 3x runtime converter

Change By: Henrik Lindberg Release Notes Summary: Types and Provider implementations must not mutate the parameter values of a resource. In Puppet 6.0.0 it is more likely that the parameters of a resource will have frozen (i.e. immutable) string values and any type or provider that directly mutates a resource parameter may fail. Before Puppet 6.0.0 every resource attribute was copied to not make application break even if they did mutate. Look for use of {{gsub!}} in your modules and replace logic with non mutating version, or operate on a copy of the value. (All modules authors of modules on the forge having this problem have been notified). Release Notes: Deprecation

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg assigned an issue to Unassigned

Puppet / PUP-7141 Refactor required string dup in 3x runtime converter

Change By: Henrik Lindberg Assignee: Josh Cooper

Add Comment

[Jacob Helwig (JIRA)]

Jacob Helwig commented on PUP-7141

Re: Refactor required string dup in 3x runtime converter This was partially reverted in 779cfb55d0 on master.

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-7141

Re: Refactor required string dup in 3x runtime converter

New PR is up with a removal of the dup when in master mode (i.e. what I originally had). That works because only core resource types are used on the master side (applying the settings catalog) and those in Puppet core that did mutate have been fixed already. If we find code in our code base that mutates and runs into problems with that because of this then that code should be fixed - it is really bad to mutate.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7141

Re: Refactor required string dup in 3x runtime converter

A follow-up PR was merged in bd870bf21bac6979b8adc550c85d446f1e8c8aff

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)