|
I think the revert is fine for now, but I agree with Thomas Hallgren that it isn't good to swallow errors and continue along.
I think the failure to start puppetserver is mostly an issue in CI because we frequently create a temp codedir and point the server at that. In practice though, puppetserver uses a codedir that was created by packaging and has the correct permissions. The part that users get wrong is creating a per-environment directory, but leaving it owned by root, and not readable by the puppet user, or forgetting to create the directory. I think failing to start, with an improved error message, is the correct behavior.
Side node, I think many acceptance tests were copy/pasted to create a tempdir with the wrong permissions, and later after puppetserver was running, set the permissions correctly. For example, we fixed this for one test in 057def0c3. So part of the investigation should be to fix the acceptance tests to create the tempdir with the correct permissions (puppet:puppet:755) before calling with_puppet_running_on. I also found that the above acceptance tests started puppetserver, but only ran puppet apply commands, so puppetserver was unnecessary. So keep an eye out for tests that can be streamlined.
|