Jira (PUP-7040) Non-existent services throw an error when attempting to disable them

[Justin Wiley (JIRA)]

Justin Wiley updated an issue

Puppet / PUP-7040 Non-existent services throw an error when attempting to disable them Change By: Justin Wiley Summary: Non-existent services  shouldn't  throw an error when attempting to disable them . Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Justin Wiley (JIRA)]

Justin Wiley updated an issue

Puppet / PUP-7040 Non-existent services throw an error when attempting to disable them Change By: Justin Wiley

When attempting to disable a service that doesn't exist on a machine, Puppet throws an error: {noformat} Error: /Stage[main]/module::Disable_cups/Service[cups]: Could not evaluate: Could not find init script or upstart conf file for 'cups' {noformat} {code:ruby} service {'cups':   enable => false, } {code} It seems to me that there should be a way to suppress this error, as there are cases in which disabled is the goal, but completely missing is also fine.  This to me would be more in-line with the  package  {{Package}} module  behavior, where you can say {{ensure => absent}} and it won't throw an error if the package already didn't exist.

Add Comment

[Justin Wiley (JIRA)]

Justin Wiley updated an issue

Puppet / PUP-7040 Non-existent services throw an error when attempting to disable them Change By: Justin Wiley

When attempting to disable a service that doesn't exist on a machine, Puppet throws an error: {noformat} Error: /Stage[main]/module::Disable_cups/Service[cups]: Could not evaluate: Could not find init script or upstart conf file for 'cups' {noformat} {code:ruby} service {'cups':   enable => false, } {code}

It seems to me that there should be a way to suppress this error, as there are cases in which disabled is the goal, but completely missing is also fine.   This to me would be more in-line with the package behavior, where you can say {{ensure => absent}} and it won't throw an error if the package already didn't exist.

Add Comment

[Russell Mull (JIRA)]

Russell Mull updated an issue

Puppet / PUP-7040 Non-existent services throw an error when attempting to disable them

Change By: Russell Mull Labels: triaged

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

Puppet / PUP-7040 Non-existent services throw an error when attempting to disable them

Change By: Moses Mendoza Labels: help_wanted

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

Puppet / PUP-7040 Non-existent services throw an error when attempting to disable them

Change By: Moses Mendoza Team: Agent

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-7040 Non-existent services throw an error when attempting to disable them

Change By: Branan Riley Labels: beginner help_wanted

Add Comment

[Ben Ford (JIRA)]

Ben Ford commented on PUP-7040

Re: Non-existent services throw an error when attempting to disable them What if the error was changed to a warning instead? I can see lots of opportunity for mistakes if it just silently ate the error. For example, service {'cupsd': enable => false, } is a perfectly reasonable bit of code to use accidentally and if Puppet didn't warn you, you might never know.

Add Comment

[Justin Wiley (JIRA)]

Justin Wiley commented on PUP-7040

Re: Non-existent services throw an error when attempting to disable them

That's a good point, and a warning would be alright in my book since it wouldn't return an exit code that would bomb out a pipeline.

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Puppet / PUP-7040

Non-existent services throw an error when attempting to disable them

Change By: Branan Riley Labels: beginner help_wanted service triaged type_and_provider

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7040

Re: Non-existent services throw an error when attempting to disable them I can't reproduce this problem. PUP-6822 also shows it's working as expected for linux, but wasn't for windows, so I'm assuming this was fixed in between: # /usr/bin/systemctl is-enabled -- cups Failed to get unit file state for cups.service: No such file or directory # cat manifest.pp

service {'cups': enable => false, }

# puppet apply manifest.pp Notice: Compiled catalog for XXX in environment production in 0.17 seconds Notice: Applied catalog in 0.03 seconds

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)