Jira (PUP-6965) Improve parser error messages

[Tim Purkerson (JIRA)]

Tim Purkerson created an issue

Puppet / PUP-6965 Improve parser error messages Issue Type: Improvement Assignee: Unassigned Created: 2016/12/01 2:23 PM Priority: Normal Reporter: Tim Purkerson Add more detail to the error messages that will allow much quicker debugging. Such as line numbers where the error occurs or suggested diagnostic flags. For example, received the error message: Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not parse for environment pr001: Found 4 errors. Giving up in /app/puppet/environments/apps/test/pr001/manifests/params.pp on node pr.server.com Those four errors took several hours to track down in the very large params.pp file. Having line numbers would have made the debugging task much easier. Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-6965

Re: Improve parser error messages Those 4 errors were logged for sure. The line numbers are there. The number of errors to log before giving up is set to 10. It can be set to one to only report the first - in which case there is no aggregate error message like the one in the Description above. When there is an aggregation of errors - we could naturally include all the files/lines and messages in the message for the aggregate. Would that be a better solution than saying "giving up" ? And in this case. Didn't "puppet parser validate params.pp" reveal the individual errors?

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg assigned an issue to Tim Purkerson

Puppet / PUP-6965 Improve parser error messages

Change By: Henrik Lindberg Assignee: Tim Purkerson

Add Comment

[Maggie Dreyer (JIRA)]

Maggie Dreyer updated an issue

Puppet / PUP-6965 Improve parser error messages

Change By: Maggie Dreyer Labels: triaged

Add Comment

[Maggie Dreyer (JIRA)]

Maggie Dreyer updated an issue

Puppet / PUP-6965 Improve parser error messages

Change By: Maggie Dreyer Team: Agent

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-6965 Improve parser error messages

Change By: Henrik Lindberg Component/s: Language

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-6965 Improve parser error messages

Change By: Henrik Lindberg Fix Version/s: PUP 5.y

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-6965

Re: Improve parser error messages

I think a simple "see server log for details" in the "giving up" message is an easy and helpful thing to add. Alternatively, pick the first error - and add "first error is: " + its location to "giving up". Then at least errors can be located and fixed one by one.

Add Comment

[David McTavish (Jira)]

David McTavish updated an issue

Puppet / PUP-6965 Improve parser error messages

Change By: David McTavish Labels: low-hanging-fruit nice-to-have

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[David McTavish (Jira)]

David McTavish updated an issue

Puppet / PUP-6965 Improve parser error messages

Change By: David McTavish Priority: Normal Low

Add Comment