Jira (FACT-1496) Facter fails to detect more recent openSUSE versions

[Robert Munteanu (JIRA)]

Robert Munteanu created an issue

Facter / FACT-1496 Facter fails to detect more recent openSUSE versions Issue Type: Bug Affects Versions: FACT 2.4.5 Assignee: Unassigned Components: CLI Created: 2016/08/27 1:17 PM Priority: Normal Reporter: Robert Munteanu More recent openSUSE versions ( not sure about SLE ) have removed the /etc/SuSE-release file. In fact, as of openSUSE 13.2 that file contained a warning /etc/SuSE-release is deprecated and will be removed in the future, use /etc/os-release instead Right now on openSUSE Tumbleweed ( and I would assume on the upcoming openSUSE Leap 42.1 and SLE 12 ) getting the operatingsystem fact returns an empty string. The solution that I've found is to patch /lib/facter/operatingsystem/linux.rb to check if lsbdistid == "openSUSE" and the set the operatingsystem fact accordingly. Add Comment

This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)

[Robert Munteanu (JIRA)]

Robert Munteanu updated an issue

Facter / FACT-1496 Facter fails to detect more recent openSUSE versions

Change By: Robert Munteanu Affects Version/s: FACT 2.4.5 Affects Version/s: FACT 2.4.6

Add Comment

[Robert Munteanu (JIRA)]

Robert Munteanu updated an issue

Facter / FACT-1496 Facter fails to detect more recent openSUSE versions Change By: Robert Munteanu

More recent openSUSE versions ( not sure about SLE ) have removed the /etc/SuSE-release file. In fact, as of openSUSE 13.2 that file contained a warning

{noformat}# /etc/SuSE-release is deprecated and will be removed in the future, use /etc/os-release instead{noformat} Right now on openSUSE Tumbleweed ( and I would assume on the upcoming openSUSE Leap 42. 1 2  and SLE 12 ) getting the operatingsystem fact returns an empty string.

The solution that I've found is to patch /lib/facter/operatingsystem/linux.rb to check if {{lsbdistid == "openSUSE"}} and the set the operatingsystem fact accordingly.

Add Comment

[Robert Munteanu (JIRA)]

Robert Munteanu updated an issue

Facter / FACT-1496 Facter fails to detect more recent openSUSE versions Change By: Robert Munteanu

More recent openSUSE versions ( not sure about SLE ) have removed the /etc/SuSE-release file. In fact, as of openSUSE 13.2 that file contained a warning

{ quote noformat }# /etc/SuSE-release is deprecated and will be removed in the future, use /etc/os-release instead{ quote noformat } Right now on openSUSE Tumbleweed ( and I would assume on the upcoming openSUSE Leap 42.1 and SLE 12 ) getting the operatingsystem fact returns an empty string.

The solution that I've found is to patch /lib/facter/operatingsystem/linux.rb to check if {{lsbdistid == "openSUSE"}} and the set the operatingsystem fact accordingly.

Add Comment

[Michael Smith (JIRA)]

Michael Smith commented on FACT-1496

Re: Facter fails to detect more recent openSUSE versions That's interesting. PRs welcome; the code related to this is at https://github.com/puppetlabs/facter/blob/master/lib/src/facts/linux/os_linux.cc#L114-L131.

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Michael Smith (JIRA)]

Michael Smith updated an issue

Facter / FACT-1496

Facter fails to detect more recent openSUSE versions

Change By: Michael Smith Labels: maintenance

Add Comment

[Michael Smith (JIRA)]

Michael Smith updated an issue

Facter / FACT-1496 Facter fails to detect more recent openSUSE versions

Change By: Michael Smith Labels: maintenance  puppethack

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1496 Facter fails to detect more recent openSUSE versions

Change By: Branan Riley Labels: help_wanted maintenance puppethack

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1496 Facter fails to detect more recent openSUSE versions

Change By: Branan Riley Labels: help_wanted linux maintenance puppethack suse

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Branan Riley (JIRA)]

Branan Riley commented on FACT-1496

Re: Facter fails to detect more recent openSUSE versions I think I've seen one or two other OS detection issues that would be resolved by us using the os-release file. That's probably worth extracting into a single ticket that we can block these bugs against (including this one)

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1496

Facter fails to detect more recent openSUSE versions

Change By: Branan Riley Team: Platform OS

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1496 Facter fails to detect more recent openSUSE versions

Change By: Branan Riley Labels: help_wanted linux maintenance puppethack suse triaged

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-1496

Re: Facter fails to detect more recent openSUSE versions We don't have plans on adding support for this, but if anyone would like to submit a PR to Facter 4, you'd want to update this file https://github.com/puppetlabs/facter/blob/88a4f07aca392d438792c329994c462de0c7746b/lib/facter/resolvers/suse_release.rb#L20 and the related tests. For now I'm going to close the ticket, but feel free to reopen if you'd like to submit a PR

Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)