Jira (PUP-6575) Disambiguate puppet agent -t and puppet apply -t with quick feedback

[Paul Anderson (JIRA)]

Paul Anderson updated an issue

Puppet / PUP-6575 Disambiguate puppet agent -t and puppet apply -t with quick feedback Change By: Paul Anderson Summary: Disambiguate puppet agent -t and puppet apply -t  with quick feedback Add Comment

This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)

[Paul Anderson (JIRA)]

Paul Anderson updated an issue

Puppet / PUP-6575 Disambiguate puppet agent -t and puppet apply -t with quick feedback Change By: Paul Anderson

Both new and experienced users alike will accidentally type "puppet apply -t" when they mean to do a puppet run (puppet agent -t) puppet apply -t is a valid use case, and should not be  removed, but if  changed as it could affect those using masterless puppet. If  the client were to detect that puppet apply -t was run, no  file argument was given, no  input has been fed on standard in and that it was waiting for input, it could print an informational message, such as: "INFO: puppet apply ready for input on stdin" Then it would prevent confusion as people wait 2.. 5... 10... seconds  (or going for coffee) before  thinking that puppet has hung  before realizing the issue ,  hitting CTRL-C to break , running "puppet agent -t" like they meant to and kicking themselves for making this mistake AGAIN . ..

Add Comment

[Paul Anderson (JIRA)]

Paul Anderson commented on PUP-6575

Re: Disambiguate puppet agent -t and puppet apply -t with quick feedback This use case is valid and shouldn't be broken by this new feature. root@solaris11:/shared# /usr/local/bin/puppet apply -t < hello.pp Info: Loading facts Info: Loading facts Info: Loading facts Notice: Compiled catalog for solaris11.puppetlabs.vm in environment production in 0.05 seconds Info: Applying configuration version '1470249024' Notice: hello Notice: /Stage[main]/Main/Notify[hello]/message: defined 'message' as 'hello' Notice: Applied catalog in 0.04 seconds

Add Comment

[Paul Anderson (JIRA)]

Paul Anderson updated an issue

Puppet / PUP-6575

Disambiguate puppet agent -t and puppet apply -t with quick feedback

Change By: Paul Anderson

Both new and experienced users alike will accidentally type "puppet apply -t" when they mean to do a puppet run (puppet agent -t)

puppet apply -t is a valid use case, and should not be changed as it could affect those using masterless puppet. If the client were to detect that puppet apply -t was run, no file argument was given, no input has been fed on standard in and that it was waiting for input, it could print an informational message, such as: " INFO Info :  puppet  Puppet  apply ready for input on stdin" Then it would prevent confusion as people wait 2.. 5... 10... seconds (or going for coffee) before thinking that puppet has hung, hitting CTRL-C to break, running "puppet agent -t" like they meant to and kicking themselves for making this mistake AGAIN...

Add Comment

[Paul Anderson (JIRA)]

Paul Anderson commented on PUP-6575

Re: Disambiguate puppet agent -t and puppet apply -t with quick feedback This is another valid use case that shouldn't be broken by this new feature:

root@solaris11:/shared# /usr/local/bin/puppet apply -t

notify { "hello": } <CTRL-D>

Info: Loading facts Info: Loading facts Info: Loading facts

Notice: Compiled catalog for solaris11.puppetlabs.vm in environment production in 0.04 seconds Info: Applying configuration version '1470249167'

Notice: hello Notice: /Stage[main]/Main/Notify[hello]/message: defined 'message' as 'hello'

Notice: Applied catalog in 0.05 seconds

Add Comment

[Paul Anderson (JIRA)]

Paul Anderson commented on PUP-6575

Re: Disambiguate puppet agent -t and puppet apply -t with quick feedback

And of course, the classic fundamentals use of puppet apply -t should work, too: root@solaris11:/shared# /usr/local/bin/puppet apply -t hello.pp

Info: Loading facts Info: Loading facts Info: Loading facts Notice: Compiled catalog for solaris11.puppetlabs.vm in environment production in 0.04 seconds

Info: Applying configuration version '1470249265'

Notice: hello Notice: /Stage[main]/Main/Notify[hello]/message: defined 'message' as 'hello' Notice: Applied catalog in 0.05 seconds

Add Comment

[Jeremy Adams (JIRA)]

Jeremy Adams commented on PUP-6575

Re: Disambiguate puppet agent -t and puppet apply -t with quick feedback

+1

Add Comment

[Kylo Ginsberg (JIRA)]

Kylo Ginsberg assigned an issue to Unassigned

Puppet / PUP-6575

Disambiguate puppet agent -t and puppet apply -t with quick feedback

Change By: Kylo Ginsberg Assignee: Kylo Ginsberg

Add Comment

[Kylo Ginsberg (JIRA)]

Kylo Ginsberg updated an issue

Puppet / PUP-6575 Disambiguate puppet agent -t and puppet apply -t with quick feedback

Change By: Kylo Ginsberg Scrum Team: Client Platform

Add Comment

[Joe Pinsonault (JIRA)]

Joe Pinsonault updated an issue

Puppet / PUP-6575 Disambiguate puppet agent -t and puppet apply -t with quick feedback

Change By: Joe Pinsonault Team: Agent

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Joe Pinsonault (JIRA)]

Joe Pinsonault updated an issue

Puppet / PUP-6575 Disambiguate puppet agent -t and puppet apply -t with quick feedback

Change By: Joe Pinsonault Labels: triaged

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-6575

Re: Disambiguate puppet agent -t and puppet apply -t with quick feedback I don't know of any other CLI tool that emits a message like that. I think it would be better to allow the user to specify {} to mean read from stdin, and generate a usage error if neither execute/-e, catalog, nor {} were specified. Also the puppet apply help should mention that it can read from stdin (currently there's no mention).

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-6575

Disambiguate puppet agent -t and puppet apply -t with quick feedback

Change By: Josh Cooper Labels: beginner

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-6575 Disambiguate puppet agent -t and puppet apply -t with quick feedback

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Unassigned

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-6575

Re: Disambiguate puppet agent -t and puppet apply -t with quick feedback I think this might be useful, but we don't have any plans on working on it. I'm going to close this due to lack of activity. Please reopen if needed.

Add Comment