Jira (PUP-6554) Can't run puppet resource on agent with environment specified in main section

[Paul Anderson (JIRA)]

Paul Anderson created an issue

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section Issue Type: Bug Assignee: Unassigned Created: 2016/07/27 6:32 AM Priority: Normal Reporter: Paul Anderson Add Comment

This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)

[Paul Anderson (JIRA)]

Paul Anderson commented on PUP-6554

Re: Can't run puppet resource on agent with environment specified in main section See also https://tickets.puppetlabs.com/browse/PUP-6048

Add Comment

[Paul Anderson (JIRA)]

Paul Anderson updated an issue

Puppet / PUP-6554

Can't run puppet resource on agent with environment specified in main section

Change By: Paul Anderson Affects Version/s: PUP 4.5.2 Environment: RHEL 7 Master and Agent Copy default production environment to "development" Have console refresh modules Create development environment group in classifier, pin the agent Configure agent to include "environment = development" in the main section of puppet.conf Do puppet runs to everyones satisfaction CS Impact: When these three things are true, the customer can't use puppet client commands on their nodes as expected: 1. Code manager with separate environments 2. Nodes in an environment other than production 3. Mcollective in use 4. environment=[non-production] specified in [main] section of puppet.conf The have to do mental gymnastics to understand why they must add --environment production to every puppet help, puppet resource, etc. command to make it work. Component/s: Breaking Change See also https://tickets.puppetlabs.com/browse/PUP-6048 Given a traditional Prod, Dev, Test scenario, and a desire to use MCollective Given the desire to configure an environment in the agent's puppet.conf to cut down on log messages Given the need to put the environment setting in [main] and not [agent] so that MCollective also knows the environment If one manually runs puppet commands on a non-production client, such as puppet resource, one gets an error: [root@dev-node ~]# puppet resource service puppet ensure=running enable=true /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/environments.rb:38:in `get!': Could not find a directory environment named 'development' anywhere in the path: /etc/puppetlabs/code/environments. Does the directory exist? (Puppet::Environments::EnvironmentNotFound) from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application_support.rb:29:in `push_application_context' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application.rb:337:in `run' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:128:in `run' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:72:in `execute' from /usr/local/bin/puppet:5:in `<main>' However, if one lies about the environment, it works as expected: [root@dev-node ~]# puppet resource service puppet ensure=running enable=true --environment production Notice: /Service[puppet]/ensure: ensure changed 'stopped' to 'running' service { 'puppet':   ensure => 'running',   enable => 'true', } This inconsistency is frustrating to customers, regardless of the reasoning behind it. It requires retraining of their staff doing manual operations and lots of comments in their cron jobs, etc.

Add Comment

[Paul Anderson (JIRA)]

Paul Anderson updated an issue

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section Change By: Paul Anderson

See also https://tickets.puppetlabs.com/browse/PUP-6048 Given a traditional Prod, Dev, Test scenario, and a desire to use MCollective Given the desire to configure an environment in the agent's puppet.conf to cut down on log messages Given the need to put the environment setting in [main] and not [agent] so that MCollective also knows the environment If one manually runs puppet commands on a non-production client, such as puppet resource, one gets an error: [root@dev-node ~]# puppet resource service puppet ensure=running enable=true /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/environments.rb:38:in `get!': Could not find a directory environment named 'development' anywhere in the path: /etc/puppetlabs/code/environments. Does the directory exist? (Puppet::Environments::EnvironmentNotFound) from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application_support.rb:29:in `push_application_context' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application.rb:337:in `run' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:128:in `run' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:72:in `execute' from /usr/local/bin/puppet:5:in `<main>'

However, if one  lies about  impersonates  the  production  environment, it works as expected:

[root@dev-node ~]# puppet resource service puppet ensure=running enable=true --environment production Notice: /Service[puppet]/ensure: ensure changed 'stopped' to 'running' service { 'puppet':   ensure => 'running',   enable => 'true', } This inconsistency is frustrating to customers, regardless of the reasoning behind it. It requires retraining of their staff doing manual operations and lots of comments in their cron jobs, etc.

Add Comment

[Paul Anderson (JIRA)]

Paul Anderson updated an issue

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section

Change By: Paul Anderson Labels: customer

Add Comment

[Paul Anderson (JIRA)]

Paul Anderson updated an issue

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section Change By: Paul Anderson

See also https://tickets.puppetlabs.com/browse/PUP-6048 Given a traditional Prod, Dev, Test scenario, and a desire to use MCollective Given the desire to configure an environment in the agent's puppet.conf to cut down on log messages Given the need to put the environment setting in [main] and not [agent] so that MCollective also knows the environment

If one manually runs puppet commands on a non-production  client  node , such as puppet resource, one gets an error:

[root@dev-node ~]# puppet resource service puppet ensure=running enable=true /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/environments.rb:38:in `get!': Could not find a directory environment named 'development' anywhere in the path: /etc/puppetlabs/code/environments. Does the directory exist? (Puppet::Environments::EnvironmentNotFound) from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application_support.rb:29:in `push_application_context' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/application.rb:337:in `run' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:128:in `run' from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/util/command_line.rb:72:in `execute' from /usr/local/bin/puppet:5:in `<main>'

However, if one impersonates the production environment, it works as expected:

[root@dev-node ~]# puppet resource service puppet ensure=running enable=true --environment production Notice: /Service[puppet]/ensure: ensure changed 'stopped' to 'running' service { 'puppet':   ensure => 'running',   enable => 'true', } This inconsistency is frustrating to customers, regardless of the reasoning behind it. It requires retraining of their staff doing manual operations and lots of comments in their cron jobs, etc.

Add Comment

[Paul Anderson (JIRA)]

Paul Anderson updated an issue

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section

Change By: Paul Anderson CS Impact: When these  three  four  things are true, the customer can't use puppet client commands on their nodes as expected:

1. Code manager with separate environments 2. Nodes in an environment other than production 3. Mcollective in use 4. environment=[non-production] specified in [main] section of puppet.conf The have to do mental gymnastics to understand why they must add --environment production to every puppet help, puppet resource, etc. command to make it work.

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section

Change By: Henrik Lindberg Scrum Team: Client Platform

Add Comment

[Paul Anderson (JIRA)]

Paul Anderson updated an issue

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section

Change By: Paul Anderson CS Impact: When these four things are true, the  customer  user  can't use puppet client commands on their nodes as expected:

1. Code manager with separate environments 2. Nodes in an environment other than production 3. Mcollective in use 4. environment=[non-production] specified in [main] section of puppet.conf The have to do mental gymnastics to understand why they must add --environment production to every puppet help, puppet resource, etc. command to make it work.

Add Comment

[David Kramer (JIRA)]

David Kramer updated an issue

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section

Change By: David Kramer Sprint: Client Triage

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[David Kramer (JIRA)]

David Kramer commented on PUP-6554

Re: Can't run puppet resource on agent with environment specified in main section This behavior seems unexpected. We should figure out what is going on here and determine whether this needs to be better documented or if there is an issue to be fixed in the code.

Add Comment

[Vadym Chepkov (JIRA)]

Vadym Chepkov commented on PUP-6554

Re: Can't run puppet resource on agent with environment specified in main section

I want to chime in with some additional information. We have to set 'environment' in [main] section, along with 'certname' and 'server', which under normal circumstances would be only relevant for an agent. But, pe-mcollective-metadata script (/opt/puppetlabs/puppet/bin/refresh-mcollective-metadata) doesn't use 'agent' section, it uses 'main', so if you have (like we do) facts based on any of those 3 settings, they will be out-of-sync, different from what agent sees, so we can't use any mco filters based on these facts.

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

Puppet / PUP-6554

Can't run puppet resource on agent with environment specified in main section

Change By: Kenn Hussey Sprint: Client Triage

Add Comment

[Nicholas Fagerlund (JIRA)]

Nicholas Fagerlund updated an issue

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section

Change By: Nicholas Fagerlund Labels: customer  triaged

Add Comment

[Nicholas Fagerlund (JIRA)]

Nicholas Fagerlund commented on PUP-6554

Re: Can't run puppet resource on agent with environment specified in main section In my judgment, this is a legit misbehavior, and we should fix it at some point. IDK if the way the code is laid out makes this complex, but conceptually, the fix is simple: If non-default environment is set BUT is nonexistent: Puppet resource should switch to production environment (silent except for debug messages) and continue. Use case: normal puppet agent nodes that don't have r10k deploys, where puppet resource should only load custom types from the agent libdir. If a non-default environment is set AND that environment exists, Puppet resource should go ahead and use that environment. (This is what it always does now.) Use case: standalone puppet apply nodes that have a full r10k deploy present, where puppet resource should load custom types from modules. I think that combination of behaviors covers all use cases, wouldn't surprise any users, and would never do any meaningfully wrong things.

Add Comment

[Nicholas Fagerlund (JIRA)]

Nicholas Fagerlund updated an issue

Puppet / PUP-6554

Can't run puppet resource on agent with environment specified in main section

Change By: Nicholas Fagerlund Team: Agent

Add Comment

[Nicholas Fagerlund (JIRA)]

Nicholas Fagerlund updated an issue

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section

Change By: Nicholas Fagerlund Component/s: Breaking Change

Add Comment

[Paul Anderson (JIRA)]

Paul Anderson commented on PUP-6554

Re: Can't run puppet resource on agent with environment specified in main section Nicholas Fagerlund, I've been watching traffic on this issue and related tickets for awhile. I'd like to point out two distinctions that I think the team would do well to be aware of: 1. The current behavior is a stack trace. That's bad and should get some sort of immediate triage. The tool should at least exit gracefully with an error message 2. Once that initial fatal error is resolved, then yes, the tool should work as it had previously done. Having an environment set (so as to not get the warning in your logs) and then running a local puppet command (where the environment directory doesn't exist) shouldn't be a problem.

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-6554

Re: Can't run puppet resource on agent with environment specified in main section

Setting environment in the main section is a problem, because the setting controls different behavior depending on which application you're running. PUP-6739 will now generate a warning if you don't specify a section when setting the environment to prevent people from getting into this bad state. We also no longer raise a fatal error if the environment doesn't exist when running puppet config or puppet help. However, puppet resource may rely on types from modules in the current environment, so we really do need a valid environment to be specified. We should more gracefully handle when the get! call raises to indicate an environment with that name wasn't found. Most likely the environment setting needs to be moved to the agent section instead of main.

Add Comment

This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-6554

Can't run puppet resource on agent with environment specified in main section

Change By: Josh Cooper Sub-team: Coremunity

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section

Change By: Josh Cooper Epic Link: PUP- 7563 10539

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-6554

Re: Can't run puppet resource on agent with environment specified in main section We should probably warn if puppet config set environment is set in something other than agent, as it will cause problems when trying to run other puppet commands

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-6554

Can't run puppet resource on agent with environment specified in main section

Change By: Ciprian Badescu Story Points: 2

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Gabriel Nagy (Jira)]

Gabriel Nagy assigned an issue to Gabriel Nagy

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section

Change By: Gabriel Nagy Assignee: Gabriel Nagy

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-6554

Re: Can't run puppet resource on agent with environment specified in main section Merged to 6.x in https://github.com/puppetlabs/puppet/commit/b3c3ef0a00f81c0b4505220fdb9db6cd44d2b86f

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-6554

Can't run puppet resource on agent with environment specified in main section

Change By: Josh Cooper Fix Version/s: PUP 7.9.0 Fix Version/s: PUP 6.24.0

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-6554 Can't run puppet resource on agent with environment specified in main section

Change By: Ciprian Badescu Sprint: NW-2021-06-30 , NW-2021-07-14

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-6554

Re: Can't run puppet resource on agent with environment specified in main section Passed CI in 99a52d4737

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-6554

Can't run puppet resource on agent with environment specified in main section

Change By: Claire Cadman Labels: customer doc-reviewed

Add Comment