Jira (PUP-6540) Allow Windows group resource to specify SID as title

3 views
Skip to first unread message

Ethan Brown (JIRA)

unread,
Jul 22, 2016, 5:42:04 PM7/22/16
to puppe...@googlegroups.com
Ethan Brown created an issue
 
Puppet / Improvement PUP-6540
Allow Windows group resource to specify SID as title
Issue Type: Improvement Improvement
Affects Versions: PUP 4.5.2
Assignee: Kylo Ginsberg
Components: Types and Providers, Windows
Created: 2016/07/22 2:41 PM
Labels: windows i18n utf-8
Priority: Normal Normal
Reporter: Ethan Brown

Without being able to use a SID in the title of a group resource on Windows, it can be difficult to write a manifest that works properly on internationalized versions of Windows. Take for instance, adding a user to the Administrators group.

In English, this works to modify the Administrators group and add user bob (presuming they already exist):

group { 'Administrators':
  members => ['bob'],
  auth_membership => false
}

The same code on French Windows, will actually create a new group named Administrators, which may be surprising. The user likely expected that the well-defined Administrators group with SID S-1-5-32-544 was used, which in this case is localized to Administrateurs. For cases where manifests are running only in one localized environment, this may already be well understood by users.

However, this becomes quite painful if working across an environment with more than 1 localized set of accounts.

The solution to referring to well-known accounts is typically to use the SIDs as defined at https://msdn.microsoft.com/en-us/library/windows/desktop/aa379649(v=vs.85).aspx to circumvent any localization problems.

However, the group type does not support SIDs as titles, but likely could with some additional munging code.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
Atlassian logo

Ethan Brown (JIRA)

unread,
Jul 22, 2016, 5:44:04 PM7/22/16
to puppe...@googlegroups.com
Ethan Brown updated an issue
Change By: Ethan Brown
Without being able to use a SID in the title of a group resource on Windows, it can be difficult to write a manifest that works properly on internationalized versions of Windows.  Take for instance, adding a user to the {{Administrators}} group.

In English, this works to modify the {{Administrators}} group and add user {{bob}} (presuming they already exist):

{code}

group { 'Administrators':
  members => ['bob'],
  auth_membership => false
}
{code}

The same code on French Windows, will actually create a new group named {{Administrators}}, which may be surprising.  The user likely expected that the well-defined Administrators group with SID {{S-1-5-32-544}} was used, which in this case is localized to {{Administrateurs}}.  For cases where manifests are running only in one localized environment, this may already be well understood by users.

However, this becomes quite painful if working across an environment with more than 1 localized set of accounts
, as manifests must be special cased for each additional environment .



The solution to referring to well-known accounts is typically to use the SIDs as defined at https://msdn.microsoft.com/en-us/library/windows/desktop/aa379649(v=vs.85).aspx to circumvent any localization problems.

However, the group type does not support SIDs as titles, but likely could with some additional munging code.

Craig Gomes (JIRA)

unread,
Jul 25, 2016, 5:25:05 PM7/25/16
to puppe...@googlegroups.com
Craig Gomes updated an issue
Change By: Craig Gomes
Fix Version/s: PUP 4.6.x

Ethan Brown (JIRA)

unread,
Aug 22, 2016, 4:35:05 PM8/22/16
to puppe...@googlegroups.com
Ethan Brown updated an issue
Change By: Ethan Brown
Fix Version/s: PUP 4.6.z
Fix Version/s: PUP 4.8.0

Ethan Brown (JIRA)

unread,
Sep 21, 2016, 6:41:05 PM9/21/16
to puppe...@googlegroups.com
Ethan Brown updated an issue
Change By: Ethan Brown
Team: Agent & Platform
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Ethan Brown (JIRA)

unread,
Sep 21, 2016, 6:41:34 PM9/21/16
to puppe...@googlegroups.com
Ethan Brown updated an issue
Change By: Ethan Brown
Fix Version/s: PUP 4.8.0

Ethan Brown (JIRA)

unread,
Sep 21, 2016, 6:42:02 PM9/21/16
to puppe...@googlegroups.com
Ethan Brown updated an issue
Change By: Ethan Brown
Sprint: Windows Triage

Joe Pinsonault (JIRA)

unread,
May 16, 2017, 4:28:02 PM5/16/17
to puppe...@googlegroups.com
Joe Pinsonault updated an issue
Change By: Joe Pinsonault
Labels: i18n  triaged  utf-8 windows

Josh Cooper (Jira)

unread,
Jun 6, 2020, 7:59:03 PM6/6/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Coremunity Night's Watch
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Jun 17, 2021, 11:57:02 AM6/17/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP-6719
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages