Jira (PUP-6287) Cross-Resource Auto-Dependency Unit Tests

1 view
Skip to first unread message

Matt Schuchard (JIRA)

unread,
May 10, 2016, 2:34:03 PM5/10/16
to puppe...@googlegroups.com
Matt Schuchard created an issue
 
Puppet / Improvement PUP-6287
Cross-Resource Auto-Dependency Unit Tests
Issue Type: Improvement Improvement
Assignee: Kylo Ginsberg
Components: Test Infrastructure, Types and Providers
Created: 2016/05/10 11:33 AM
Environment:

All

Priority: Normal Normal
Reporter: Matt Schuchard

As requested by Kylo Ginsberg, opening a ticket for these gaps in testing.

Currently, there are no unit tests that I could find for cross-resource auto-dependencies.
For example, we see in lines 380-402 of user title that groups managed by Puppet that a user is added to are autorequired. If you consult user spec, there are no tests for this type of auto-dependency.

One of my objectives in PUP-6099 was to figure out how to do this kind of testing and it appears I succeeded. There is a test for mount resources autorequiring and autbeforing file resources.

I think it would be worthwhile for these test gaps to be filled since it appears I have figured out how to create them and what I have done can hopefully be used as a code template.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
Atlassian logo

Matt Schuchard (JIRA)

unread,
May 10, 2016, 2:34:04 PM5/10/16
to puppe...@googlegroups.com
Matt Schuchard updated an issue
Change By: Matt Schuchard
As requested by [~kylo], opening a ticket for these gaps in testing.


Currently, there are no unit tests that I could find for cross-resource auto-dependencies.
For example, we see in lines 380-402 of [user  title |https://github.com/puppetlabs/puppet/blob/master/lib/puppet/type/user.rb] that groups managed by Puppet that a user is added to are autorequired. If you consult [user spec|https://github.com/puppetlabs/puppet/blob/master/spec/unit/type/user_spec.rb], there are no tests for this type of auto-dependency.


One of my objectives in PUP-6099 was to figure out how to do this kind of testing and it appears I succeeded. There is a test for mount resources autorequiring and autbeforing file resources.

I think it would be worthwhile for these test gaps to be filled since it appears I have figured out how to create them and what I have done can hopefully be used as a code template.

Matt Schuchard (JIRA)

unread,
May 10, 2016, 2:35:03 PM5/10/16
to puppe...@googlegroups.com
Matt Schuchard updated an issue
As requested by [~kylo], opening a ticket for these gaps in testing.

Currently, there are no unit tests that I could find for cross-resource auto-dependencies.
For example, we see in lines 380-402 of [user|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/type/user.rb] that groups managed by Puppet  that  which  a user is added to are autorequired. If you consult [user spec|https://github.com/puppetlabs/puppet/blob/master/spec/unit/type/user_spec.rb], there are no tests for this type of auto-dependency.


One of my objectives in PUP-6099 was to figure out how to do this kind of testing and it appears I succeeded. There is a test for mount resources autorequiring and autbeforing file resources.

I think it would be worthwhile for these test gaps to be filled since it appears I have figured out how to create them and what I have done can hopefully be used as a code template.

Matt Schuchard (JIRA)

unread,
May 10, 2016, 2:35:03 PM5/10/16
to puppe...@googlegroups.com
Matt Schuchard updated an issue
As requested by [~kylo], opening a ticket for these gaps in testing.

Currently, there are no unit tests that I could find for cross-resource auto-dependencies.
For example, we see in lines 380-402 of [user|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/type/user.rb] that groups managed by Puppet which a user is added to are autorequired. If you consult [user spec|https://github.com/puppetlabs/puppet/blob/master/spec/unit/type/user_spec.rb], there are no tests for this type of auto-dependency.

One of my objectives in PUP-6099 was to figure out how to do this kind of testing and it appears I succeeded. There is a test for mount resources autorequiring and
 autbeforing  autobeforing  file resources.


I think it would be worthwhile for these test gaps to be filled since it appears I have figured out how to create them and what I have done can hopefully be used as a code template.

Kylo Ginsberg (JIRA)

unread,
May 10, 2016, 3:44:03 PM5/10/16
to puppe...@googlegroups.com
Kylo Ginsberg updated an issue
Change By: Kylo Ginsberg
Scrum Team: Client Platform

Kylo Ginsberg (JIRA)

unread,
May 10, 2016, 3:45:03 PM5/10/16
to puppe...@googlegroups.com
Kylo Ginsberg updated an issue
Change By: Kylo Ginsberg
Sprint: Client Triage

Kylo Ginsberg (JIRA)

unread,
May 10, 2016, 3:46:03 PM5/10/16
to puppe...@googlegroups.com
Kylo Ginsberg commented on Improvement PUP-6287
 
Re: Cross-Resource Auto-Dependency Unit Tests

This might be a good pairing opportunity for someone ramping up on rspec and puppet. /cc Branan Riley

Kenn Hussey (JIRA)

unread,
Sep 29, 2016, 2:59:05 PM9/29/16
to puppe...@googlegroups.com
Kenn Hussey updated an issue
Change By: Kenn Hussey
Sprint: Client Triage
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Sean McDonald (JIRA)

unread,
May 16, 2017, 7:06:03 PM5/16/17
to puppe...@googlegroups.com
Sean McDonald assigned an issue to Eric Sorenson
Change By: Sean McDonald
Assignee: Kylo Ginsberg Eric Sorenson

Moses Mendoza (JIRA)

unread,
May 16, 2017, 7:07:03 PM5/16/17
to puppe...@googlegroups.com
Moses Mendoza updated an issue
Change By: Moses Mendoza
Labels: triaged help_wanted tech-debt

Sean McDonald (JIRA)

unread,
May 16, 2017, 7:07:03 PM5/16/17
to puppe...@googlegroups.com

Moses Mendoza (JIRA)

unread,
May 16, 2017, 7:07:03 PM5/16/17
to puppe...@googlegroups.com
Moses Mendoza updated an issue
Change By: Moses Mendoza
Labels: tech-debt

Sean McDonald (JIRA)

unread,
May 16, 2017, 7:07:03 PM5/16/17
to puppe...@googlegroups.com
Sean McDonald updated an issue
Change By: Sean McDonald
Labels: tech-debt triaged

Moses Mendoza (JIRA)

unread,
May 16, 2017, 7:07:03 PM5/16/17
to puppe...@googlegroups.com
Moses Mendoza assigned an issue to Unassigned
Change By: Moses Mendoza
Assignee: Eric Sorenson

Moses Mendoza (JIRA)

unread,
May 16, 2017, 7:07:06 PM5/16/17
to puppe...@googlegroups.com
Moses Mendoza updated an issue
Change By: Moses Mendoza
Labels: help_wanted tech-debt  triaged

Karen Van der Veer (JIRA)

unread,
Aug 1, 2017, 7:25:04 PM8/1/17
to puppe...@googlegroups.com
Karen Van der Veer updated an issue
Change By: Karen Van der Veer
Sprint: Platform Core Grooming

Moses Mendoza (JIRA)

unread,
Sep 21, 2017, 7:32:15 PM9/21/17
to puppe...@googlegroups.com
Moses Mendoza updated an issue
Change By: Moses Mendoza
Sprint: Platform Core Grooming

Josh Cooper (Jira)

unread,
Jun 2, 2021, 8:25:02 PM6/2/21
to puppe...@googlegroups.com
Josh Cooper commented on Improvement PUP-6287

This ticket has not been updated in some time and is now being closed due to inactivity. This isn’t necessarily a statement that this ticket isn’t important - other issues may have demanded precedence since it was filed, or it may have simply slipped through the cracks. If any viewer/watcher feels closing this ticket is an error, please re-open it and add a comment explaining. Our apologies in advance for any mistake on this.

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages