Jira (PUP-6190) Puppet module build errors if a file or directory contains non US English characters

1 view
Skip to first unread message

Glenn Sarti (JIRA)

unread,
Apr 20, 2016, 4:40:03 PM4/20/16
to puppe...@googlegroups.com
Glenn Sarti created an issue
 
Puppet / Bug PUP-6190
Puppet module build errors if a file or directory contains non US English characters
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2016/04/20 1:39 PM
Environment:

Windows Server 2012 R2 x64
Puppet 4.4.0

Labels: i18n
Priority: Normal Normal
Reporter: Glenn Sarti

As part of the PR review for PUP-5879, it was found that the puppet module tool errors when building modules which contain non-US English characters.

Repro steps

Git clone a module repo e.g. puppetlabs-dsc
Add a file in the root of the module called ᚠᛇᚻ.txt
Perform a puppet module build e.g. puppet module build <path to dir>

Expected error example

Error: Invalid argument @ rb_sysopen - C:/source/pup5879/puppetlabs-dsc/lib/???.txt

It appears the filename is being mangled somewhere

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
Atlassian logo

Steve Barlow (JIRA)

unread,
May 4, 2016, 1:35:11 PM5/4/16
to puppe...@googlegroups.com

Steve Barlow (JIRA)

unread,
May 9, 2016, 4:57:08 PM5/9/16
to puppe...@googlegroups.com

Kenaz Kwa (JIRA)

unread,
May 23, 2016, 4:47:09 PM5/23/16
to puppe...@googlegroups.com

Larissa Lane (JIRA)

unread,
May 24, 2016, 6:24:03 PM5/24/16
to puppe...@googlegroups.com

Craig Gomes (JIRA)

unread,
Jun 13, 2016, 5:04:06 PM6/13/16
to puppe...@googlegroups.com
Craig Gomes updated an issue
Change By: Craig Gomes
Sprint: Windows 2016- 06 07 - 29 13 - Choco Un

Kenaz Kwa (JIRA)

unread,
Jun 16, 2016, 4:18:03 PM6/16/16
to puppe...@googlegroups.com
Kenaz Kwa updated an issue
Change By: Kenaz Kwa
Sprint: Windows 2016-07-13 - Choco Un

Ethan Brown (JIRA)

unread,
Sep 21, 2016, 6:04:03 PM9/21/16
to puppe...@googlegroups.com
Ethan Brown commented on Bug PUP-6190
 
Re: Puppet module build errors if a file or directory contains non US English characters

There are workarounds for this at the moment, but it's something to improve in the future given local user directories may contain Unicode characters.

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Ethan Brown (JIRA)

unread,
Sep 21, 2016, 6:04:03 PM9/21/16
to puppe...@googlegroups.com

Moses Mendoza (JIRA)

unread,
Sep 21, 2016, 7:25:04 PM9/21/16
to puppe...@googlegroups.com

Moses Mendoza (JIRA)

unread,
Dec 22, 2016, 5:11:15 PM12/22/16
to puppe...@googlegroups.com

Moses Mendoza (JIRA)

unread,
Dec 22, 2016, 5:11:23 PM12/22/16
to puppe...@googlegroups.com
Moses Mendoza commented on Bug PUP-6190
 
Re: Puppet module build errors if a file or directory contains non US English characters

I did a quick repro check on this bug - it no longer fails... in the same way. But it still fails. Instead of exiting with an error, the module builds successfully, but mangles the utf-8 named file in the process:

[0] moses@MacBook-Pro:puppetlabs-dsc (master)
☂ : echo > "ᚠᛇᚻ.txt"
☂ : be puppet module build ~/foo/puppetlabs-dsc
Notice: Building /Users/moses/foo/puppetlabs-dsc for release
Module built: /Users/moses/foo/puppetlabs-dsc/pkg/puppetlabs-dsc-1.2.0.tar.gz
[0] moses@MacBook-Pro:pkg (master)
☂ : tar -xf puppetlabs-dsc-1.2.0.tar.gz
0] moses@MacBook-Pro:puppetlabs-dsc-1.2.0 (master)
☂ : ls
CHANGELOG.md                  MAINTAINERS.md                README_CENTOS6.md             checksums.json                metadata.json
CONTRIBUTING.md               NOTICE                        Rakefile                      dsc_resource_release_tags.yml templates
Gemfile                       README.md                     appveyor.yml                  lib                           types.md
LICENSE                       README_BUILD.md               á? á??á?».txt                 manifests

The file that went in named:

"ᚠᛇᚻ.txt"

came out named:

á? á??á?».txt

Sean McDonald (JIRA)

unread,
May 16, 2017, 5:23:06 PM5/16/17
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Jun 19, 2019, 4:59:03 PM6/19/19
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-6190
 
Re: Puppet module build errors if a file or directory contains non US English characters

puppet module build has been removed in favor of pdk. Please reopen against pdk if this is still a problem.

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages