Jira (PUP-6114) Add support for Artifactory checksum headers and enable SHA1 checksum type

13 views
Skip to first unread message

Geoff Nichols (JIRA)

unread,
Nov 12, 2017, 2:06:04 PM11/12/17
to puppe...@googlegroups.com
Geoff Nichols updated an issue
 
Puppet / New Feature PUP-6114
Add support for Artifactory checksum headers and enable SHA1 checksum type
Change By: Geoff Nichols
Summary: Add support for Artifactory checksum headers  to puppet agent  and enable SHA1 checksum type
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
Atlassian logo

Tim Meusel (JIRA)

unread,
Aug 6, 2018, 2:55:02 PM8/6/18
to puppe...@googlegroups.com
Tim Meusel commented on New Feature PUP-6114
 
Re: Add support for Artifactory checksum headers and enable SHA1 checksum type

Hey puppet people. I'm highly interested into this issue. Any chance you can rereview the PR and work on it? Thanks in advance!

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Jeff Sparrow (JIRA)

unread,
Aug 6, 2018, 2:57:02 PM8/6/18
to puppe...@googlegroups.com
Jeff Sparrow commented on New Feature PUP-6114

Would love to see this implemented. Multiple vendors of our use artifactory for shares, chocolatey, builds, etc. We recently ran into a big headache where we realized files were not md5 checking, using artifactory and its `X-CheckSum-xxx`. As a side note, it also seems that `mtime` is also way off on numerous files vs. the artifactory (remote) `mtime`. Without this update, I will have to move all `file` resources that use artifactory, to a file uri. Which means having to move these to more of a file share type system.

Garrett Guillotte (JIRA)

unread,
Aug 21, 2018, 5:13:04 PM8/21/18
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Aug 8, 2019, 5:06:04 PM8/8/19
to puppe...@googlegroups.com
Josh Cooper commented on New Feature PUP-6114
 
Re: Add support for Artifactory checksum headers and enable SHA1 checksum type

The original PR was declined, so moving the status back to ready for engineering. To watchers on the ticket, we had to clean up puppet's SSL handling first, and I'm now working on cleaning up the agent's http client code (epic PUP-8550). Once that's done, next up is fixing http/https file sources (the epic associated with this issue).

Josh Cooper (Jira)

unread,
May 20, 2020, 4:20:04 PM5/20/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
I've created a patch to add support for the artifactory HTTP headers:
X-Checksum-Md5
X-Checksum-Sha1
X-Checksum-Sha256

to the file resource, when used with an http source. I've also enabled sha1 support as a checksum type. This was already in the code, and with the open source version of artifactory it is the strongest checksum type available.

The code will prioritize sha256, then sha1, then md5 from artifactory, then content-md5 from apache digest.

This reduces resource flapping if the source is an artifactory server.

https://github.com/puppetlabs/puppet/pull/4828


A newer PR was filed in https://github.com/puppetlabs/puppet/pull/5707
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Josh Cooper (Jira)

unread,
Jun 12, 2020, 9:03:04 PM6/12/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jun 16, 2020, 3:53:03 AM6/16/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jun 16, 2020, 3:53:03 AM6/16/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Coremunity Hopper Platform Core KANBAN

Josh Cooper (Jira)

unread,
Jun 17, 2020, 4:21:03 PM6/17/20
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jun 18, 2020, 4:10:03 PM6/18/20
to puppe...@googlegroups.com
Josh Cooper commented on New Feature PUP-6114
 
Re: Add support for Artifactory checksum headers and enable SHA1 checksum type

Merged to master in https://github.com/puppetlabs/puppet/commit/5242077589727e468dc6fac2e441d092a09c6ede

I accidentally used the wrong JIRA ticket in the commit messages. I referenced the old github PR number 5707 instead of 6114

Josh Cooper (Jira)

unread,
Jun 18, 2020, 4:12:03 PM6/18/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Release Notes: Enhancement
Release Notes Summary: Puppet can now retrieve file content from artifactory using an HTTP(S) source parameter.

Claire Cadman (Jira)

unread,
Jul 7, 2020, 10:00:04 AM7/7/20
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages