Jira (PUP-6524) The shell used with exec resource provider=shell should be configurable

[Adam Bottchen (JIRA)]

Adam Bottchen moved an issue

Puppet / PUP-6524 The shell used with exec resource provider=shell should be configurable Change By: Adam Bottchen Component/s: puppet Component/s: Client Key: PE PUP - 14558 6524 Project: Puppet  Enterprise [Internal] Add Comment

This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)

[Adam Bottchen (JIRA)]

Adam Bottchen updated an issue

Puppet / PUP-6524 The shell used with exec resource provider=shell should be configurable

Change By: Adam Bottchen Sprint: Client Triage Scrum Team: Client Platform

Add Comment

[Adam Bottchen (JIRA)]

Adam Bottchen updated an issue

Puppet / PUP-6524 The shell used with exec resource provider=shell should be configurable Change By: Adam Bottchen

Customer found that when creating an exec resource, they are unable to run commands with bash  builtins  process substitions .  For example: {code:java} class exectest {   exec{'run if different':     provider => 'shell',     command => '/bin/echo "they are different" > test.log',     onlyif => "/usr/bin/test `/usr/bin/diff <(printf 'abc') <(printf 'xyz') | grep '' -c` -gt 0",   } } {code} will fail to parse: {code:java} # puppet apply -td -e "include exectest" ... Debug: Exec[run if different](provider=shell): Executing check '["/bin/sh", "-c", "/usr/bin/test `/usr/bin/diff <(printf 'abc') <(printf 'xyz') | grep '' -c` -gt 0"]' Debug: Executing '/bin/sh -c /usr/bin/test `/usr/bin/diff <(printf 'abc') <(printf 'xyz') | grep '' -c` -gt 0' Debug: /Stage[main]/Exectest/Exec[run if different]/onlyif: /bin/sh: command substitution: line 0: syntax error near unexpected token `(' Debug: /Stage[main]/Exectest/Exec[run if different]/onlyif: /bin/sh: command substitution: line 0: `/usr/bin/diff <(printf 'abc') <(printf 'xyz') | grep '' -c' Debug: /Stage[main]/Exectest/Exec[run if different]/onlyif: /usr/bin/test: missing argument after `0' ... {code} This is due to the fact that https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/exec/shell.rb#L19 forces the /bin/sh shell, which cannot parse the bash  builtins  process substitutions .  This is true even on EL systems where /bin/sh is linked to /bin/bash. Customer would like to see the shell used by provider=shell be configurable instead of hardcoded to avoid this issue.

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

Puppet / PUP-6524 The shell used with exec resource provider=shell should be configurable

Change By: Kenn Hussey Sprint: Client Triage

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

Puppet / PUP-6524 The shell used with exec resource provider=shell should be configurable

Change By: Kenn Hussey Sprint: i18n

Add Comment

[Kenn Hussey (JIRA)]

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

Puppet / PUP-6524 The shell used with exec resource provider=shell should be configurable

Change By: Kenn Hussey Sprint: AP 2016-10-19

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

Puppet / PUP-6524 The shell used with exec resource provider=shell should be configurable

Change By: Kenn Hussey Team: Agent & Platform

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

Puppet / PUP-6524 The shell used with exec resource provider=shell should be configurable

Change By: Moses Mendoza Sprint: AP 2016-10-19

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-6524 The shell used with exec resource provider=shell should be configurable

Change By: Geoff Nichols Team: Agent & Platform

Add Comment

[Eric Thompson (JIRA)]

Eric Thompson updated an issue

Puppet / PUP-6524 The shell used with exec resource provider=shell should be configurable

Change By: Eric Thompson Team: Agent & Platform

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Puppet / PUP-6524 The shell used with exec resource provider=shell should be configurable

Change By: Geoff Nichols Component/s: Client Component/s: Types and Providers

Add Comment

[Joe Pinsonault (JIRA)]

Joe Pinsonault updated an issue

Puppet / PUP-6524 The shell used with exec resource provider=shell should be configurable

Change By: Joe Pinsonault Labels: cspapercuts  triaged

Add Comment

[Daryl Cashville (Jira)]

Daryl Cashville commented on PUP-6524

Re: The shell used with exec resource provider=shell should be configurable This was at the root of my issue reported in PA-4649 - Ubuntu uses 'dash' by default which doesn't support 'bash' keywords, operators, etc. It would be nice to be able to specify "provider => '/bin/bash'" or some other attribute to allow all of the exec functions that use shell commands to be consistent in syntax. Right now we have to maintain multiple ugly workarounds for Ubuntu.

Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Dirk Heinrichs (Jira)]

Dirk Heinrichs commented on PUP-6524

Re: The shell used with exec resource provider=shell should be configurable

I wonder why this hasn't been implemented in 6(!!!) years. It's a matter of simply copying lib/puppet/provider/exec/shell.rb to lib/puppet/provider/exec/bash.rb, change its name from ":shell" to ":bash" on line 1 and every occurrence of "/bin/sh" (Hint: there are exactly two of them) to "/bin/bash". Two minutes, problem solved. So, please, just do it.

Add Comment