Jira (PUP-5735) Remove usage of win32-security gem

[Ethan Brown (JIRA)]

Ethan Brown created an issue

Puppet / PUP-5735 Remove usage of win32-security gem Issue Type: Task Assignee: Unassigned Created: 2016/01/21 10:02 AM Fix Versions: PUP 4.3.3 Priority: Normal Reporter: Ethan Brown With PUP-5538 , we reduced our dependency on the win32-security gem. We should fully deprecate its usage. This includes: Moving all the well-known SID constants that are being used into Puppet::Util::Windows::SID Audit the modules on the forge, and notify authors up front that there might be breaking changes going forward - look for strings like win32/security, Win32::Security, etc Remove the inclusion of win32/security anywhere that it occurs - for instance - https://github.com/puppetlabs/puppet/blob/ba5cfc392d597d22fa98e6d62b48f730845b6f22/lib/puppet/util/windows/security.rb#L68 Removal of the actual gem from the puppet-win32-ruby repository branches so that it's not included in the MSI any longer. The deprecation notice should go in Puppet 4.3.x, and the actual removal should be slated for Puppet 4.4.x There are a number of other refactorings that should probably be done at the same time, but could be broken out to a different ticket if necessary: Move the `name_to_sid_object` method off of Puppet::Util::WIndows::SID over to Puppet::Util::Windows::SID::Principal - keep the old method around, but add a deprecation notice. There are likely other methods that should be refactored similarly. Potentially move the class Puppet::Util::Windows::SID::Principal to Puppet::Util::Windows::Principal Add Comment

This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)

[Ethan Brown (JIRA)]

Ethan Brown updated an issue

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Ethan Brown Fix Version/s: PUP 4.4.0

Add Comment

[Steve Barlow (JIRA)]

Steve Barlow updated an issue

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Steve Barlow Sprint: Windows 2016-02-10

Add Comment

[Steve Barlow (JIRA)]

Steve Barlow updated an issue

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Steve Barlow Sprint: Windows 2016-02-24 (Burn FF)

Add Comment

[Craig Gomes (JIRA)]

Craig Gomes assigned an issue to Glenn Sarti

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Craig Gomes Assignee: Glenn Sarti

Add Comment

[Craig Gomes (JIRA)]

[Ryan Gard (JIRA)]

Ryan Gard updated an issue

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Ryan Gard QA Risk Assessment Reason: Developer thought that risk was low. QA Risk Assessment: Low QA Status: Reviewed QA Contact: Ryan Gard

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti commented on PUP-5735

Re: Remove usage of win32-security gem Facter 2.4.6 has a dependency on win32-security

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti commented on PUP-5735

Re: Remove usage of win32-security gem

puppet-win32-ruby references https://github.com/puppetlabs/puppet-win32-ruby/tree/2.1.x-x86/ruby/lib/ruby/gems/2.1.0/gems/win32-security-0.2.5 https://github.com/puppetlabs/puppet-win32-ruby/tree/2.1.x-x64/ruby/lib/ruby/gems/2.1.0/gems/win32-security-0.2.5 https://github.com/puppetlabs/puppet-win32-ruby/tree/2.0.0-x64/ruby/lib/ruby/gems/2.0.0/gems/win32-security-0.2.5 https://github.com/puppetlabs/puppet-win32-ruby/tree/1.9.3/ruby/lib/ruby/gems/1.9.1/gems/win32-security-0.1.4 https://github.com/puppetlabs/puppet-win32-ruby/tree/1.9.3-x86/ruby/lib/ruby/gems/1.9.1/gems/win32-security-0.2.5 https://github.com/puppetlabs/puppet-win32-ruby/tree/1.8.7/ruby/lib/ruby/gems/1.8/gems/win32-security-0.1.4 '

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti updated an issue

Puppet / PUP-5735

Remove usage of win32-security gem

Change By: Glenn Sarti With PUP-5538, we reduced our dependency on the win32-security gem.  We should fully deprecate its usage. This includes: *  (DONE)  Moving all the well-known SID constants that are being used into {{Puppet::Util::Windows::SID}} * Audit the modules on the forge, and notify authors up front that there might be breaking changes going forward - look for strings like {{win32/security}}, {{Win32::Security}}, etc *  (DONE)  Remove the inclusion of {{win32/security}} anywhere that it occurs - for instance - https://github.com/puppetlabs/puppet/blob/ba5cfc392d597d22fa98e6d62b48f730845b6f22/lib/puppet/util/windows/security.rb#L68 * Removal of the actual gem from the {{puppet-win32-ruby}} repository branches so that it's not included in the MSI any longer.  The deprecation notice should go in Puppet 4.3.x, and the actual removal should be slated for Puppet 4.4.x

There are a number of other refactorings that should probably be done at the same time, but could be broken out to a different ticket if necessary:

* Move the `name_to_sid_object` method off of {{Puppet::Util::WIndows::SID}} over to {{Puppet::Util::Windows::SID::Principal}} - keep the old method around, but add a deprecation notice. ** There are likely other methods that should be refactored similarly. * Potentially move the class {{Puppet::Util::Windows::SID::Principal}} to {{Puppet::Util::Windows::Principal}}

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti commented on PUP-5735

Re: Remove usage of win32-security gem Ethan Brown What's the rationale behind the refactoring? The remaining functions all seem to be directly related to the SID object and seem to have no other place to go.

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti commented on PUP-5735

Re: Remove usage of win32-security gem

Modules depending on win32-security puppetlabs-acl https://github.com/puppetlabs/puppetlabs-acl/blob/master/lib/puppet/util/monkey_patches.rb https://github.com/puppetlabs/puppetlabs-acl/blob/master/lib/puppet/provider/acl/windows/base.rb reidmv-windows_package (looks like a copy of all the windows utils from Pup 2.7.x) This module may not be an issue as it's only applicable for Puppet less than 3.0, where as our changes are targetted at Pup 4.x https://forge.puppetlabs.com/reidmv/windows_package https://github.com/reidmv/puppet-module-windows_package/blob/master/lib/puppet/util/windows_package/user.rb

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti updated an issue

Puppet / PUP-5735

Remove usage of win32-security gem

Change By: Glenn Sarti

With PUP-5538, we reduced our dependency on the win32-security gem.  We should fully deprecate its usage. This includes: * (DONE) Moving all the well-known SID constants that are being used into {{Puppet::Util::Windows::SID}}

*  (DONE)  Audit the modules on the forge, and notify authors up front that there might be breaking changes going forward - look for strings like {{win32/security}}, {{Win32::Security}}, etc

* (DONE) Remove the inclusion of {{win32/security}} anywhere that it occurs - for instance - https://github.com/puppetlabs/puppet/blob/ba5cfc392d597d22fa98e6d62b48f730845b6f22/lib/puppet/util/windows/security.rb#L68 * Removal of the actual gem from the {{puppet-win32-ruby}} repository branches so that it's not included in the MSI any longer.  The deprecation notice should go in Puppet 4.3.x, and the actual removal should be slated for Puppet 4.4.x There are a number of other refactorings that should probably be done at the same time, but could be broken out to a different ticket if necessary: * Move the `name_to_sid_object` method off of {{Puppet::Util::WIndows::SID}} over to {{Puppet::Util::Windows::SID::Principal}} - keep the old method around, but add a deprecation notice. ** There are likely other methods that should be refactored similarly. * Potentially move the class {{Puppet::Util::Windows::SID::Principal}} to {{Puppet::Util::Windows::Principal}}

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti commented on PUP-5735

Re: Remove usage of win32-security gem The ruby versions are out of step with the Puppet Versions; e.g. Puppet 4.3.x uses Ruby 2.1.7 and 2.1.8. Whereas Ruby 2.1.7 is used in Puppet 4.2.3, 4.3.0 and 4.3.1

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti commented on PUP-5735

Re: Remove usage of win32-security gem

Created https://github.com/puppetlabs/puppet/pull/4681 for removing the requirement of win32-security from Puppet

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti commented on PUP-5735

Re: Remove usage of win32-security gem

Created MODULES-3093 for modifying the ACL module

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti commented on PUP-5735

Re: Remove usage of win32-security gem

Created https://github.com/puppetlabs/facter/pull/1271 for removing win32-security from Facter 2.x

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti updated an issue

Puppet / PUP-5735

Remove usage of win32-security gem

Change By: Glenn Sarti

With PUP-5538, we reduced our dependency on the win32-security gem.  We should fully deprecate its usage. This includes: * (DONE) Moving all the well-known SID constants that are being used into {{Puppet::Util::Windows::SID}} * (DONE) Audit the modules on the forge, and notify authors up front that there might be breaking changes going forward - look for strings like {{win32/security}}, {{Win32::Security}}, etc * (DONE) Remove the inclusion of {{win32/security}} anywhere that it occurs - for instance - https://github.com/puppetlabs/puppet/blob/ba5cfc392d597d22fa98e6d62b48f730845b6f22/lib/puppet/util/windows/security.rb#L68

*  (MUCH LATER)  Removal of the actual gem from the {{puppet-win32-ruby}} repository branches so that it's not included in the MSI any longer.  The deprecation notice should go in Puppet 4.3.x, and the actual removal should be slated for Puppet 4.4.x

There are a number of other refactorings that should probably be done at the same time, but could be broken out to a different ticket if necessary:

(LATER)

* Move the `name_to_sid_object` method off of {{Puppet::Util::WIndows::SID}} over to {{Puppet::Util::Windows::SID::Principal}} - keep the old method around, but add a deprecation notice. ** There are likely other methods that should be refactored similarly. * Potentially move the class {{Puppet::Util::Windows::SID::Principal}} to {{Puppet::Util::Windows::Principal}}

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti commented on PUP-5735

Re: Remove usage of win32-security gem Need to double check the testing matrix for Facter RE 2003/2008/2012.

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti commented on PUP-5735

Re: Remove usage of win32-security gem

Confirmed the current WIP PR for Facter works on 2008R2 and 2012R2. It is always reporting as true on 2003R2

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti commented on PUP-5735

Re: Remove usage of win32-security gem

Confirmed facter code is correct in all three OSes

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti assigned an issue to Ethan Brown

Puppet / PUP-5735

Remove usage of win32-security gem

Change By: Glenn Sarti Assignee: Ethan Brown

Add Comment

[Ethan Brown (JIRA)]

Ethan Brown assigned an issue to Glenn Sarti

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Ethan Brown Assignee: Ethan Brown Glenn Sarti

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti assigned an issue to Ethan Brown

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Glenn Sarti Assignee: Ethan Brown

Add Comment

[Ethan Brown (JIRA)]

Ethan Brown commented on PUP-5735

Re: Remove usage of win32-security gem Puppet PR merged to master in https://github.com/puppetlabs/puppet/commit/80df195ebf9be27b4d64f7f17fba7facb4713eb5

Add Comment

[William Hopper (JIRA)]

William Hopper assigned an issue to qa

Puppet / PUP-5735

Remove usage of win32-security gem

Change By: William Hopper Status: Ready for  CI  Test Assignee: Ethan Brown qa

Add Comment

[Steve Barlow (JIRA)]

Steve Barlow updated an issue

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Steve Barlow Sprint: Windows 2016-02-24 (Burn FF) , Windows 2016-03-09 (Burn CF)

Add Comment

[Steve Barlow (JIRA)]

Steve Barlow updated an issue

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Steve Barlow Flagged: Impediment

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Josh Cooper Fix Version/s: PUP 4.3.3

Add Comment

[Ethan Brown (JIRA)]

Ethan Brown updated an issue

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Ethan Brown Release Notes Summary: In an effort to improve Puppet's handling of Unicode user and group names on Windows, much of the code interacting with the Windows API has been rewritten to ensure wide character (UTF-16LE) API variants are called.  Previously, Puppet relied on the win32-security gem for some of these interactions, which were implemented as ANSI Windows API calls.  As a result, Puppet no longer needs the win32-security gem, and any code based references to the gem have been removed.  Any module authors requiring functionality in Win32::Security should be aware that a subsequent release will remove this gem from the MSI package permanently.  Though unused by Puppet, the gem currently remains for backward compatibility. Release Notes: Bug Fix

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Kenn Hussey Flagged: Impediment

Add Comment

[Ryan Gard (JIRA)]

Ryan Gard assigned an issue to Ryan Gard

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Ryan Gard Assignee: qa Ryan Gard

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-5735

Re: Remove usage of win32-security gem Puppet stopped using the win32-security gem in PUP 4.4.0, but kept the gem dependency so as to not break custom types/providers. In Puppet 7, we will no longer ship the win32 gem. That change was merged to main in https://github.com/puppetlabs/puppet/commit/13d0ccb4bb428b893635386592f6b6443f946b33. There should have been a separate ticket for the gem removal, but it didn't work out that way.

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Mihai Buzgau (Jira)]

Mihai Buzgau updated an issue

Puppet / PUP-5735

Remove usage of win32-security gem

Change By: Mihai Buzgau Fix Version/s: PUP 7.0.0

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-5735 Remove usage of win32-security gem

Change By: Claire Cadman Labels: doc_reviewed

Add Comment

[Valentyna (Jira)]

Valentyna commented on PUP-5735

Re: Remove usage of win32-security gem The problem exists in puppet/provider/acl/windows/base.rb, which require 'win32/security'. It gets me an error on my Winows 10: Puppet: Could not autoload puppet/provider/acl/windows: cannot load such file – win32/security Puppet: Could not autoload puppet/type/acl: Could not autoload puppet/provider/acl/windows: cannot load such file – win32/security Puppet: Failed to apply catalog: Could not autoload puppet/type/acl: Could not autoload puppet/provider/acl/windows: cannot load such file – win32/security

Add Comment

[Valentyna (Jira)]

Valentyna updated an issue

Puppet / PUP-5735

Remove usage of win32-security gem

Change By: Valentyna Priority: Normal High

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-5735

Re: Remove usage of win32-security gem Valentyna the dependency on win32-security was removed in version 3.2.1 of the puppetlabs-acl module, see https://github.com/puppetlabs/puppetlabs-acl/commit/0aa45cba8eb89cc90879b3c53b854f0f64e482b9. Please update your acl module to 3.2.1 or greater.

Add Comment