patch for mod_extdisco.lua

13 views
Skip to first unread message

Alexey Bobyr

unread,
May 23, 2019, 10:44:39 AM5/23/19
to prosody-dev
Hi,
According to https://xmpp.org/extensions/attic/xep-0215-0.6.html service tag must is a child element of 'services' tag in reply.
Attached patch adds main tag services.


Please note that https://xmpp.org/extensions/xep-0215.html now contains urn:xmpp:extdisco:2
So maybe need to change mod_extdisco description that it adds support of XEP-0215 its not true anymore. 

Current version of mod_extdisco gives support for first version of XEP-0215.
mod_extdisco.patch

Kim Alvefur

unread,
May 23, 2019, 11:25:37 AM5/23/19
to proso...@googlegroups.com
Hi,

On Wed, May 22, 2019 at 11:27:37PM -0700, Alexey Bobyr wrote:
> According to https://xmpp.org/extensions/attic/xep-0215-0.6.html service
> tag must is a child element of 'services' tag in reply.
> Attached patch adds main tag services.

Thanks. Patch looks good. I noticed that the other handler has the same issue.

> Please note that https://xmpp.org/extensions/xep-0215.html now contains
> urn:xmpp:extdisco:2
> So maybe need to change mod_extdisco description that it adds support of
> XEP-0215 its not true anymore.

Looks like the incompatible changes between the :1 and :2 namespace
mainly concern service pushes, which is not implemented here.

--
Kim "Zash" Alvefur

Reply all
Reply to author
Forward
0 new messages