[ANN] PromQL Prettier

[Jiacai Liu]

Have trouble in reading PromQL written by your colleagues or SRE
team?

promql-prettier to the rescue!

- https://github.com/jiacai2050/promql-prettier

Any issues or feedbacks are welcomed.

Thanks.

[Evelyn Pereira Souza]

Hi

Very nice! Thanks

I would send out the mails also to
https://www.mail-archive.com/prometheu...@googlegroups.com/

kind regards
Evelyn

[Bjoern Rabenstein]

That looks pretty neat. I'll try it out.

Did you collaborate with Harkishen Singh, whose GSoC project was
tackling the same problem and who wrote the design doc? Or did you all
of this from scratch?

Any reason why you used the MetricsQL parser rather than the PromQL
parser? Both languages are slightly different, and new features in
PromQL won't necessarily make it to MetricsQL or might be delayed...

It would be cool to have this integrated in promtool as originally
planned. Another reason to use the Prometheus codebase...

--
Björn Rabenstein
[PGP-ID] 0x851C3DA17D748D03
[email] bjo...@rabenste.in

[Bjoern Rabenstein]

I haven't seen any reply to the above, but by now, I can provide a bit
more context:

There was already an effort to implement the original design
doc. Sadly, the PR became stale, but it would be cool to revive it,
see https://github.com/prometheus/prometheus/pull/7779 .

The problem with jiacai2050/promql-prettier is that it is actually not
a PromQL prettier but a MetricsQL prettier. Jiacai, if you do not have
plans to make it compliant with PromQL, you should consider renaming
it to avoid confusing your users. Note that PromQL is well defined. It
is also trademarked by the Linux Foundation. Check out
https://www.linuxfoundation.org/trademark-usage/ for implications.

Thanks for your understanding.

[Jiacai Liu]

Hi beorn7,

Sorry for delayed response. 

I choose MetricsQL as the parser for simplicity, as it require little dependencies.

it seems that PR 7779 is a non-trivial one, I have on idea if it's easy to merge my code to it although format logic is similar.

Maybe I need more time to dig into this. Could anyone guide me to finish 7779?

[Bjoern Rabenstein]

On 12.10.21 19:27, Jiacai Liu wrote:
> it seems that PR 7779 is a non-trivial one, I have on idea if it's easy to
> merge my code to it although format logic is similar.
>
> Maybe I need more time to dig into this. Could anyone guide me to finish
> 7779?

Yeah, it would be great to have someone with context on PR #7779 in
particular and PromQL in general helping out.

I tried to rally some people, but only found out that neither Ganesh
nor Jessica are currently available.

Perhaps a good starting point would be to talk to Harkishen, who wrote
the design doc and authored the PR? He is @Harkishen-Singh on
GH. How about following up on the issue that you are interested in
helping out? If you and Harkishen could polish up the PR, I'm sure
we'll find a reviewer.

Thank you very much.