PromQL language server ownership

[Tobias Guggenmos]

Hi all,

I've spent the last few months writing a language server for Prometheus. ( https://github.com/slrtbtfs/promql-lsp ).

This language server is expected to reach a state where it can be released to the general public in the next few weeks.

There also has been discussion about including some of its completion capabilities in the Prometheus web UI. (https://github.com/prometheus/prometheus/issues/6160).

Currently the language server and the corresponding VS Code extension is hosted under my personal GitHub account.

For the long term IMO it would be better to have these projects hosted by some GitHub organization, either by Red Hat or  prometheus(-community)? .

Since my internship at Red Hat is ending at the end of this February and there is no one else actively working on these projects inside Red Hat, the latter sounds like the better option to me.

What are the thoughts of the prometheus maintainers about this?

[Goutham Veeramachaneni]

I haven't closely followed the progress, but do you plan to work on this even after the internship Tobias? If not, could you find some sponsors on the Prometheus team or elsewhere who can maintain it? If we have people who'll maintain it, then we should definitely move it to prometheus-community.

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAN_8ueFTimv1vUOP%3DVoBzGboXJ6%2BaKvgZTioRqTh7gOSO%2Br4OQ%40mail.gmail.com.

[Tobias Guggenmos]

Since I'm going back to university after my internship, I won't be able to work full time on the project any more.

My current stance on this is, that I'll be fine with doing some maintenance work like reviewing pull request, having architectural discussions and bug fixing.

Also I'd like to keep some influence over the project.

However it's unlikely that I'm going to do major feature development in my free time.

[Tobias Guggenmos]

A related question is whether the accompanying IDE extension should be published under a personal, Red Hat or "official" Prometheus account.

Again, I'd personally prefer the latter.

[Julien Pivotto]

If you find a maintainer to take over, it could be moved to -prometheus.

However it looks like there might be legal implications to this (code is
probably owned by red hat - even if open source).

--
(o- Julien Pivotto
//\ Open-Source Consultant
V_/_ Inuits - https://www.inuits.eu

[Julien Pivotto]

On 23 Jan 17:13, Julien Pivotto wrote:
> On 23 Jan 16:41, Tobias Guggenmos wrote:
> > Since I'm going back to university after my internship, I won't be able to
> > work full time on the project any more.
> >
> > My current stance on this is, that I'll be fine with doing some maintenance
> > work like reviewing pull request, having architectural discussions and bug
> > fixing.
> >
> > Also I'd like to keep some influence over the project.
> >
> > However it's unlikely that I'm going to do major feature development in my
> > free time.
>
> If you find a maintainer to take over, it could be moved to -prometheus.
>

* - community, sorry.

> However it looks like there might be legal implications to this (code is
> probably owned by red hat - even if open source).
>
> --
> (o- Julien Pivotto
> //\ Open-Source Consultant
> V_/_ Inuits - https://www.inuits.eu
>

> --
> You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20200123161305.GA11257%40oxygen.

[Frederic Branczyk]

I'm happy to sponsor this, and the legalities are also not an issue, as Red Hat is interested in having this be a community project.

To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20200123161537.GA18362%40oxygen.

[Bjoern Rabenstein]

On 24.01.20 11:11, Frederic Branczyk wrote:
> I'm happy to sponsor this, and the legalities are also not an issue, as Red Hat
> is interested in having this be a community project.

Thanks, Fred, for sponsoring.

If we want to use the LSP implementation in the UI of the Prometheus
server, then I would even prefer to have this in the Prometheus GH org
proper (not “merely” in prometheus-community).

--
Björn Rabenstein
[PGP-ID] 0x851C3DA17D748D03
[email] bjo...@rabenste.in

[Julien Pivotto]

On 24 Jan 12:11, Bjoern Rabenstein wrote:
> On 24.01.20 11:11, Frederic Branczyk wrote:
> > I'm happy to sponsor this, and the legalities are also not an issue, as Red Hat
> > is interested in having this be a community project.
>
> Thanks, Fred, for sponsoring.
>
> If we want to use the LSP implementation in the UI of the Prometheus
> server, then I would even prefer to have this in the Prometheus GH org
> proper (not “merely” in prometheus-community).

That discussion is already happening here, let's not duplicate it in the ML:

https://github.com/prometheus/prometheus/issues/6160

>
> --
> Björn Rabenstein
> [PGP-ID] 0x851C3DA17D748D03
> [email] bjo...@rabenste.in

[Tobias Guggenmos]

Thanks for the support and sponsorship!

> That discussion is already happening here, let's not duplicate it in the ML:

The github issue discussion is mostly about the technical aspects, while the ML discussion is rather about where the project should live. I don't see too much duplication here.

[Tobias Guggenmos]

It looks like there is some agreement that the language server should go into either the prometheus or the prometheus community org.

So what are the next steps?

[Simon Pasquier]

Frederic already expressed that he's willing to sponsor so I guess
it's all fine and it should just happen.

> --
> You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAN_8ueEzYwqS23OOwz2KPJSFrBaKvs4jw%3DcZ3XnX%2BapA4CHAXA%40mail.gmail.com.

[Krasimir Georgiev]

unless someone objects I will assist with moving the language server and the vscode extension under the community repo.

https://github.com/slrtbtfs/vscode-prometheus --> https://github.com/prometheus-community/promql-vscode

https://github.com/slrtbtfs/promql-lsp --> https://github.com/prometheus-community/promql-lsp

Krasi Georgiev Senior Software Engineer Monitoring Team

To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAM6RFu56YizcK267M%2BXm2xf-1DAkCjRV5cHy4G-PP_7tzGq%3Dug%40mail.gmail.com.

[Tobias Guggenmos]

Sounds good.

One more thing:

When the VS Code extension is inside prometheus-community and some remaining issues are fixed, it should be published on the VS Code extension marketplace. For this, an Azure DevOps organisation account is needed. Does such an account already exist for prometheus?

[Krasimir Georgiev]

On Feb 11 2020, at 2:52 pm, Tobias Guggenmos <tgug...@redhat.com> wrote:

Sounds good.

One more thing:

When the VS Code extension is inside prometheus-community and some remaining issues are fixed, it should be published on the VS Code extension marketplace. For this, an Azure DevOps organisation account is needed. Does such an account already exist for prometheus?

I guess that is optional right? Just to simplify the installation.

Don't think that the team has such account. I guess if it something that you can arrange and just use the  prometh...@googlegroups.com email. Just not sure if it something that should be done right now or a bit later when the project gets more mature. The manual installation doesn't seem so bad just one command line

[Tobias Guggenmos]

There still needs to happen some simplifications in the installation process before the extension gets published.

However as soon as we feel confident enough to have actual users we should publish it there, since the marketplace is where users expect to find their extensions. This will also ensure that updates always get delivered automatically.

[Krasimir Georgiev]

ok lets make the transfer first and will think about this later.

[Tobias Guggenmos]

Updates on this:

The language server has been transferred to prometheus community now: https://github.com/prometheus-community/promql-langserver

After some discussions inside Red Hat, it has been decided that the VS Code extension will probably be transferred to the Red Hat developer organisation.