Roadmap to Prometheus 1.7.2 and 1.8.0

[Björn Rabenstein]

Hi Prometheus devs,

Once https://github.com/prometheus/prometheus/pull/3138 is merged, I'd
really like to cut Prometheus 1.7.2, as the DNS SD bug is really
painful.

If there is anything you know of that needed to be cherry-picked into
the release-1.7 branch, please say so now.

We probably also want a 1.8.0 at some time in the not too far future.
I remember some requirements for it being mentioned before. Perhaps we
should gather those requirements to know when it is a good time to cut
1.8.

Cheers,
--
Björn Rabenstein, Engineer
http://soundcloud.com/brabenstein

SoundCloud Ltd. | Rheinsberger Str. 76/77, 10115 Berlin, Germany
Managing Director: Alexander Ljung | Incorporated in England & Wales
with Company No. 6343600 | Local Branch Office | AG Charlottenburg |
HRB 110657B

[Brian Brazil]

On 12 September 2017 at 18:17, Björn Rabenstein <bjo...@soundcloud.com> wrote:

Hi Prometheus devs,

Once https://github.com/prometheus/prometheus/pull/3138 is merged, I'd
really like to cut Prometheus 1.7.2, as the DNS SD bug is really
painful.

If there is anything you know of that needed to be cherry-picked into
the release-1.7 branch, please say so now.

We probably also want a 1.8.0 at some time in the not too far future.
I remember some requirements for it being mentioned before. Perhaps we
should gather those requirements to know when it is a good time to cut
1.8.

The remote read endpoint has to go in anyway.

--

Brian Brazil

www.robustperception.io

[Tom Wilkie]

There's a fix in the remote write path I'd like to put in 1.7.2 - to stop number of shards going negative. Will make a PR today.

Thanks

Tom

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To post to this group, send email to prometheus...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLpTXP5uOShaZqFTkb9Dqo50%3DEopGp4eAfzNdDVUQHVLYQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Tom Wilkie]

Here you go Björn: https://github.com/prometheus/prometheus/pull/3170; previous PR into master was here for reference: https://github.com/prometheus/prometheus/pull/2973.

Thanks

Tom

[Björn Rabenstein]

On 14 September 2017 at 09:13, Tom Wilkie <tom.w...@gmail.com> wrote:

Here you go Björn: https://github.com/prometheus/prometheus/pull/3170; previous PR into master was here for reference: https://github.com/prometheus/prometheus/pull/2973.

Thanks. Merged!

Anything else for 1.7.2? (Currently, still waiting for Grobie to take a lost look at the DNS SD fix anyway, but once that’s in, it would be good if I could cut the release.)

I leave the call for 1.8.0 to others then.

​

[Björn Rabenstein]

On 14 September 2017 at 13:35, Björn Rabenstein <bjo...@soundcloud.com> wrote:
>
> Anything else for 1.7.2? (Currently, still waiting for Grobie to take a lost
> look at the DNS SD fix anyway, but once that’s in, it would be good if I
> could cut the release.)

FTR: https://github.com/prometheus/prometheus/pull/3176 backports the
html template fix so that 1.7.2 will also build with Go1.9.

[Björn Rabenstein]

Now we have even the date picker fix in.

I'll run a canary with the current state of the release-1.7 branch
today and cut the release tomorrow.

Last call for any more cherries to pick from master!

[Björn Rabenstein]

On 18 September 2017 at 12:14, Björn Rabenstein <bjo...@soundcloud.com> wrote:
>
> Last call for any more cherries to pick from master!

There is actually a pending PR:
https://github.com/prometheus/prometheus/pull/3184

Already under review by Stuart...

[Björn Rabenstein]

1.7.2 is building as we are speaking…

What's the state of the remote read that needs to go into 1.8?

[Tom Wilkie]

I've been testing release-1.7 dd381356 in our cluster, everything looking good there.

Also been testing the remote read for 1.8 PR locally, looking good so far.  Was hoping to get a bit more data in to test first, haven't had the time.  It has an LGTM, so will merge it by the end of the day either way.

Thanks

Tom

[Björn Rabenstein]

On 26 September 2017 at 18:21, Tom Wilkie <tom.w...@gmail.com> wrote:
>
> Also been testing the remote read for 1.8 PR locally, looking good so far.
> Was hoping to get a bit more data in to test first, haven't had the time.
> It has an LGTM, so will merge it by the end of the day either way.

I assume you are talking about
https://github.com/prometheus/prometheus/pull/3023 ?

Once that is merged, is there anything else we need for 1.8?

[Brian Brazil]

On 28 September 2017 at 15:24, Björn Rabenstein <bjo...@soundcloud.com> wrote:

On 26 September 2017 at 18:21, Tom Wilkie <tom.w...@gmail.com> wrote:
>
> Also been testing the remote read for 1.8 PR locally, looking good so far.
> Was hoping to get a bit more data in to test first, haven't had the time.
> It has an LGTM, so will merge it by the end of the day either way.

I assume you are talking about
https://github.com/prometheus/prometheus/pull/3023 ?

Once that is merged, is there anything else we need for 1.8?

https://github.com/prometheus/prometheus/pull/3173

--

Brian Brazil

www.robustperception.io

[Tom Wilkie]

> I assume you are talking about https://github.com/prometheus/prometheus/pull/3023 ?

Yes thats right, merged now.

> Once that is merged, is there anything else we need for 1.8?

Not from me

Thanks

Tom

[Johannes Ziemke]

1.8 will be based on current master, right?

I'd like to see the ingress discovery in 1.8 but since it's already in master that should be the case anyway, right?

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsub...@googlegroups.com.
To post to this group, send email to prometheus-developers@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CALSNGhnkrVxi3wwCcMzWcOqFQ15Uf3uAVuvBo9A%2B3begYAXRGQ%40mail.gmail.com.

[Tobias Schmidt]

Yes, that's correct. It'll be built from master including the ingress discovery.

On Mon, Oct 2, 2017 at 5:35 PM Johannes Ziemke <fi...@freigeist.org> wrote:

1.8 will be based on current master, right?

I'd like to see the ingress discovery in 1.8 but since it's already in master that should be the case anyway, right?

On Thu, Sep 28, 2017 at 7:24 AM, Björn Rabenstein <bjo...@soundcloud.com> wrote:

On 26 September 2017 at 18:21, Tom Wilkie <tom.w...@gmail.com> wrote:
>
> Also been testing the remote read for 1.8 PR locally, looking good so far.
> Was hoping to get a bit more data in to test first, haven't had the time.
> It has an LGTM, so will merge it by the end of the day either way.

I assume you are talking about
https://github.com/prometheus/prometheus/pull/3023 ?

Once that is merged, is there anything else we need for 1.8?

--
Björn Rabenstein, Engineer
http://soundcloud.com/brabenstein

SoundCloud Ltd. | Rheinsberger Str. 76/77, 10115 Berlin, Germany
Managing Director: Alexander Ljung | Incorporated in England & Wales
with Company No. 6343600 | Local Branch Office | AG Charlottenburg  |
HRB 110657B

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To post to this group, send email to prometheus...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CALSNGhnkrVxi3wwCcMzWcOqFQ15Uf3uAVuvBo9A%2B3begYAXRGQ%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To post to this group, send email to prometheus...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CANi%3DR%3D1y6wYo3jrbHnYs8tAqhHKer4BguRR%2BMX6TLpR6BjO9mQ%40mail.gmail.com.

[Björn Rabenstein]

With https://github.com/prometheus/prometheus/pull/3173 merged, the
last blocker is gone, isn't it?

If there are no objections, I'll cut the release tomorrow. (And if
somebody is keen on cutting the release instead of myself, I'd be
happy, too. Way too many things to do...)

[Brian Brazil]

On 5 October 2017 at 14:03, Björn Rabenstein <bjo...@soundcloud.com> wrote:

With https://github.com/prometheus/prometheus/pull/3173 merged, the
last blocker is gone, isn't it?

I believe that's everything.

Brian

 

If there are no objections, I'll cut the release tomorrow. (And if
somebody is keen on cutting the release instead of myself, I'd be
happy, too. Way too many things to do...)

--
Björn Rabenstein, Engineer
http://soundcloud.com/brabenstein

SoundCloud Ltd. | Rheinsberger Str. 76/77, 10115 Berlin, Germany
Managing Director: Alexander Ljung | Incorporated in England & Wales
with Company No. 6343600 | Local Branch Office | AG Charlottenburg  |
HRB 110657B

--

Brian Brazil

www.robustperception.io

[Björn Rabenstein]

Currently canarying for 1.8.0, and ran into https://github.com/prometheus/prometheus/issues/3258