node_exporter on Solaris/Illumos

[Danny Smith]

I've recently had to build node_exporter for an Oracle Solaris system, and noticed that the 'Solaris' support is actually currently Illumos/OpenIndiana support. Both systems have different sets of ZFS kstat information available, and hence the zfs collector doesn't work on Oracle Solaris as-is.

I've modified the collector to properly support both flavours, and enabled the 'uname' collector (bsd variety) for Solaris/Illumos. I've also added a filesystem collector for Solaris/Illumos based on the Linux filesystem collector, but using /etc/mnttab instead. I realise this strictly breaks the rules, namely 'A Collector may only read /proc or /sys files', however under Solaris the kernel mount table is mounted via the 'mnttab' FS as /etc/mnttab.

I also had to tweak Makefile.common to enable a build on both systems, as by default the build expects to be able to download a 'promu' binary, and solaris/illumos are not part of the standard releases.

Could someone take a look please and let me know if this is considered to be in a suitable state for a PR?

https://github.com/dsnt02518/node_exporter

Danny

[Ben Kochie]

I would start with an issue on the repo.

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/de5f4571-2c49-4d89-a2ea-38c110aa8ec9n%40googlegroups.com.

[Danny Smith]

Ok, thanks. Will do.