[VOTE] Allow environment variable expansion on external label values
244 views
Skip to first unread message
Julien Pivotto
Mar 25, 2021, 6:07:01 PM3/25/21
to prometheus-developers
Hereby I am calling a vote to allow the expansion on environment
variables in the prometheus configuration file.
Because it can be seen as an override of a previous vote[1], I am calling a
new vote for this specific part.
The consensus in the dev summit is:
We will allow substitution of ENV variables into label values in the
external_label configuration block only, behind an experimental feature
flag.
The vote is open for a week (until April 2nd), or until we have 9 ayes or 9 noes.
Any Prometheus team member is eligible to vote[2].
1: https://groups.google.com/g/prometheus-developers/c/tSCa4ukhtUw/m/J-j0bSEYCQAJ
2: https://prometheus.io/governance/
--
Julien Pivotto
@roidelapluie
variables in the prometheus configuration file.
Because it can be seen as an override of a previous vote[1], I am calling a
new vote for this specific part.
The consensus in the dev summit is:
We will allow substitution of ENV variables into label values in the
external_label configuration block only, behind an experimental feature
flag.
The vote is open for a week (until April 2nd), or until we have 9 ayes or 9 noes.
Any Prometheus team member is eligible to vote[2].
1: https://groups.google.com/g/prometheus-developers/c/tSCa4ukhtUw/m/J-j0bSEYCQAJ
2: https://prometheus.io/governance/
--
Julien Pivotto
@roidelapluie
Julien Pivotto
Mar 25, 2021, 6:08:35 PM3/25/21
to prometheus-developers
On 25 Mar 23:06, Julien Pivotto wrote:
> Hereby I am calling a vote to allow the expansion on environment
> variables in the prometheus configuration file.
> Because it can be seen as an override of a previous vote[1], I am calling a
> new vote for this specific part.
>
> The consensus in the dev summit is:
>
> We will allow substitution of ENV variables into label values in the
> external_label configuration block only, behind an experimental feature
> flag.
For full clarity, the vote is to give this dev-summit consensus sentence
> Hereby I am calling a vote to allow the expansion on environment
> variables in the prometheus configuration file.
> Because it can be seen as an override of a previous vote[1], I am calling a
> new vote for this specific part.
>
> The consensus in the dev summit is:
>
> We will allow substitution of ENV variables into label values in the
> external_label configuration block only, behind an experimental feature
> flag.
the force of a vote.
>
> The vote is open for a week (until April 2nd), or until we have 9 ayes or 9 noes.
> Any Prometheus team member is eligible to vote[2].
>
> 1: https://groups.google.com/g/prometheus-developers/c/tSCa4ukhtUw/m/J-j0bSEYCQAJ
> 2: https://prometheus.io/governance/
>
> --
> Julien Pivotto
> @roidelapluie
Julien Pivotto
@roidelapluie
Julien Pivotto
Mar 25, 2021, 6:09:07 PM3/25/21
to prometheus-developers
On 25 Mar 23:08, Julien Pivotto wrote:
> On 25 Mar 23:06, Julien Pivotto wrote:
> > Hereby I am calling a vote to allow the expansion on environment
> > variables in the prometheus configuration file.
> > Because it can be seen as an override of a previous vote[1], I am calling a
> > new vote for this specific part.
> >
> > The consensus in the dev summit is:
> >
> > We will allow substitution of ENV variables into label values in the
> > external_label configuration block only, behind an experimental feature
> > flag.
>
> For full clarity, the vote is to give this dev-summit consensus sentence
> the force of a vote.
YES
> On 25 Mar 23:06, Julien Pivotto wrote:
> > Hereby I am calling a vote to allow the expansion on environment
> > variables in the prometheus configuration file.
> > Because it can be seen as an override of a previous vote[1], I am calling a
> > new vote for this specific part.
> >
> > The consensus in the dev summit is:
> >
> > We will allow substitution of ENV variables into label values in the
> > external_label configuration block only, behind an experimental feature
> > flag.
>
> For full clarity, the vote is to give this dev-summit consensus sentence
> the force of a vote.
>
> >
> > The vote is open for a week (until April 2nd), or until we have 9 ayes or 9 noes.
> > Any Prometheus team member is eligible to vote[2].
> >
> > 1: https://groups.google.com/g/prometheus-developers/c/tSCa4ukhtUw/m/J-j0bSEYCQAJ
> > 2: https://prometheus.io/governance/
> >
> > --
> > Julien Pivotto
> > @roidelapluie
>
> --
> Julien Pivotto
> @roidelapluie
Julien Pivotto
@roidelapluie
Matthias Rampke
Mar 26, 2021, 4:46:16 AM3/26/21
to prometheus-developers
YES
--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20210325220903.GA1331978%40oxygen.
Richard Hartmann
Mar 26, 2021, 5:56:42 AM3/26/21
to prometheus-developers
On Thu, Mar 25, 2021 at 11:08 PM Julien Pivotto
<roidel...@prometheus.io> wrote:
> > The consensus in the dev summit is:
> >
> > We will allow substitution of ENV variables into label values in the
> > external_label configuration block only, behind an experimental feature
> > flag.
>
> For full clarity, the vote is to give this dev-summit consensus sentence
> the force of a vote.
YES.
<roidel...@prometheus.io> wrote:
> > The consensus in the dev summit is:
> >
> > We will allow substitution of ENV variables into label values in the
> > external_label configuration block only, behind an experimental feature
> > flag.
>
> For full clarity, the vote is to give this dev-summit consensus sentence
> the force of a vote.
Ganesh Vernekar
Mar 26, 2021, 6:28:02 AM3/26/21
to Prometheus Developers
YES
Tobias Schmidt
Mar 26, 2021, 6:28:36 AM3/26/21
to prometheus-developers
YES
--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20210325220654.GA1317022%40oxygen.
Bjoern Rabenstein
Mar 26, 2021, 2:43:59 PM3/26/21
to prometheus-developers
On 25.03.21 23:06, Julien Pivotto wrote:
> Hereby I am calling a vote to allow the expansion on environment
> variables in the prometheus configuration file.
> Because it can be seen as an override of a previous vote[1], I am calling a
> new vote for this specific part.
>
> The consensus in the dev summit is:
>
> We will allow substitution of ENV variables into label values in the
> external_label configuration block only, behind an experimental feature
> flag.
YES
> Hereby I am calling a vote to allow the expansion on environment
> variables in the prometheus configuration file.
> Because it can be seen as an override of a previous vote[1], I am calling a
> new vote for this specific part.
>
> The consensus in the dev summit is:
>
> We will allow substitution of ENV variables into label values in the
> external_label configuration block only, behind an experimental feature
> flag.
And thanks, Julien, for catching this. We should not forget that the
discussions and consensus finding at the dev-summit, as useful as they
are, are informal decisions and in no way comparable to a formal vote.
Which is the perfect opportunity to apologize for my needlessly
aggressive reaction after Richi emphasized the weight of a dev-summit
consensus. What triggered me was the memory of multiple occasions
where I made an effort to bring novel and nuanced technical arguments
to the table, only to get shot down by “That is not what we decided at
the dev summit.” Which is especially painful if it was “decided” at a
dev summit where I wasn't even present.
> The vote is open for a week (until April 2nd), or until we have 9 ayes or 9 noes.
> Any Prometheus team member is eligible to vote[2].
>
> 1: https://groups.google.com/g/prometheus-developers/c/tSCa4ukhtUw/m/J-j0bSEYCQAJ
> 2: https://prometheus.io/governance/
--
[PGP-ID] 0x851C3DA17D748D03
[email] bjo...@rabenste.in
Bartłomiej Płotka
Mar 26, 2021, 3:34:29 PM3/26/21
to Prometheus Developers
YES
Thanks Julien for handling and excellent implementation.
Julius Volz
Mar 30, 2021, 4:53:57 AM3/30/21
to prometheus-developers
Ben Kochie
Mar 30, 2021, 3:24:32 PM3/30/21
to prometheus-developers
Julien Pivotto
Mar 30, 2021, 3:51:00 PM3/30/21
to prometheus-developers
We have reached enough votes in the same direction:
1 YES Bartłomiej Płotka
2 YES Ben Kochie
3 YES Björn Rabenstein
4 YES Ganesh Vernekar
5 YES Julien Pivotto
6 YES Julius Volz
7 YES Matthias Rampke
8 YES Richard Hartmann
9 YES Tobias Schmidt
With 9 YES votes / 16 members, the ayes have it.
Regards,
--
Julien Pivotto
@roidelapluie
1 YES Bartłomiej Płotka
2 YES Ben Kochie
3 YES Björn Rabenstein
4 YES Ganesh Vernekar
5 YES Julien Pivotto
6 YES Julius Volz
7 YES Matthias Rampke
8 YES Richard Hartmann
9 YES Tobias Schmidt
With 9 YES votes / 16 members, the ayes have it.
Regards,
Julien Pivotto
@roidelapluie
Reply all
Reply to author
Forward
0 new messages