Changing `master` to `main` across the org?

70 views
Skip to first unread message

Richard Hartmann

unread,
Jun 24, 2020, 10:06:37 AM6/24/20
to Prometheus Developers
Dear all,

I talked about this with a few of you already and the general feeling
of the room was "this is worthwhile, but it carries an opportunity
cost". So: What do you think? Should this be a goal?

CNCF is on board and assigned tech writer resources to switching over,
and I suggested making CI/CD migrations etc part of Community Bridge
outreach as it's a great intern project.

It definitely makes sense to wait for GitHub to decide on a name and
to provide tooling to minimize toil.

Thoughts?


Richard

Bartłomiej Płotka

unread,
Jun 24, 2020, 10:15:55 AM6/24/20
to Richard Hartmann, Prometheus Developers, Thanos Team
+1 on this from Prometheus side, but also cc Thanos Team, I think we should do that everywhere.

Kind Regards
Bartek

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAD77%2BgTerwefdtSU5PB0vPmYA%2BW-20VoDy2GG7AH6F%2BG2RoL3Q%40mail.gmail.com.

Tobias Schmidt

unread,
Jun 24, 2020, 11:17:19 AM6/24/20
to Bartłomiej Płotka, Richard Hartmann, Prometheus Developers, Thanos Team
+1

As Github seems to be working on it already, I'd wait to see what they can provide to simplify the transition. Would it make sense to tweet from our Twitter account to let them know we're interested in such functionality?

I looked at other problematic terminologies across our code bases, and it'll be hard to do much about it until third-parties have changed it on their side, e.g. https://github.com/search?q=org%3Aprometheus+slave&type=Code

Frederic Branczyk

unread,
Jun 24, 2020, 12:38:54 PM6/24/20
to Tobias Schmidt, Bartłomiej Płotka, Prometheus Developers, Richard Hartmann, Thanos Team
Tobias’ idea sounds great, and I’m +1 with this!

You received this message because you are subscribed to the Google Groups "Thanos Team" group.
To unsubscribe from this group and stop receiving emails from it, send an email to thanos-io+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/thanos-io/CAChBsdC01oRuGXRmTk-gJVwB1MmbwF5nGfj4OD732Oswfbp1dA%40mail.gmail.com.

Matthias Rampke

unread,
Jul 1, 2020, 3:54:46 AM7/1/20
to Frederic Branczyk, Tobias Schmidt, Bartłomiej Płotka, Prometheus Developers, Richard Hartmann, Thanos Team
+1 for changing the default branch, +1 to seeing what GitHub does to help us, but if there is no movement on that we can also work out a plan ourselves.

For the MySQL case, if we are willing to break compatibility and consistency, we could change the metric names even without waiting for the underlying commands to change. A risk is that we choose one terminology, and upstream ends up choosing another in a year. A chance is that we set a precedent and upstream eventually follows :)

/MR

Julien Pivotto

unread,
Jul 2, 2020, 6:21:56 AM7/2/20
to Matthias Rampke, Frederic Branczyk, Tobias Schmidt, Bartłomiej Płotka, Prometheus Developers, Richard Hartmann, Thanos Team

Ben Kochie

unread,
Jul 3, 2020, 5:00:21 AM7/3/20
to Julien Pivotto, Matthias Rampke, Frederic Branczyk, Tobias Schmidt, Bartłomiej Płotka, Prometheus Developers, Richard Hartmann, Thanos Team

Matthias Rampke

unread,
Jul 3, 2020, 5:06:56 AM7/3/20
to Ben Kochie, Julien Pivotto, Frederic Branczyk, Tobias Schmidt, Bartłomiej Płotka, Prometheus Developers, Richard Hartmann, Thanos Team
I'm going to file an issue in the mysql exporter to discuss how we handle this.

/MR

Tobias Schmidt

unread,
Jul 24, 2020, 10:31:22 AM7/24/20
to Matthias Rampke, Ben Kochie, Julien Pivotto, Frederic Branczyk, Bartłomiej Płotka, Prometheus Developers, Richard Hartmann, Thanos Team
GitHub released there plans around renaming the main branch: https://github.com/github/renaming

If you haven’t moved yet, we recommend not moving right now, and waiting until later this year. We’re investing in tools to make the renaming the default branch of an existing repository a seamless experience for both maintainers and contributors.
Reply all
Reply to author
Forward
0 new messages