Q: why is prometheus/common/sigv4 is a separate module

[Marcelo Magallón]

Hi,

Recently I was looking at github.com/prometheus/common and I noticed that github.com/prometheus/common/sigv4 is its own separate Go module.

The interesting bit is that it depends on the github.com/prometheus/common Go module (the config package that it contains).

This means that changing github.com/prometheus/common does not get immediately reflected in github.com/prometheus/common/sigv4: you have to update the version specified in sigv4's go.mod file, which in turn means you have to _merge_ changes to common before they are visible to the code in sigv4.

Was this intentional? Am I missing something?

--

Marcelo Magallón

[Julien Pivotto]

Hello,

I don't want common to have a dependency on the AWS SDK. On the other
hand, sigv4 is used in Prometheus and alertmanager so it makes sense to
have it as a shared library.

Regards,

>
> --
> Marcelo Magallón
>
> --
> You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CABiJYgYdZs4mgfV91j-DV1A2fghjWExw8hozvuKEjdtkNN85wg%40mail.gmail.com.

--
Julien Pivotto
@roidelapluie

[Marcelo Magallón]

On Thu, Oct 14, 2021 at 12:57 PM Julien Pivotto <roidel...@prometheus.io> wrote:

I don't want common to have a dependency on the AWS SDK. On the other
hand, sigv4 is used in Prometheus and alertmanager so it makes sense to
have it as a shared library.

Ah, makes sense, thanks!