Standard path for mixins

[Ben Kochie]

We currently have mixins spread out over various paths within each repository. It would be nice if there was a standard path for this.

What do people think of having all projects keep their mixins in `/monitoring-mixin`?

alertmanager/doc/alertmanager-mixin
mysqld_exporter/mysqld-mixin
node_exporter/docs/node-mixin
prometheus/documentation/prometheus-mixin

[Tom Wilkie]

@Frederic Branczyk should weigh in on this, but I believe the module name == the directory name in jsonnet bundler, so if we call them all monitoring-mixin then it will make it tricky to import multiple ones into the same project.  So with that in mind I like "<project>-mixin".

But we could be more consistent about root-of-repo vs docs vs documentation directories...

Tom

--
You received this message because you are subscribed to the Google Groups "Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-devel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CABbyFmrhhG-%3DEQcb2zm%3Dkc2%3DuqX7nxHb2%3D6YG8cgTNec-fqdRQ%40mail.gmail.com.

[Frederic Branczyk]

In newer versions of jsonnet-bundler this is not strictly necessary anymore, the module name has been only a “legacy” import option for the last year (I just checked the version allowing it went out almost to the day exactly a year ago). If there are conflicts the absolute (go import style) full module name must be specified, which might be nice way to move the ecosystem forward anyways.

I don’t think this should stop us from doing this, I don’t feel strongly one way or the other about the directory structure itself though I agree we could be more consistent.

[Matthias Loibl]

Hi,
agreed to what has been said so far.

Do you simply want more consistency or is it for discoverability too, Ben?
The latter should be solved with https://monitoring.mixins.dev. 

[Ben Kochie]

* Make it easier to find in the repo.

* Make testing easier.

https://github.com/prometheus/circleci/pull/15

To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/661e30ac-8f39-4123-997f-b6537358f0edn%40googlegroups.com.