why we have call predrain_fence_sfence on memset_nodrain_movnt function ?

[David Moses]

Hi * ,

Can someone explain why we need this call ? 

the drain /fence need to be in separate call while using this function .isn't it ? 

Thx

David 

[Czurylo, Krzysztof]

Hi David,

 

I guess you're refering to some older version of libpmem.

Please, look at the latest code and you'll see the fence is added only in some specific case.

There is also a comment explaining why it's needed.

 

https://github.com/pmem/pmdk/blob/8bbf0a27fd352f5eeb00b8b379c17c9323a09993/src/libpmem/pmem.c#L1220

 

K.

 

--
You received this message because you are subscribed to the Google Groups "pmem" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pmem+uns...@googlegroups.com.
To post to this group, send email to pm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/pmem/3581ad80-8953-4cb3-b71f-a25aa754484a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[David Moses]

Thx  K .

This one is looks better ...

any recommendations on the best version to start testing with ? 

Thx

David  

On Thu, Feb 15, 2018 at 6:12 PM, Czurylo, Krzysztof <krzyszto...@intel.com> wrote:

Hi David,

 

I guess you're refering to some older version of libpmem.

Please, look at the latest code and you'll see the fence is added only in some specific case.

There is also a comment explaining why it's needed.

 

https://github.com/pmem/pmdk/blob/8bbf0a27fd352f5eeb00b8b379c17c9323a09993/src/libpmem/pmem.c#L1220

 

K.

 

From: pm...@googlegroups.com [mailto:pm...@googlegroups.com] On Behalf Of David Moses
Sent: Thursday, February 15, 2018 13:35
To: pmem
Subject: why we have call predrain_fence_sfence on memset_nodrain_movnt function ?

 

Hi * ,

Can someone explain why we need this call ? 

the drain /fence need to be in separate call while using this function .isn't it ? 

 

Thx

David 

--
You received this message because you are subscribed to the Google Groups "pmem" group.

To unsubscribe from this group and stop receiving emails from it, send an email to pmem+unsubscribe@googlegroups.com.

[Czurylo, Krzysztof]

The next stable PMDK version should be released in a few weeks (mid March).

So, the best option is to start with the latest master or wait a couple of days until the first 1.4 RC.

 

K.

 

To unsubscribe from this group and stop receiving emails from it, send an email to pmem+uns...@googlegroups.com.

To post to this group, send email to pm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/pmem/3581ad80-8953-4cb3-b71f-a25aa754484a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

 

--

You received this message because you are subscribed to the Google Groups "pmem" group.

To unsubscribe from this group and stop receiving emails from it, send an email to pmem+uns...@googlegroups.com.

To post to this group, send email to pm...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/pmem/CA%2BqYZY3BX8ZJZbPaR_GGKx06qsjmY_1zNBu6kDUp-HVnJibJxg%40mail.gmail.com.