Typos / Wording / Grammar

40 views
Skip to first unread message

William Pinaud

unread,
Sep 12, 2018, 12:04:36 PM9/12/18
to PHP Framework Interoperability Group
Hello everyone!

Totally new here, was just spending some time reading the PSRs and found out a few typos, so decided to venture in the world of PRs and created very small ones to propose very slight changes to PSR 13 15 16 17. Could prolly have the time to do the same for all the other ones soon.

So I created four PRs, not sure I can label them (pretty sure I can't ^^).


Hope it serves. I'm not really used to contributing here (please don't hit me ^^).

Thanks!

Benjamin Mack

unread,
Sep 13, 2018, 12:18:40 AM9/13/18
to php...@googlegroups.com
Hi William,

thanks for your contribution. No worries: Nobody will hit you for contributing or improving :) Thanks for jumping right in and making Pull Requests, see feedback directly in there.

Benni.

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
To post to this group, send email to php...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/3ec3e548-2a5e-4470-ba7c-43f349bcaceb%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

William Pinaud

unread,
Sep 13, 2018, 3:26:51 AM9/13/18
to PHP Framework Interoperability Group
Hey there!

Just answered all comments. Might have to update one or two PRs, actually. I just edited some stuff like the double spaces after full stops / periods. Not because it's incorrect, but because the documents used both.

Same goes for grammar. Some stuff can be plural or singular in both English and other languages, cause of maths and language counting logic. But overall I thought it would be a nice idea to changes those two or three things so that the documents always use the same.

All in all it was just about coherence. I know it's affecting already valdiated PSRs but yet, nothing structural is changed. :)

William Pinaud

unread,
Sep 14, 2018, 3:04:29 AM9/14/18
to PHP Framework Interoperability Group
Update: done! :)
Reply all
Reply to author
Forward
0 new messages