Found a typo in fig-standards; made a pull request

Royall Spence

unread,

Jul 7, 2016, 4:50:47 PM7/7/16

to PHP Framework Interoperability Group

There's a minor typo in the PSR-4 example document. I've made a pull request with a fix. The page on Github says it'll be overlooked if I don't mention it here, so have a link: https://github.com/php-fig/fig-standards/pull/784

Michael Cullum

unread,

Jul 7, 2016, 5:47:22 PM7/7/16

to FIG, PHP

Many thanks for that PR; I've now merged it.

You're correct in that sending a mailing list post is the best way to ensure things don't get missed so thanks for that also.

--

Michael C

On 7 July 2016 at 21:50, 'Royall Spence' via PHP Framework Interoperability Group <php...@googlegroups.com> wrote:

There's a minor typo in the PSR-4 example document. I've made a pull request with a fix. The page on Github says it'll be overlooked if I don't mention it here, so have a link: https://github.com/php-fig/fig-standards/pull/784

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
To post to this group, send email to php...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/d0bf1c3a-8b49-495b-9609-338ace0721f3%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Colin O'Dell

unread,

Jul 7, 2016, 6:47:59 PM7/7/16

to FIG, PHP

I ran the accepted proposals through a grammar checker and found a few more typos: https://github.com/php-fig/fig-standards/pull/785 Let me know if any proposed changes are incorrect and I'll happily revert them.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAAqcDMg5kir7Yz7_Ykz5kB1BmE9oFpe%2BwpyM%2BkJo_sWmBeXOMA%40mail.gmail.com.

Larry Garfield

unread,

Jul 7, 2016, 7:57:29 PM7/7/16

to php...@googlegroups.com

Thanks, Colin, I left a few notes on the PR as I think a few of them are stet.

Any chance we could run these automated checks on in-development specs, like, during Review phase in the future? :-)

--Larry Garfield

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAJaRsPuJusoeo2D8W_y%3DmqW8A99k3%3DZzjL03rZTZKSkXAWH6Ug%40mail.gmail.com.

Colin O'Dell

unread,

Jul 7, 2016, 8:59:13 PM7/7/16

to PHP Framework Interoperability Group

PR has been updated - thanks for the feedback!

For this PR I manually copypasted the documents into Grammarly.com's online tool to check the grammar and spelling. Unfortunately, I don't think they have an API, and I'm unfamiliar with any automated tools which could be used instead. (Perhaps I'll add this to my backlog of interesting project ideas to implement "some day"...)