[VOTE] [Accept] PSR-12 Extended Coding Style Guide

[Chris Tankersley]

Finally, after a very long review period and much discussion and tweaking, I think we are finally ready for the acceptance vote for PSR-12.

The specification can be found here:

https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md

And the meta document here:

https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide-meta.md

Thank you to everyone involved!

--

Chris Tankersley
http://ctankersley.com

[Korvin Szanto]

Thanks for being our sponsor Chris!

+1

[Chris Tankersley]

Because I accidently left it out of the first e-mail, the two trial implementations are:

PHP CodeSniffer: https://github.com/squizlabs/PHP_CodeSniffer/tree/master/src/Standards/PSR12

EasyCodingStandard: https://github.com/Symplify/EasyCodingStandard (https://www.tomasvotruba.cz/blog/2018/04/09/try-psr-12-on-your-code-today/)

[Woody Gilk]

+1

There are some examples that could be more logical, but those can be improved with an errata.

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAL9n4XNvPxjnYoOVCAaSzjfvU9p%3DrpnWPnLzAFGfUcfMwRJQGw%40mail.gmail.com.

[Nikolaos Dimopoulos]

+1

Great work! Thank you for the time and effort

[Michael Cullum]

+1

[Josh Bruce]

First time.

+1

Do I get a vote??

Cheers,
Josh

> On Jul 28, 2019, at 7:21 AM, Michael Cullum <m...@michaelcullum.com> wrote:
>
> +1

>
> --
> You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/52b2d22b-bee4-41f6-b61e-f7174f7f8b7d%40googlegroups.com.

[Chris Tankersley]

As a general reminder, Approval votes are Core Committee members only[1]. I left it out of the subject line since this isn't a split vote like some things.

-Chris

[1] https://www.php-fig.org/bylaws/voting-protocol/#approval-vote

[Dracony]

+1 from PHPixie

I a so happy an extended checkstyle is happening!

[Matthew Weier O'Phinney]

Hi Chris!

I don't recall seeing a review period. There was one some time ago (February), but my understanding was that it was retracted once some feedback came in (most recent was May). IIRC, we're supposed to reopen the review period if we don't go directly to the acceptance vote.

Regardless, can you summarize what changes were made since then, and what, if any, feedback was addressed? 

Thanks!

--

You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com.

[Chris Tankersley]

Hello Matthew!

As far as I'm aware, we never retracted the review period, but it was incredibly long. A big portion of that was getting two implementations ready for the final acceptance vote. We had talked back in March internally about going to the Acceptance vote, but needed the implementations. Unfortunately, since this was not just a set of interfaces, we had to get working style guide rules ready to go, and we wanted to make sure they were ready for big-named style checkers.

During the review process we merged in a handful of grammar/typo PRs, but functionality-wise only changed the following:

- Body must start on line after an opening brace [1]

This was added to provide consistency with the rule about no black lines between the end of a body and a closing brace, and it was decided that this would not be a major amount of work to implement for the reference implementations.

As for feedback, I believe that was taken care of in the two threads[2][3]. The only major things that have come up (actually right after we called for the Acceptance vote) are the accessibility debate on tabs vs spaces and 7.4 support. We've decided that since PSR-12 is based on PSR-2, tabs vs spaces is outside of this PSR and will not be making that change as part of PSR-12. I've also decided that since 7.4 is not released, we will not be considering the syntax changes for it.

-Chris

[1] https://github.com/php-fig/fig-standards/pull/1164

[2] https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!searchin/php-fig/PSR-12%7Csort:date/php-fig/jHf53u6PzHM/Ko9d8OR7BQAJ

[3] https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!searchin/php-fig/PSR-12%7Csort:date/php-fig/p94Hef2_ymA/ZkAfXwGhDAAJ

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAJp_myWGb%3DCfYwhW7YRB5ADUx%3DJ%3Dov%3Dy4tp-dq0eTKPrOaTJFQ%40mail.gmail.com.

[Kenta Usami]

Hi,

The current version of PSR-12 seems to lack mention of Arrow Functions[1] added in PHP 7.4.

Do you have plans to add a chapter about the arraw function to PSR-12 (or next Coding Style Guide PSR)?

It is possible to analogize the spacing around `fn` from other language constructs.

However, I think that there is a controversy in the case of indentation followed by a line break and a long expression immediately after `=>`,

[1] https://wiki.php.net/rfc/arrow_functions_v2

2019年7月27日土曜日 1時10分54秒 UTC+9 Chris Tankersley:

[Chris Tankersley]

Hello Kenta!

This thread is just for voting. Please keep any questions to separate threads. 

We do not plan on addressing 7.4 usage with PSR-12. PHP 7.4 is not released, so we do not have any real-world usage patterns for it yet. Some things may be able to be covered with errata, some may require a different standard in the future. 

-Chris

--

You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/47ac7aca-7a10-4624-8c11-7c13ff34b67f%40googlegroups.com.

[Kenta Usami]

Hello Chris.

I wanted to confirm that PSR-12 did not cover it.

Thank you and I'm sorry.

[Beau Simensen]

+1

[Samantha Quiñones]

+1

Very exciting stuff!

[Chuck Burgess]

+1

On Mon, Aug 5, 2019, 10:53 Samantha Quiñones <ieatkil...@gmail.com> wrote:

+1

Very exciting stuff!

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/4bf9d77c-41a5-41c8-af6b-db7a1beb5855%40googlegroups.com.

[Matteo Beccati]

+1

> --
> You received this message because you are subscribed to the Google
> Groups "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to php-fig+u...@googlegroups.com

> <mailto:php-fig+u...@googlegroups.com>.

> To view this discussion on the web visit

> https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com
> <https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com?utm_medium=email&utm_source=footer>.


--
Matteo Beccati

Development & Consulting - http://www.beccati.com/

[Matthew Weier O'Phinney]

+1 from me.

--

You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.

To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com.

--

Matthew Weier O'Phinney
mweiero...@gmail.com

https://mwop.net/

he/him

[Cees-Jan Kiewiet]

+1

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAJp_myUWPOR50yBiMsB8R2tP7%2BZ90VC7CSa0k%2BpO_8ofCuMQbA%40mail.gmail.com.

[Stefano Torresi]

Hey list,

I'm afraid my vote is -1, as anticipated on Slack.

I have expressed some criticism which have not been addressed:

- it is not clear what version of PHP the spec is targeting

- IMHO, 7.4 should have been targeted, because it is only a few months away

- the splat operator is not covered by section 6.1

Plus, I don't quite fancy the "we'll fix it with an Errata" line of thought.

PSRs are made to last years, we don't have an efficient process to let them evolve organically and incrementally, so I'd rather have them made as thoroughly as possible, and as much as I can be thankful to the WG for their efforts, I don't feel the work is quite done here.

Ad maiora!

Cheers,

Stefano

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAPY1sU-hiwjzU%3DPEvd0QALd8jVcjaqGSEaCDwr9uFPA3%2BQwroA%40mail.gmail.com.

[Larry Garfield]

-1

--
Larry Garfield
la...@garfieldtech.com

> --
> You received this message because you are subscribed to the Google
> Groups "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to php-fig+u...@googlegroups.com.
> To view this discussion on the web visit

> https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com <https://groups.google.com/d/msgid/php-fig/CAL9n4XNXae2wfGbwERNEF-68M8cxrvxgeu%2BjKSdvb2HravQ%3D7w%40mail.gmail.com?utm_medium=email&utm_source=footer>.

[Chris Tankersley]

I'm awesome and didn't cast my vote for some reason. 

+1

-Chris

[Asmir Mustafic]

Voting for PSR-12 (Extended Coding Style Guide) closed yesterday, 9 August 2019, at 23:59 UTC.
I am happy to announce that the PSR-12 specification was approved.

In the next days the PHP FIG website will be updated.

The breakdown of votes is below. 

Voted +1:

Beau Simensen (@beausimensen)

Matthew Weier O’Phinney (@mwop)

Cees-Jan Kiewiet (@WyriHaximus)

Samantha Quiñones (@ieatkillerbees)

Chris Tankersley (@dragonmantank)

Korvin Szanto (@korvinszanto)

Michael Cullum (@michaelcullumuk)

Chuck Burgess (@ashnazg)

Woody Gilk (@shadowhand)

Matteo Beccati (@mbeccati)

Voted -1:

Larry Garfield (@Crell)

Stefano Torresi (@storresi)

Voted +0:

No +0 votes

Eleggibile members to vote: 12

Quorum: 6 (50%) 

Total votes: 12

Quorum: reached

Min votes to pass: 8 (2/3 of voters)

Total in favor: 10 

Total against: 2 

Abstaining: 0 

Voting result: pass

Thank to everyone

Asmir Mustafic

PHP-FIG secretary

[Asmir Mustafic]

To clarify some misinformation that is around (reddit, twitter):

As per https://www.php-fig.org/bylaws/voting-protocol/#approval-vote , the approval vote is limited to Core Members of the PHP-FIG.

In the voting period, some other people have "voted" with some "+1", but their votes have not been counted as it should be clear from the votes-summary in my previous message.

PSR-12 is the result of the hard work of more than 12 people. Actually is the result of more than 100 pull requests and some names (and PHP projects) that participated in the realization of PSR-12 can be found at https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-12-extended-coding-style-guide-meta.md.

Asmir Mustafic

PHP-FIG secretary

[Jordi Martínez]

Hi Chris

Please, be aware that, once accepted, the PSR documentation was relocated. Therefore the urls should be replaced by these ones:

https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-12-extended-coding-style-guide.md

https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-12-extended-coding-style-guide-meta.md

Jordi