[DISCUSSION] PSR-18 HTTP Client Acceptance Vote

[Michael Cullum]

Hi,

One of the core requirements for a specification to proceed from review and be fully accepted is the demonstration of multiple full implementations. No such implementations are mentioned in the metadoc or vote.

Could references to some implementations please be provided (and they should also be added to the metadoc)?

Thanks,

Michael

[Matthew Weier O'Phinney]

I know for sure HTTPlug has been following the spec, and that has a whole ecosystem of both first and third party adapters.

While the implementations should be provided/listed during review, my understanding is that they should not be listed in the metadoc itself as the implementation generally changes after acceptance. I know we did not provide them in that location in either psr-15 or psr-17.

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
To post to this group, send email to php...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAAqcDMh3OGsL8%3Dw4f-_Fmz-%3D2LTyeRZ6tJLptVdjiXH%3D52RzPA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Stefano Torresi]

Hey folks,
I know it was a very minor nitpick, but my issue with explaining the naming rationale behind `sendRequest(Request $request)` in the metadoc doesn't seem to have been addressed.

Here is a PR for you, I hope you find it appropriate:
https://github.com/php-fig/fig-standards/pull/1096

Cheers

[Tobias Nyholm]

Hey.

As mentioned, HTTPlug has prepared a 2.0 to make sure it is supporting the new PSR. They are just waiting for the PSR to be released.

https://github.com/php-http/httplug/tree/2.x

As of clients, Buzz has been adapting to every version of the PSR and has their 0.17.3 release with the latest version of psr/http-client.

https://github.com/kriswallsmith/Buzz

How many is needed? Also, should these really be in the meta doc?

[Márk Sági-Kazár]

I think this situation is somewhat special, because PSR-18 was built on HTTPlug which already has tons of examples out there. Basically the only change is some syntactic sugar (type hints) and some interface name changes, the implementations themselves remain 99% the same.

But actually there are examples (linked by Tobias). A question is whether unmerged pull requests to already existing software qualify as example or not. In my opinion asking existing software to implement a standard which has not yet been accepted and integrate it into the master branch would be horrific from a professional software development point of view, so I really hope that you do accept PRs and branches as an example of implementation.

I guess once the standard is accepted and all the reference implementations are merged the meta doc can be updated.

[Stefano Torresi]

In my opinion asking existing software to implement a standard which has not yet been accepted and integrate it into the master branch would be horrific from a professional software development point of view, so I really hope that you do accept PRs and branches as an example of implementation.

That's not what we're asking for at all, we're just asking to provide 2 reference implementations, they don't necessarily have to be presented as a GA release of a super-popular library, they could even be PoC made ad-hoc by the WG.

There is nothing peculiar about this PSR, if the WG wants to provide HTTPlug as a reference, by all means, a dedicated branch will do; we just need to browse the code and play with it, and yes, these implementations should be listed in the metadoc, and they must be fit as good examples for anyone who may need pointers while trying to implement the spec by themselves.

[Márk Sági-Kazár]

My understanding is that HTTPlug was always the reference and it looked like from this post that it wasn't enough.

If that wasn't the case then I misunderstood something.

[Stefano Torresi]

My understanding is that HTTPlug was always the reference and it looked like from this post that it wasn't enough.

Well, that's correct, as in: it wasn't enough by itself because we needed at least another reference implementation. ;-)
Anyway, I think everything has been sorted out now, so no worries.

Kudos to the PSR-18 WG!