[PSR-12] Casting variable section

[Georgios Mponos]

Hello,

I am writing this thread in order to notify you about casting issues that got into my attention. I think that PSR-12 is not dealing with how the casting should be styled

https://github.com/squizlabs/PHP_CodeSniffer/pull/2331

Also one more thing that could be useful is this:

https://github.com/doctrine/coding-standard/pull/100

I believe that PSR-12 should deal with spaces inside of cast and spaces before the cast.

Regards,

[Alexander Makarov]

Lowercase and short forms for keywords are covered. Spaces aren't addressed because it is quite controversial. Both space after casting and no-space after casting styles are used widely.

[Georgios Mponos]

Hello Alexander... Mostly I care about cases of space before cast.. (check the doctrine PR) and spaces inside the cast (check the codesniffer PR)..

Do you believe that these two cases could be covered from the new PSR-12.. I undestand that what you mention is indeed controversial.. but the cases that I am referring to are not that much according to my perception.

[Georgios Mponos]

Elaborating further:

case 1:

if ( (bool) $var === true){

}

// although this might be covered from section about if statements

case 2:

$var =(bool)$var1;

// although this might from other section related with assignment of variable...

case 3:

( bool ) $var === true

// I think this is not covered from any section

Τη Παρασκευή, 28 Δεκεμβρίου 2018 - 5:07:21 μ.μ. UTC+2, ο χρήστης Georgios Mponos έγραψε:

[Alessandro Lai]

I agree, spacing before could be required and spacing inside could be forbidden.

[Alexander Makarov]

Agree.

[Alexander Makarov]

I'll pull-request.

[Georgios Mponos]

FYI it needs some extra attention because in case of an `if` statement you do not want a space before.. (at least that's what I think)... or in case of an assignment you need the space before.

if((int)$var) {

}

$var = (int) $var2;

Τη Παρασκευή, 28 Δεκεμβρίου 2018 - 5:07:21 μ.μ. UTC+2, ο χρήστης Georgios Mponos έγραψε:

[Alexander Makarov]

After thinking about it more, spaces before should not be mentioned because these are covered by operators and statements already:

From section 5, control structures:

> - There must not be a space after the opening parenthesis

> - There MUST NOT be a space before the closing parenthesis

From section 6, operators:

> - All binary and ternary (but not unary) operators MUST be preceded and followed by at least

one space

So that leaves us with one addition that is specific for type casting — https://github.com/php-fig/fig-standards/pull/1141

[Alexander Makarov]

Merged. Thank you raising the issue, Georgios.