After some time of carefully reviewing and discussions on Github I want to let the mailing list know that we are soon comfortable with how PSR-18 looks. We have documented the discussions in the meta document (https://github.com/php-fig/fig-standards/blob/master/proposed/http-client/http-client-meta.md)
I invite you all to review the PSR and give some feedback. You will find the current specification here: https://github.com/php-fig/fig-standards/blob/master/proposed/http-client/http-client.md
Regards
Tobias Nyholm
--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+unsubscribe@googlegroups.com.
To post to this group, send email to php...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/35361389-c53a-4ee4-ac79-195402d9ab14%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
A couple of notes:public function sendRequest($request)Could this be made shorter, without losing meaning?public function send($request)Regarding the exception interfaces:interface ClientException extends \ThrowableWhy Throwable instead of Exception or RuntimeException?Everything else looks very straight forward!
On Mon, Dec 4, 2017 at 3:45 AM, Tobias Nyholm <tobias...@gmail.com> wrote:
After some time of carefully reviewing and discussions on Github I want to let the mailing list know that we are soon comfortable with how PSR-18 looks. We have documented the discussions in the meta document (https://github.com/php-fig/fig-standards/blob/master/proposed/http-client/http-client-meta.md)
I invite you all to review the PSR and give some feedback. You will find the current specification here: https://github.com/php-fig/fig-standards/blob/master/proposed/http-client/http-client.md
Regards
Tobias Nyholm
--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
A couple of notes:public function sendRequest($request)Could this be made shorter, without losing meaning?public function send($request)
Regarding the exception interfaces:interface ClientException extends \ThrowableWhy Throwable instead of Exception or RuntimeException?
Client:
You are just referring to an example that show that if you modify the body you must to the same modifications on the headers.
Exceptions:
By "smaller issues" we mean: Things that do not stop you form sending a request. If you are using the wrong HTTP version in the status line, that does not stop the client from sending the request. The server may be able to handle that anyways. So the client should not be "smart" and help you to fail early.
We do mention 1xx responses. They should be handled by the client.
RequestException:Hm, I do not think so. Why would you ever be interested in a Request that was not sent? Im way more interested in the request that failed, right?
PSR - 18 HTTP Client (Abandoned)
- Tobias identified an issue and will be notifying the group to source needed changes.
- Tobias is waiting on Sara to offer feedback.
- This PSR needs 2 implementations to move forward.