There MUST be one use keyword per declaration <-- does this still apply in PHP7

[Julian Vidal]

I write my projects using PSR-2 enforced by my IDE (PhpStorm) and have phpcs constantly in the background too. While working today, I found something odd that I would like to discuss in this list.

I wrote this:

use App\Services\AuditTrail\Actions\{
    ModelPreUpdate,
    ModelPostUpdate,
    ModelCreated,
    ModelDeleted
};

But phpcs complains that according to PSR-2 I should use this:

use App\Services\AuditTrail\Actions\ModelPreUpdate;
use App\Services\AuditTrail\Actions\ModelPostUpdate;
use App\Services\AuditTrail\Actions\ModelCreated;
use App\Services\AuditTrail\Actions\ModelDeleted;

I looked it up on the PHP-FIG website and indeed phpcs was right.

Is there a particular reason for this? Seems to me the group use declarations are much more readable and shorter to write/read. 

Or is this maybe something that was decided pre PHP7 when group use declarations didn't exist?

Just curious to know...

Cheers!

[Chuck Burgess]

PSR2 indeed predates PHP7.

CRB

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+unsubscribe@googlegroups.com.
To post to this group, send email to php...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/4e4b75f9-cf52-414a-ab6b-4a2a47734f2f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Alessandro Lai]

You should take a look at PSR-12, which is in review right now: https://github.com/php-fig/fig-standards/blob/master/proposed/extended-coding-style-guide.md

[Julian Vidal]

Ah, didn't know about PSR-12. Looks good and indeed contemplates my use case very thoroughly.

--
You received this message because you are subscribed to a topic in the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/php-fig/vatmISyTjjY/unsubscribe.
To unsubscribe from this group and all its topics, send an email to php-fig+unsubscribe@googlegroups.com.

To post to this group, send email to php...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/2e99d6cd-8973-4872-af52-7c9cf7b0d111%40googlegroups.com.