Using GitHub PRs?

[Brad Fitzpatrick]

Perkeepers,

We're thinking of moving off Gerrit and simplifying the contribution experience for most users.

GitHub's built-in code reviews aren't quite as powerful as Gerrit yet, but there are 26 other code review tools that integrate well with GitHub (of which Gerrit is not one of them) that we could use later if we wanted. When we first started using Gerrit, GitHub PRs were much worse. Nowadays I don't think Gerrit's better enough to be worth the complexity of having two systems that don't work well together and we force people to learn.

Any opinions? Anybody object if we drop Gerrit?

- Brad

[Mark Turner]

Coming from someone who has failed to contribute at all, I think anything you can do to lower the barrier of entry is great. But I’m just shouting from the peanut gallery so take my opinion with a grain of salt.

[Zoran Zaric]

> Am 04.06.2019 um 17:07 schrieb Brad Fitzpatrick <br...@danga.com>:
>
> Perkeepers,
>
> We're thinking of moving off Gerrit and simplifying the contribution experience for most users.

Absoute +1 from me as somebody who wanted to contribute something simple but was put off because of the overwhelming Gerrit-process.

Thanks,
Zoran

[clive boulton]

I too have potential commits sitting in a perkeep git fork for Android client and build system because duplicating CLs to Gerrit took too much duplication time.    

--
You received this message because you are subscribed to the Google Groups "Perkeep" group.
To unsubscribe from this group and stop receiving emails from it, send an email to perkeep+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/perkeep/3A51B827-3B26-4553-BE60-C5CEE05D1844%40zoranzaric.de.
For more options, visit https://groups.google.com/d/optout.

[Paul Lindner]

+1  -- too much activation energy makes it hard for me to get back in the game :(

To view this discussion on the web visit https://groups.google.com/d/msgid/perkeep/CANtCYLZtDJwkdSweLakiiLu3%3DRTRxTmgkBHejU2GghEUtecWHA%40mail.gmail.com.

[Lance Wicks]

As much as I love gerritt, it is a bit of a barrier to overcome to contribute.

GitHub is defacto standard, which pains me as it's very much a centralisation. But I'd not object.

--
You received this message because you are subscribed to the Google Groups "Perkeep" group.
To unsubscribe from this group and stop receiving emails from it, send an email to perkeep+u...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/perkeep/CAKPOmqPeqiJ7NwV2yfBP1M0jGyaPPUcL3Um3h0MAmF3TiYDZLQ%40mail.gmail.com.

[Saulius Gurklys]

I think simple proces is always better, of cource if  quality of code is ensured.

+1.

--

S4uliu5 

To view this discussion on the web visit https://groups.google.com/d/msgid/perkeep/CAOc-fTnL%2BJS8f3Ge92gASc3Qx%2B5KnaVpBvP1PHQaNXxuhRv4og%40mail.gmail.com.

[Ian Denhardt]

Quoting Lance Wicks (2019-06-04 16:54:41)

> GitHub is defacto standard, which pains me as it's very much a
> centralisation. But I'd not object.

I'm pretty much in the same spot.

That said, I suspect most of the barrier is that the use of the tool is
quite different; change ids, having to set up tooling locally... Folks
are used to the fork & pr workflow. My gut is that moving to some other
platform (either hosted or on our own infrastructure) with a
sufficiently similar workflow would drop *most* of the barrier --
GitLab, Gogs/Gitea , etc. are all similar, and generally you can even
log in with your GitHub account.

But it probably makes more sense to just use GitHub, if for no other
reason than the bug tracker is there. I guess part of why I don't have a
strong objection despite centralization is I don't really feel like
we're locked in to the provider; if GitHub starts doing things we find
unacceptable, I don't think it will be too onerous to migrate to a
competitor or our own infrastructure. If that starts to change I will
start to worry.

-Ian

[Will Norris]

nothing much add beyond what others have said.  just that yeah, this probably makes sense at this point.

[Brad Fitzpatrick]

All seem in favor, so it's now done:

https://github.com/perkeep/perkeep/commit/41f5d4a19069e7ed3e765e2a9936b7dcf82bfb66

GitHub is now the upstream. Please update your devcam binary & git config origin.

We can finish up any pending reviews on Gerrit and we'll manually cherry-pick and push them to GitHub as needed. (The automatic Gerrit to GitHub sync is now off.)

On Tue, Jun 4, 2019 at 8:07 AM Brad Fitzpatrick <br...@danga.com> wrote: