There is a mistake in document

[史思远]

Hi, 

In https://perfetto.dev/docs/getting-started/ftrace#thread-scoped-slice-tracks

'Thread-scoped slice tracks' Part code example

TP_fast_assign( 

           __entry->track_event_type = track_event_type;

           __assign_str(slice_name); 

),

should be

TP_fast_assign( 

           __entry->track_event_type = track_event_type;

           __assign_str(slice_name, slice_name); 

),

[Lalit Maganti]

Thanks for the report! Mind sending a patch on Github to https://github.com/google/perfetto/blob/815e7e87e800e7ce5b482ee9b4519e70096b1af8/docs/getting-started/ftrace.md?plain=1#L529? 

--
You received this message because you are subscribed to the Google Groups "Perfetto Development - www.perfetto.dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to perfetto-dev...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/perfetto-dev/1d51ac89-ccec-4bac-a502-ea5c4ea7d7e8n%40googlegroups.com.

[Ryan Savitski]

The example is correct for modern kernels (v6.10+), the second parameter of the macro was removed in [1]. Though we could probably add a note to the documentation.

[1] https://lore.kernel.org/linux-trace-kernel/20240516133...@rorschach.local.home/

To view this discussion visit https://groups.google.com/d/msgid/perfetto-dev/CAFF_BgXQ1HnmP8rq5n4AM7nM-D5xTqwKuoBqqF7trDJjo8954g%40mail.gmail.com.

[Lalit Maganti]

I sent https://github.com/google/perfetto/pull/2993 to revert the change to be correct for new kernels while also adding a note for older kernels.

[史思远]

ok