There is a mistake in document

20 views
Skip to first unread message

史思远

unread,
Sep 17, 2025, 10:04:31 PMSep 17
to Perfetto Development - www.perfetto.dev
Hi, 


'Thread-scoped slice tracks' Part code example

TP_fast_assign( 
           __entry->track_event_type = track_event_type;
           __assign_str(slice_name); 
),

should be

TP_fast_assign( 
           __entry->track_event_type = track_event_type;
           __assign_str(slice_name, slice_name); 
),

Lalit Maganti

unread,
Sep 17, 2025, 10:12:30 PMSep 17
to 史思远, Perfetto Development - www.perfetto.dev

--
You received this message because you are subscribed to the Google Groups "Perfetto Development - www.perfetto.dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to perfetto-dev...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/perfetto-dev/1d51ac89-ccec-4bac-a502-ea5c4ea7d7e8n%40googlegroups.com.
Message has been deleted

Ryan Savitski

unread,
Sep 18, 2025, 7:52:34 AMSep 18
to 史思远, Perfetto Development - www.perfetto.dev, Lalit Maganti
The example is correct for modern kernels (v6.10+), the second parameter of the macro was removed in [1]. Though we could probably add a note to the documentation.



Lalit Maganti

unread,
Sep 18, 2025, 9:28:23 AMSep 18
to Ryan Savitski, 史思远, Perfetto Development - www.perfetto.dev
I sent https://github.com/google/perfetto/pull/2993 to revert the change to be correct for new kernels while also adding a note for older kernels.

史思远

unread,
Sep 19, 2025, 11:55:46 AMSep 19
to Perfetto Development - www.perfetto.dev
ok
Reply all
Reply to author
Forward
0 new messages