Please add "Microsoft Windows 10 Sdk v 10.0.15063" to the 'prerequisites' section of pdfium...

[First Last]

Please add "Microsoft Windows 10 Sdk v 10.0.15063" to the 'prerequisites' section of pdfium...
Otherwise, it does not compile ('cl.exe cannot find windows.h')

[Dan Sinclair]

Did anything change here that we need a new version of the windows compiler?

Thanks,

dan

On Tue, Dec 12, 2017 at 2:35 AM, First Last <urie...@gmail.com> wrote:

Please add "Microsoft Windows 10 Sdk v 10.0.15063" to the 'prerequisites' section of pdfium...
Otherwise, it does not compile ('cl.exe cannot find windows.h')

--
You received this message because you are subscribed to the Google Groups "pdfium" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pdfium+unsubscribe@googlegroups.com.
To post to this group, send email to pdf...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/pdfium/b03d4618-c7be-402a-a544-df288e2065c4%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[First Last]

I honestly don't know because it was the first time I tried building it... Devstudio 2017 was installed, but SDK v'15063 wasn't and it didn't build - 'cannot find include file windows.h'. used GYP_MSVS_VERSION=2017.

It took me some time to find the exact version needed but this is the one... 

I think it should be mentioned in the prerequisites documentation is all...

[Lei Zhang]

+Bruce, since we share a lot of the same build prereqs as Chromium.
Should we just link to the Chromium Windows Build docs?

On Tue, Dec 12, 2017 at 7:50 AM, First Last <urie...@gmail.com> wrote:
> I honestly don't know because it was the first time I tried building it...
> Devstudio 2017 was installed, but SDK v'15063 wasn't and it didn't build -
> 'cannot find include file windows.h'. used GYP_MSVS_VERSION=2017.
> It took me some time to find the exact version needed but this is the one...
> I think it should be mentioned in the prerequisites documentation is all...
>
> On Dec 12, 2017 16:21, "Dan Sinclair" <dsin...@chromium.org> wrote:
>
> Did anything change here that we need a new version of the windows compiler?
>
> Thanks,
> dan
>
>
> On Tue, Dec 12, 2017 at 2:35 AM, First Last <urie...@gmail.com> wrote:
>>
>> Please add "Microsoft Windows 10 Sdk v 10.0.15063" to the 'prerequisites'
>> section of pdfium...
>> Otherwise, it does not compile ('cl.exe cannot find windows.h')
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "pdfium" group.
>> To unsubscribe from this group and stop receiving emails from it, send an

>> email to pdfium+un...@googlegroups.com.

[Bruce Dawson]

That seems reasonable. I suspect that pdfium doesn't actually care what SDK version it builds with - it is less likely to have OS dependencies - but having the same dependencies as Chromium is reasonable.

On Tue, Dec 12, 2017 at 9:48 AM, Lei Zhang <the...@chromium.org> wrote:

+Bruce, since we share a lot of the same build prereqs as Chromium.
Should we just link to the Chromium Windows Build docs?

On Tue, Dec 12, 2017 at 7:50 AM, First Last <urie...@gmail.com> wrote:
> I honestly don't know because it was the first time I tried building it...
> Devstudio 2017 was installed, but SDK v'15063 wasn't and it didn't build -
> 'cannot find include file windows.h'. used GYP_MSVS_VERSION=2017.
> It took me some time to find the exact version needed but this is the one...
> I think it should be mentioned in the prerequisites documentation is all...
>
> On Dec 12, 2017 16:21, "Dan Sinclair" <dsin...@chromium.org> wrote:
>
> Did anything change here that we need a new version of the windows compiler?
>
> Thanks,
> dan
>
>
> On Tue, Dec 12, 2017 at 2:35 AM, First Last <urie...@gmail.com> wrote:
>>
>> Please add "Microsoft Windows 10 Sdk v 10.0.15063" to the 'prerequisites'
>> section of pdfium...
>> Otherwise, it does not compile ('cl.exe cannot find windows.h')

>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "pdfium" group.
>> To unsubscribe from this group and stop receiving emails from it, send an

>> email to pdfium+unsubscribe@googlegroups.com.

[Miklos Vajna]

Hi,

As an additional data point, last time I built pdfium with VS2015, I
definitely did not install any additional Windows SDK and it built fine.
I find it unlikely that VS2017 would come without a built-in SDK.

Regards,

Miklos

[Wei Li]

Using VS2017 or a specific SDK is not a requirement posed by pdfium source code. Since pdfium uses the build tool shared with chromium, we get the update from them each time they change. It is reasonable that we just share the requirements doc with them.

You should not need to install a separate SDK. Once you install Visual Studio 2017, SDK should be included by default as a component. If somehow yours doesn't have, you can always select from 'Individual Components'->'Windows 10 SDK'. 

--
You received this message because you are subscribed to the Google Groups "pdfium" group.

To unsubscribe from this group and stop receiving emails from it, send an email to pdfium+unsubscribe@googlegroups.com.

To post to this group, send email to pdf...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/pdfium/20171212213508.fatci2rtgioq5b72%40vmiklos.hu.

[rttso...@gmail.com]

Building pdfium as a shared library, with the now required Visual Studio 2017 and the Windows 10 SDK, is failing because of the hard coded lib paths at the "\pdfium\build\config\win\BUILD.gn" file, lines 237 and 248 ("$windows_sdk_path\Lib\winv6.3\um\x64" and "$windows_sdk_path\Lib\winv6.3\um\x86").
The winv6.3 directory is only valid for the Windows 8.1 SDK. This directory name should be a variable and filled as the $windows_sdk_path one, depending on the SDK version installed. For my case, this directory should be named 10.0.16299.0. because that's the Windows 10 SDK version I have installed.

Building is also possible with the Visual Studio 2017 Build Tools (non IDE install), so it would be nice to have the "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools" path hard coded at the "\pdfium\build\vs_toolchain.py" file, line 155, until the more reliable COM way to find the path is implemented.

[Dan Sinclair]

We get the build/ directory from Chromium so those issues will need to be filed in the chromium repo and fixed there and then we can roll the build changes into PDFium.

dan

--

You received this message because you are subscribed to the Google Groups "pdfium" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pdfium+unsubscribe@googlegroups.com.
To post to this group, send email to pdf...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/pdfium/7a614512-32a6-496b-a330-95f970cf0fad%40googlegroups.com.