vsphere-iso multiple NIC support

17 views
Skip to first unread message

Joshua Foster

unread,
Feb 10, 2020, 2:58:28 PM2/10/20
to Packer
I would like add multiple NIC support to the vsphere-iso plugin. Is there a recommended way to configure this? I can make the "network" and "network_card" fields into array of strings. 

Should we try to start aligning the field names with the vmware-iso plugin (should I rename "network_card" to "network_adapter_type" if I'm making config changes)?

Joshua

Megan Marsh

unread,
Feb 10, 2020, 5:56:17 PM2/10/20
to packe...@googlegroups.com
Hi, if you're interested in contributing let's put this in a feature request issue on github so we can track the discussion and work closer to where the eventual pull request will be! off the top of my head, turning those fields into arrays of strings does seem like the right move. 

I think for now we should hold off on renaming things; in general I try to only rename options on non-patch releases to make it easier for people to keep up with template changes.  But eventually we will want to figure out how to make the options as similar to each other as possible.

Joshua Foster

unread,
Feb 10, 2020, 7:22:27 PM2/10/20
to Packer
Reply all
Reply to author
Forward
0 new messages