spot_price_auto_product is deprecated

[Pascal H]

Hi there,

I'm using Packer v1.5.5 and I have this deprecation warning:

* spot_price_auto_product is deprecated and no longer necessary for Packer builds. In future versions of Packer, inclusion of spot_price_auto_product will error your builds. Please take a look at our current documentation to understand how Packer requests Spot instances.

However, reading the amazon-ebs doc, it seems this option is still required if spot_price is set to auto, or neither is not written as deprecated in the doc:

spot_price_auto_product (string) - Required if spot_price is set to auto. This tells Packer what sort of AMI you're launching to find the best spot price. This must be one of: Linux/UNIX, SUSE Linux, Windows, Linux/UNIX (Amazon VPC), SUSE Linux (Amazon VPC), Windows (Amazon VPC)

However, it seems that packer fix is showing this option as deprecated as well.

So is this option really required as per the doc, or deprecated ?

And if deprecated, what should I do ? simply removing it ?

Thanks in advance.

Rgds

[Wilken Rivera]

Hey there, 

Configuration options for the majority of the builders are auto generated, with until last week, no quick way to remove deprecated options from the docs.  The option is no longer needed and can be ignored.  You can remove it from your config manually or run the fix command to replace each instance of the config option. 

For example `packer fix build.json > fixed_template.json`; If the new generated template looks ok and works as expected you can replace the original build.json file.  

I’ll open up an issue to get the documentation fixed.  

Cheers! 

On May 4, 2020, at 11:47, Pascal H <pasca...@gmail.com> wrote:



--
This mailing list is governed under the HashiCorp Community Guidelines - https://www.hashicorp.com/community-guidelines.html. Behavior in violation of those guidelines may result in your removal from this mailing list.
 
GitHub Issues: https://github.com/mitchellh/packer/issues
IRC: #packer-tool on Freenode
---
You received this message because you are subscribed to the Google Groups "Packer" group.
To unsubscribe from this group and stop receiving emails from it, send an email to packer-tool...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/packer-tool/30f610c3-5ca7-438a-9b90-428488dba8c8%40googlegroups.com.

[Pascal H]

Thanks for the answer and the report!

I see you've create this issue: https://github.com/hashicorp/packer/issues/9163

Removed from config, it works

Thanks and Cheers!