[COMMIT osv master] glibc: add explicit_bzero() function

7 views
Skip to first unread message

Commit Bot

unread,
Jan 9, 2020, 11:28:57 PM1/9/20
to osv...@googlegroups.com, Waldemar Kozaczuk
From: Waldemar Kozaczuk <jwkoz...@gmail.com>
Committer: Waldemar Kozaczuk <jwkoz...@gmail.com>
Branch: master

glibc: add explicit_bzero() function

Signed-off-by: Waldemar Kozaczuk <jwkoz...@gmail.com>

---
diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -1585,6 +1585,7 @@ libc += stdlib/strtod.o
libc += stdlib/wcstol.o

libc += string/__memcpy_chk.o
+libc += string/explicit_bzero.o
libc += string/__explicit_bzero_chk.o
musl += string/bcmp.o
musl += string/bcopy.o
diff --git a/libc/string/explicit_bzero.c b/libc/string/explicit_bzero.c
--- a/libc/string/explicit_bzero.c
+++ b/libc/string/explicit_bzero.c
@@ -0,0 +1,8 @@
+#include <string.h>
+#include <stdlib.h>
+
+void explicit_bzero(void *dest, size_t len)
+{
+ memset(dest, 0, len);
+ return;
+}

Nadav Har'El

unread,
Jan 12, 2020, 5:51:22 AM1/12/20
to Waldemar Kozaczuk, Osv Dev
Looks good. Two very minor comments (which you can ignore):

1. The return is not needed (it doesn't hurt either, so never mind).
2. explicit_bzero() could have simply been an alias for bzero() since it does the same thing - instead of repeating the code.

Reply all
Reply to author
Forward
0 new messages