https://github.com/OpenRefine/OpenRefine/pull/5099
This is obviously an annoying change to introduce, since it will generate merge conflicts with most pull requests which touch those files. But since most changes are indentation changes I hope those conflicts can be resolved with not too much work (running formatting on the PR branch before merging, and "git merge -Xignore-space-change").
Unless anyone suggests another way to introduce this change, I would merge this PR soon.
Thanks,
Antonin
--
You received this message because you are subscribed to the Google Groups "OpenRefine Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to openrefine-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/openrefine-dev/27f8bfe3-63eb-20e2-2c22-30747e4bc114%40antonin.delpeuch.eu.
To view this discussion on the web visit https://groups.google.com/d/msgid/openrefine-dev/CAO%2BzzMt8eSAO_T05K4XT%3DLoD2eE3aDsD1hUDsaAOEUFZqELAAw%40mail.gmail.com.
Thanks both!
Tom: that makes sense. It is a bit sad that there does not seem to be a canonical way to store this in the repository, such that it would be used directly by `git blame` on clones.
Martin: yes, I am not sure if it helpful to advertise PRs or issues on the mailing list since it splits the discussion in two places. My intention was to give this one a bit more publicity given the potential annoyance it can generate.
Antonin
To view this discussion on the web visit https://groups.google.com/d/msgid/openrefine-dev/CAE9vqEFq3_3sWaGmKCtysqHEQbOj7Ves2_ftyMs%2BywfWw0uVfg%40mail.gmail.com.